Re: [PATCH rdma-next v4 0/6] RDMA/irdma: Add support for ioctl

[Leon Romanovsky <leon@kernel.org>]

On Fri, Oct 30, 2026 at 06:15:06PM +0000, David Hu wrote:
> From: David Hu <xuehaohu@google.com>
> 
> Hello,
> 
> This patch series introduces support for uverbs ioctl queue creation
> (QP, CQ, and SRQ) in the irdma driver. This series makes progress towards
> modernizing irdma. This enables 1-step queue creation from pinned UMEMs
> and shared dma-buf heaps (system_cc_shared), providing RDMA support for
> Confidential Computing (CoCo) guest environments where memory encryption
> otherwise prevents standard host-VA-based queues from operating.
> 
> Historically, irdma relied on legacy write() commands for queue setup.
> This series modernizes irdma's queue creation path by adopting the ioctl
> infrastructure:
> 
> 1. Plumbs uverbs_attr_bundle into the irdma QP and SRQ creation routines.
> 2. Registers irdma's UVERBS ioctl namespace definition for QP, CQ, and SRQ.
> 3. Implements 1-step queue buffer creation for QP, CQ, and SRQ using
>    UVERBS_ATTR_CREATE_*_BUF_UMEM attributes and ib_umem_get_attr(),
>    configuring hardware Page Buffer Lists (PBLs) directly from pinned umems.
> 4. Split CQ creation setup logic by umode and kmode into separate
>    routines to be consistent with other queue creation logic.
> 5. Adds support for driver-specific shadow area UMEM attributes during CQ
>    creation with CQ resize capability.
> 6. Preserves backward compatibility with legacy 2-step write() path
>    registrations when UMEM attributes are not provided.
> 
> User space rdma-core PR: https://github.com/linux-rdma/rdma-core/pull/1766
> 
> Testing:
> Verified with rc_pingpong, srq_pingpong, and dmabuf_pingpong over irdma
> devices in Confidential VM environments.
> 
> Changes in v4:
> - Reject dma-buf queue creation in iWARP mode and enforce page-offset
>   alignment unconditionally in irdma_setup_q_pbl_from_umem() (Jacob)
> - Bound attr->cqe in irdma_create_user_cq() to prevent cq_pages overflow (Sashiko)
> - Fix to irdma_cq_free_rsrc() was sent separately (Sashiko)
> - Link to v3: https://lore.kernel.org/all/20261016202909.1289496-1-dhu@x6u.co/

I applied the series, but I have a concern: the commit messages are
not useful.

Thanks