mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Saravanan D <saravanand@crusoe.ai>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Saravanan D <saravanand@crusoe.ai>,
	linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de,
	sagi@grimberg.me, axboe@kernel.dk, dwagner@suse.de,
	sgogte@purestorage.com, hare@kernel.org, hare@suse.de,
	linux-kernel@vger.kernel.org, iyamahata@crusoe.ai,
	kiyer@crusoe.ai, ganbalagane@crusoe.ai, sjpark@crusoe.ai,
	bchen@crusoe.ai
Subject: Re: [PATCH v6 1/2] nvme: add per-queue sysfs directories
Date: Wed,  4 Nov 2026 00:00:25 -0800	[thread overview]
Message-ID: <20261104080035.95142-1-saravanand@crusoe.ai> (raw)
In-Reply-To: <10c9db86-4313-4a1e-bec1-e4eb9ae32ef0@linux.ibm.com>

On 10/30/26 7:46 AM, Nilay Shroff wrote:
>> +	/* transports remove their queue directories before this point */
>> +	if (ctrl->queues_kobj) {
>> +		kobject_del(ctrl->queues_kobj);
>> +		kobject_put(ctrl->queues_kobj);
>> +		ctrl->queues_kobj = NULL;
>> +	}
>
> Can we have a helper something like nvme_queue_dir_destroy()
> and then call it here?

Sure, in v7 I will add nvme_queue_dir_destroy() next to
nvme_queue_dir_create() in sysfs.c and call it from
nvme_uninit_ctrl().

Thanks,
Saravanan D.

  reply	other threads:[~2026-11-04  8:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 23:04 [PATCH v6 0/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-10-23 23:04 ` [PATCH v6 1/2] nvme: add per-queue sysfs directories Saravanan D
2026-10-30 14:46   ` Nilay Shroff
2026-11-04  8:00     ` Saravanan D [this message]
2026-10-23 23:04 ` [PATCH v6 2/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-10-30 14:45   ` Nilay Shroff
2026-11-04  8:00     ` Saravanan D
2026-10-30  0:23 ` [PATCH v6 0/2] " Saravanan D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104080035.95142-1-saravanand@crusoe.ai \
    --to=saravanand@crusoe.ai \
    --cc=axboe@kernel.dk \
    --cc=bchen@crusoe.ai \
    --cc=dwagner@suse.de \
    --cc=ganbalagane@crusoe.ai \
    --cc=hare@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=iyamahata@crusoe.ai \
    --cc=kbusch@kernel.org \
    --cc=kiyer@crusoe.ai \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=sgogte@purestorage.com \
    --cc=sjpark@crusoe.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®