From: Paul Cercueil <paul.cercueil@bootlin.com>
To: Robert Richter <rric@kernel.org>, Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Umesh Kumar <ukumar@marvell.com>,
Shashank Gupta <shashankg@marvell.com>,
Tanmay Jagdale <tanmay@marvell.com>,
Paul Cercueil <paul.cercueil@bootlin.com>
Subject: [PATCH 1/3] i2c: octeon: Add error state recovery
Date: Wed, 4 Nov 2026 11:49:10 +0100 [thread overview]
Message-ID: <20261104104912.166301-2-paul.cercueil@bootlin.com> (raw)
In-Reply-To: <20261104104912.166301-1-paul.cercueil@bootlin.com>
From: Tanmay Jagdale <tanmay@marvell.com>
Whenever a Bus Error state occurs, trigger a software recovery to
attempt to return to a working state.
Signed-off-by: Tanmay Jagdale <tanmay@marvell.com>
Co-developed-by: Paul Cercueil <paul.cercueil@bootlin.com>
Signed-off-by: Paul Cercueil <paul.cercueil@bootlin.com>
---
drivers/i2c/busses/i2c-octeon-core.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
index 93a49e4637ec..9f72ec1feaa0 100644
--- a/drivers/i2c/busses/i2c-octeon-core.c
+++ b/drivers/i2c/busses/i2c-octeon-core.c
@@ -205,6 +205,17 @@ static int octeon_i2c_hlc_wait(struct octeon_i2c *i2c)
return 0;
}
+static int octeon_i2c_recovery(struct octeon_i2c *i2c)
+{
+ int ret;
+
+ ret = i2c_recover_bus(&i2c->adap);
+ if (ret)
+ /* recover failed, try hardware re-init */
+ ret = octeon_i2c_init_lowlevel(i2c);
+ return ret;
+}
+
static int octeon_i2c_check_status(struct octeon_i2c *i2c, int final_read)
{
u8 stat;
@@ -265,8 +276,9 @@ static int octeon_i2c_check_status(struct octeon_i2c *i2c, int final_read)
return -EOPNOTSUPP;
case STAT_TXDATA_NAK:
- case STAT_BUS_ERROR:
return -EIO;
+ case STAT_BUS_ERROR:
+ return octeon_i2c_recovery(i2c) ? -EIO : -EAGAIN;
case STAT_TXADDR_NAK:
case STAT_RXADDR_NAK:
case STAT_AD2W_NAK:
@@ -277,24 +289,13 @@ static int octeon_i2c_check_status(struct octeon_i2c *i2c, int final_read)
/* Set BUS_MON_RST to reset bus monitor */
mode |= BUS_MON_RST_MASK;
octeon_i2c_writeq_flush(mode, i2c->twsi_base + OCTEON_REG_MODE(i2c));
- return -EIO;
+ return octeon_i2c_recovery(i2c) ? -EIO : -EAGAIN;
default:
dev_err(i2c->dev, "unhandled state: %d\n", stat);
return -EIO;
}
}
-static int octeon_i2c_recovery(struct octeon_i2c *i2c)
-{
- int ret;
-
- ret = i2c_recover_bus(&i2c->adap);
- if (ret)
- /* recover failed, try hardware re-init */
- ret = octeon_i2c_init_lowlevel(i2c);
- return ret;
-}
-
/**
* octeon_i2c_start - send START to the bus
* @i2c: The struct octeon_i2c
--
2.47.3
next prev parent reply other threads:[~2026-11-04 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 10:49 [PATCH 0/3] i2c: octeon/thunderx: Fix DMA mask + improvements Paul Cercueil
2026-11-04 10:49 ` Paul Cercueil [this message]
2026-11-04 10:49 ` [PATCH 2/3] i2c: thunderx: Set DMA mask Paul Cercueil
2026-11-04 10:49 ` [PATCH 3/3] i2c: thunderx: Use polling with delay in HS mode Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104104912.166301-2-paul.cercueil@bootlin.com \
--to=paul.cercueil@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@marvell.com \
--cc=shashankg@marvell.com \
--cc=tanmay@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukumar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®