From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793795192; b=U/6wNSberN8StQjPB+5ZmhSMqgcehAg0aXDBiijpAU0RatU3k6EL6dcaHFc0PmofkqUN WRsLbaHV59Ig4GWh+QoulNp7kWrx3/nWPx+zHpGj89J2/QNYv34S1GJCaZcN2ZuYs0kUE RJneFEB/1s22ex2DFD8BUQ21WyK+9qnP5WJWoA8Z2RjoY6srCPhOEp9mCEr4OHOdaOtsH R691vLej1944xQl5VQzdIA+Dhns9rg/KTOhJ9ISCxegR38NrBsFzAh6LKpm9un0p5d/gY o7Cn34pPenha83eAOBpblB7SWKdzr7i2SHLtOnF2PSxXzTIHCNvIIaDtmJrHhl3te3Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793795192; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Ah01QjGgr8WfBtjYH3tsijDXpoatWAgh5NdwXl8Ui5E=; b=iL17pcVV9/JJF9jExxJ4iHiUQ1a/0i3aOrTaOqzlV6KJi+QaVi4qdagSIdrT6n0oddvR ajNfizJe4nEcqanlbIslHpsqowf0dmamOMbccSz6Ka0zc1+gUndFJko1t+EbzrZ/U/0ew yumcE666eeaUCw26gaOLSBYqbLHfhHpfurR7eH9X7OkPF2+4F6YB82k6Hejsi319a7XXL rRc9u1JDZaXra0l3lq35jPo9QD7WNl6IyFvwFepSWnSrw8GutxU55wMQFDeZoxKHZ4GFn GkE4G91OL/l8UrUO32V+0zwtWT10ejRXu2Q1qRx+57rd9FER9vl1uIryTI4nZ+0PMMw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=MBWDylpU; arc=none smtp.remote-ip=209.85.128.54 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9D2606D838 for ; Wed, 4 Nov 2026 12:26:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5E9D2606D838 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=MBWDylpU Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4ac95761c85so4425785e9.2 for ; Wed, 04 Nov 2026 04:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793795191; x=1794399991; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Ah01QjGgr8WfBtjYH3tsijDXpoatWAgh5NdwXl8Ui5E=; b=MBWDylpUMLPpAQauptal2At6SZB/IwIaOH471zVag92+ms4xNz0x1Msy4vBCIAXmr3 vdzlMxxI/1SQ+fQ0IOwDA5+yMjCUP037RYPIcCZ8Y7FhTKyxjTL6gDUvZC01prOCBf6h sjmFvSMMEW6fh2EY2OEMAB4aohwHKu62PrMRYEmHNoiyFW6nbZSUX2jvdqO3BNU4HPAB rj1OsVcpb2qoEe0iXdurYcW5bBw8e9XuHdTHOFl6mQpySIYZA6lrJOKaHd5M1Jh3cuSo bYBYheF215jg8ly4Ye7+cxv8zh0d6qfQ+K4q1r6FPDntAv6dRi1oHdfCzBf+FeGhSmIK jfhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793795191; x=1794399991; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ah01QjGgr8WfBtjYH3tsijDXpoatWAgh5NdwXl8Ui5E=; b=k5NBnESAvGKn2Ie7Nj/7Np+cVuQQBbxDSmCIL1mnrfAkt6LDTYEWKsFxOc5psTR3iy 09V1p9XuAvl4Ijj6VlOGtOpYlCCb2T8+VqJmzUW3HtgEJ2lav/Wr0KZfuRC5kRCd348K 2Z+c2F60uC+3fjcwveB8dLeyQYUd/816bgx+74SP2B8LPc4ft6WGK3+pPlMwHg4fiihq K2jE9s08Lq2Hh0sDGAtnrOkCnCRFnWidhUTJ8k8+seIcnSqIhqpYb2DgNJGNj1eIbn6r KUocmWjqTM1K0Bc4Mlo1JYMGeKUJJQH9vVsivRiJsfsuFcWh6KHWlvf4L5MtCTXBEB0B Uksg== X-Forwarded-Encrypted: i=1; AKwUvByJJZiK8A+A6dBKXGKZ+mMmCKpLth4tzLB//YqOD8BR70n36faTpZH8GNJVw+OE8gGl+ydLM+JjeeNZ870=@vger.kernel.org X-Gm-Message-State: APuU4Z+qEogYJFy67+ID8P19RBxCoaSu7a0iE/aowA6h6v26cttI5b2F j5gFqn0JCaZskknPYCLkkcyQppNnbv/z3e7Iu/dL4EIWHs9zn1jqCbVA X-Gm-Gg: AYBFou1iXePQb3C94Q39hiVhhRcFevhzgl/WxnuKmhzp+QqkpoY1WLW3L5608psphhk 6h83UYegYmR5dY+ftLlQJ6iChj724yek2Yq9e0pXr9aJ999wN5xaaXnfNkBCCy8V1cK2938eCbj oloyTMETILz+wNIEIn6MyszA9jIQljgNLHVh5g42c7Bs2erx7uYDUjXTuRYL+oSFeUNnOzJJL3w HGtzKfBeMxGzTyoMxtxM1w89cj4lPpKUeWcePJncqpy7Ix0BnO6ZFPJAQ84NHbj1bRN+3XhnvpR vSQ9t5laCniaHcZn659FSzyacMwUKrcCn1EhZWYD8EizX2Vy5VS0H+p6C8KmTrAly+bQlk9BW3I /BZR0tRDRYNTy0AvVdFLYBf9qJSAihRU2wLUZ3vmwSrr7uFmu06+3fOtotX0ga1UgpZ6LFjyXJr CH+VtWVdE2/CrdqqTxwWboBd1XLIL05cdHUN6OAbL+gSyJpO9KKs4e+8v3wwlzD9aYgTNcT3yd5 ZHIozAqFrs+1g+F5Wie3/SdXJz6wQcQQqE7hQ0MQLiWi2G7vjRtszM3I0Y7BnUZXdUj2j50FRcz +xviJnAtoamv8FbbwoVMol2Qhc7yWRF1FxZ0Xq+J6eqYzSamhw== X-Received: by 2002:a05:600c:1f8d:b0:4a2:c9b:9b98 with SMTP id 5b1f17b1804b1-4ac177539f6mr352866395e9.17.1793795190436; Wed, 04 Nov 2026 04:26:30 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b43da9825bsm50492415e9.15.2026.11.04.04.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 04:26:29 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Griffin Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Florian Krischer Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, mfd@lists.linux.dev, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v13 3/7] input: serio: Add driver for ASUS Transformer dock keyboard and touchpad Date: Wed, 4 Nov 2026 14:26:02 +0200 Message-ID: <20261104122606.215629-4-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261104122606.215629-1-clamor95@gmail.com> References: <20261104122606.215629-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Michał Mirosław Add input driver for ASUS Transformer dock keyboard and touchpad. Some keys in ASUS Dock report keycodes that don't make sense according to their position, this patch modifies the incoming data that is sent to serio to send proper scancodes. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Michał Mirosław Tested-by: Florian Krischer # ASUS SL101 Acked-by: Dmitry Torokhov Signed-off-by: Svyatoslav Ryhel --- drivers/input/serio/Kconfig | 15 + drivers/input/serio/Makefile | 1 + drivers/input/serio/asus-transformer-ec-kbc.c | 258 ++++++++++++++++++ 3 files changed, 274 insertions(+) create mode 100644 drivers/input/serio/asus-transformer-ec-kbc.c diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index 087f0203fff99..58d415ca1d540 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -84,6 +84,21 @@ config SERIO_RPCKBD To compile this driver as a module, choose M here: the module will be called rpckbd. +config SERIO_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Dock keyboard and touchpad controller" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use the keyboard and/or touchpad on + Asus Transformed's Mobile Dock. + + For keyboard support you also need atkbd driver. + + For touchpad support you also need psmouse driver with Elantech + touchpad option enabled. + + To compile this driver as a module, choose M here: the module will + be called asus-transformer-ec-kbc. + config SERIO_AMBAKMI tristate "AMBA KMI keyboard controller" depends on ARM_AMBA diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile index 7f5137dc02e26..bed2a7a92a13d 100644 --- a/drivers/input/serio/Makefile +++ b/drivers/input/serio/Makefile @@ -12,6 +12,7 @@ obj-$(CONFIG_SERIO_SERPORT) += serport.o obj-$(CONFIG_SERIO_RPCKBD) += rpckbd.o obj-$(CONFIG_SERIO_SA1111) += sa1111ps2.o obj-$(CONFIG_SERIO_AMBAKMI) += ambakmi.o +obj-$(CONFIG_SERIO_ASUS_TRANSFORMER_EC) += asus-transformer-ec-kbc.o obj-$(CONFIG_SERIO_Q40KBD) += q40kbd.o obj-$(CONFIG_SERIO_GSCPS2) += gscps2.o obj-$(CONFIG_HP_SDC) += hp_sdc.o diff --git a/drivers/input/serio/asus-transformer-ec-kbc.c b/drivers/input/serio/asus-transformer-ec-kbc.c new file mode 100644 index 0000000000000..cff18da6d59d7 --- /dev/null +++ b/drivers/input/serio/asus-transformer-ec-kbc.c @@ -0,0 +1,258 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include + +struct asus_ec_kbc_data { + struct notifier_block nb; + struct asusec_core *ec; + struct i2c_client *parent; + struct serio *sdev[2]; + bool altgr_delayed; + bool altgr_suppressed; +}; + +static bool asus_ec_kbc_altgr_active(struct asus_ec_kbc_data *priv) +{ + return IS_ENABLED(CONFIG_KEYBOARD_ASUS_TRANSFORMER_EC) && + (priv->ec->ext_keys_enabled || priv->altgr_delayed || + priv->altgr_suppressed); +} + +static void asus_ec_kbc_reset_altgr(struct asus_ec_kbc_data *priv) +{ + if (!IS_ENABLED(CONFIG_KEYBOARD_ASUS_TRANSFORMER_EC)) + return; + + priv->ec->right_alt_pressed = false; + priv->ec->special_combo_triggered = false; + priv->altgr_delayed = false; + priv->altgr_suppressed = false; +} + +static void asus_ec_kbc_sync_altgr_combo(struct asus_ec_kbc_data *priv) +{ + if (priv->ec->special_combo_triggered) { + priv->ec->special_combo_triggered = false; + if (priv->altgr_delayed) { + priv->altgr_delayed = false; + priv->altgr_suppressed = true; + } + } +} + +static void asus_ec_kbc_flush_altgr(struct asus_ec_kbc_data *priv) +{ + if (!asus_ec_kbc_altgr_active(priv)) + return; + + asus_ec_kbc_sync_altgr_combo(priv); + + if (!priv->altgr_delayed) + return; + + serio_interrupt(priv->sdev[0], 0xe0, 0); + serio_interrupt(priv->sdev[0], 0x11, 0); + + priv->altgr_delayed = false; +} + +static bool asus_ec_kbc_handle_altgr(struct asus_ec_kbc_data *priv, bool is_release) +{ + bool suppressed; + + if (!asus_ec_kbc_altgr_active(priv)) { + asus_ec_kbc_reset_altgr(priv); + return false; + } + + asus_ec_kbc_sync_altgr_combo(priv); + + if (!is_release) { + if (!priv->ec->right_alt_pressed) { + asus_ec_kbc_reset_altgr(priv); + priv->ec->right_alt_pressed = true; + priv->altgr_delayed = true; + return true; + } + + return priv->altgr_delayed || priv->altgr_suppressed; + } + + suppressed = priv->altgr_suppressed; + if (!suppressed) + asus_ec_kbc_flush_altgr(priv); + + asus_ec_kbc_reset_altgr(priv); + return suppressed; +} + +static int asus_ec_kbc_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_kbc_data *priv = container_of(nb, struct asus_ec_kbc_data, nb); + unsigned int port_idx, n; + u8 *data = data_; + + if (action & (ASUSEC_SMI_MASK | ASUSEC_SCI_MASK)) { + if (action == ASUSEC_SMI_ACTION(HANDSHAKE) || + action == ASUSEC_SMI_ACTION(RESET)) + asus_ec_kbc_reset_altgr(priv); + return NOTIFY_DONE; + } else if (action & ASUSEC_AUX_MASK) { + port_idx = 1; + } else if (action & priv->ec->keyboard_mask) { + port_idx = 0; + } else { + return NOTIFY_DONE; + } + + /* + * The data[0] is the number of bytes following the count byte: one + * status byte plus the payload. The SL101 EC, for example, reports + * keyboard reset as 03 09 fa aa (status 09, ACK fa, BAT aa). Skip the + * count and status bytes and forward every payload byte to serio. + */ + if (data[0] < 2 || data[0] > ASUSEC_ENTRY_SIZE) + return NOTIFY_BAD; + + n = data[0] - 1; + data += 2; + + if (port_idx == 0) { + /* + * Remap keyboard key codes to match AT layout: + * ALTGR: RIGHT-ALT [E0 11] -> delayed / suppressed + * SEARCH: RIGHT-META [E0 27] -> LEFT-ALT [11] + * MENU: COMPOSE [E0 2F] -> RIGHT-META [E0 27] + */ + if ((n == 2 || (n == 3 && data[1] == 0xF0)) && data[0] == 0xE0) { + u8 *keycode = &data[n - 1]; + + switch (*keycode) { + case 0x11: + if (asus_ec_kbc_handle_altgr(priv, n == 3)) + return NOTIFY_OK; + break; + case 0x27: + *keycode = 0x11; + ++data; + --n; + break; + case 0x2F: + *keycode = 0x27; + break; + } + } + + /* + * Only flush delayed AltGr on key make events, ignoring + * key break codes and PS/2 command responses (ACK, BAT, etc.). + */ + if ((n == 2 && data[0] == 0xe0) || + (n == 1 && data[0] > 0 && data[0] < 0x84) || data[0] == 0xe1) + asus_ec_kbc_flush_altgr(priv); + } + + while (n--) + serio_interrupt(priv->sdev[port_idx], *data++, 0); + + return NOTIFY_OK; +} + +static int asus_ec_serio_write(struct serio *port, unsigned char data) +{ + struct asus_ec_kbc_data *priv = port->port_data; + + return i2c_smbus_write_word_data(priv->parent, ASUSEC_WRITE_BUF, + (data << 8) | port->id.extra); +} + +static void asus_ec_serio_remove(void *port) +{ + serio_unregister_port(port); +} + +static int asus_ec_register_serio(struct platform_device *pdev, int idx, const char *name, int cmd) +{ + struct asus_ec_kbc_data *priv = platform_get_drvdata(pdev); + struct i2c_client *parent = priv->parent; + struct serio *port = kzalloc_obj(*port); + + if (!port) + return -ENOMEM; + + priv->sdev[idx] = port; + port->dev.parent = &pdev->dev; + port->id.type = SERIO_8042; + port->id.extra = cmd & 0xFF; + port->write = asus_ec_serio_write; + port->port_data = (void *)priv; + snprintf(port->name, sizeof(port->name), "%s %s", priv->ec->model, name); + snprintf(port->phys, sizeof(port->phys), "i2c-%u-%04x/serio%d", + i2c_adapter_id(parent->adapter), parent->addr, idx); + + serio_register_port(port); + + return devm_add_action_or_reset(&pdev->dev, asus_ec_serio_remove, port); +} + +static void asus_ec_notifier_chain_unregister(void *data) +{ + struct asus_ec_kbc_data *priv = data; + struct asusec_core *ec = priv->ec; + + blocking_notifier_chain_unregister(&ec->notify_list, &priv->nb); +} + +static int asus_ec_kbc_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct asusec_core *ec = dev_get_drvdata(dev->parent); + struct asus_ec_kbc_data *priv; + int error; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + priv->ec = ec; + priv->parent = to_i2c_client(dev->parent); + + priv->nb.notifier_call = asus_ec_kbc_notify; + error = blocking_notifier_chain_register(&ec->notify_list, &priv->nb); + if (error) + return dev_err_probe(dev, error, "Failed to register blocking notifier chain"); + + error = devm_add_action_or_reset(dev, asus_ec_notifier_chain_unregister, priv); + if (error) + return error; + + error = asus_ec_register_serio(pdev, 0, "Keyboard", 0); + if (error) + return error; + + error = asus_ec_register_serio(pdev, 1, "Touchpad", I8042_CMD_AUX_SEND); + if (error) + return error; + + return 0; +} + +static struct platform_driver asus_ec_kbc_driver = { + .driver.name = "asus-transformer-ec-kbc", + .probe = asus_ec_kbc_probe, +}; +module_platform_driver(asus_ec_kbc_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-kbc"); +MODULE_AUTHOR("Michał Mirosław "); +MODULE_DESCRIPTION("ASUS Transformer's Dock keyboard and touchpad driver"); +MODULE_LICENSE("GPL"); -- 2.53.0