From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793795199; b=PXBX8HRqtnBhBzyaRq3+DCJwYRH6uqHNBn3JDiRgQnv/cspPfAcvcqUE+1ZWEOZDLCpF 2bVghZgMiaX405m36FLh9ZsRGipWYzPca+tGkyhrueIWoUI5sv1+vgcU+zAuFMP3jYVoX zeNd+Q2PiiBpUuc4FFphJZ4SEx2slaCnewnQB1mvlkJBoWeVbWIZ+2msDeoZG/yFNcV2G rw+gyRaT54Eo8rKRm9tYq+7XqJZ4pBBNeMo/KED0g/oMPdQpfSecxR5V3he8sV9UsyhML fexks3EI6wKO7PknJdTarokR6p3gnxARrSKPppwpB13bp8HuPY60ccmjUdjrezfOSQA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793795199; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=WFDlyoZB7f18B/lPyVmWgAS81CxVxhcEOqRbakazlQ4=; b=X7yUYBIxrtC+q7Ui3tK1PP2QUjNezUf8cSRX6g/yxh3LiUUjqwMZYZnuFIOomE7jsDhy A0A74eugQCDek6WbgX7TsCI5sBCWr0n2qOPp4S3QAAM7uG7qnPAxhuFsT+De7qQyV30Z+ XOFB0qInfGIpx8AIsek29kxPFSIZ5sz1+7HDOgB9AAzpvczRRIE5P5p7wtQnPklVd/7QQ q7qBxTfd29o/v0S+uySP8EIO5ElQTOQXsd1QliSPwvOeaekgYHn4Id5ADwR5ZI2vMFSAv M7QvHvAMY3rfFG+hT4NKDH9cyBvqhc+jLjXDKeYoYnd1uNT+yBXizrGbmDzWQ0pVW0Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=FDNO8Hoe; arc=none smtp.remote-ip=209.85.128.42 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302DB606D827 for ; Wed, 4 Nov 2026 12:26:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 302DB606D827 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=FDNO8Hoe Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4a214c5c4c0so5742495e9.3 for ; Wed, 04 Nov 2026 04:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793795197; x=1794399997; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WFDlyoZB7f18B/lPyVmWgAS81CxVxhcEOqRbakazlQ4=; b=FDNO8Hoenxsk9RdhBjUJf1xXGIubiTiiFjh8a8rZmYEaPTHWI/JA9b/CIpWY0vyuT5 ZoG2PrgS5+mMGh2+N6uorh26BABTsNMSEkqkWqp8WBVYtiDMDw7JfiUG8ApMAV8uVyzE aC7re713i44tUyQ5KK5uAWu8eeffiSY/NYuSBcp/T884VTWQLbQ5mmn76u3RaL4joXZn C7lDhje+qpOgUglBX26W37f4N9+RrPQUgJ5Q1e+3I2ZxQVkqTnL8wmn83QaSgckcWXKf 2RcrmyzxBinzbD5b9CD5txaG/VcZExADmWCd6X1+gY1TjF9XjnS/bHmcs2oWi2IsBGdB UqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793795198; x=1794399998; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WFDlyoZB7f18B/lPyVmWgAS81CxVxhcEOqRbakazlQ4=; b=qmbnjBUkryDgYbxO2tLHxMzKrRnihkm5l18DekCPBn9megoyFCN/OBWEtFLnqp+WcN Z1rHn4nJo7JO8VZ18vMvDnNGxRNS0tMMboOYu4ssV1sAgldMy++3gasTNlGK/9QOJYEl odK3FjztVuc5Xyf0xtorXRgBort4Rp04tSap9l0GdvHNV3i7jHdLYkejbcsCAWljxYhr JPPs4R6wXn+983Ka1iQ3N9wmph33knm/54qFro/E7F2MJYsEZqKbOJzx/MwsOrrr8hE0 d3kbflrNKjPJi3yihMNCuoOjqmkKh5x9HZdKCKrNI6qzPewp4joiZzaYbUk7vx8t3DWu 34eA== X-Forwarded-Encrypted: i=1; AKwUvBwGfn/jC6gkvGhB1lh7+gqWyu7hhTfI9aw4Y+ohSyV/9NDKMxvlVHC45Zxll7PlDEaOVT4ZrCjzOaMk/bc=@vger.kernel.org X-Gm-Message-State: APuU4Z++YC6hfrOmqPtcogU9Cakux9QkvtZSeIpES4d7KtaJFEDz240i u67E5kzh0UIYP79jan33sKau5Kr2zcbaMZZEaP2B55kGIxeg3KSaZN0/ X-Gm-Gg: AYBFou2Ti0g4hFkI4XUKhO8a9WWbdz8hieRTCnNNlRz55wabPsJUeGMLgG8K5R/THCT 45cJApq2UMyqqnXDU9+vi1x1KzF38FEEsI43Sx3EHnXT35v4S/mLdpyFDZOs/Ss8wsNJRK16lcY GUkfsw78U+jSC6KloYf7+finLCdZLa8gJiP+7+Y7PSRWaDFlznVhqtPy+VXUKeG14LEPCR2c1B4 gZuDlxZxFv0T0n6jUCa1/AzD1dPNQ+zLB4JVNklybLEZgiDRLuI7P5WXlpYBEo/zuvHenNs4Z1C r0NtROsEErWBkQ0zPRkZsdDtGpgQbmfTKtbaDxReScAT61h3q00xUlh+mlxE7ERnxGCL6AL63iB PecEycpox/K6YVl7kgXV1uH78hptaCNEK8AKhIXduMXcKFnqAN8Ay8bdSDRZqz44Ec+Jpq55yPy 0fXd3oLOVUvegl8NGCew8CH/Hx8kxuHL66hpLzuWqG1qDxg/bwgF9xA6B5Y8ZWS3SgQ2IPg2nUV Ik/6WtUYxDKNf5AwF2Oz3YYWvLJkPCU+PoHgwwYu6bmmDfsRPmxpkgmUIi+Y0ak/n/fdf94z6L9 X4doI7G5Pk3frr0/REjfMlbK4tZGMDxtdfDRMmpz5Ywo8XSJxg== X-Received: by 2002:a05:600c:638f:b0:4a2:1050:aff with SMTP id 5b1f17b1804b1-4ac17d16a26mr365450235e9.6.1793795197552; Wed, 04 Nov 2026 04:26:37 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b43da9825bsm50492415e9.15.2026.11.04.04.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 04:26:36 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Griffin Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Florian Krischer Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, mfd@lists.linux.dev, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v13 6/7] power: supply: Add driver for ASUS Transformer battery Date: Wed, 4 Nov 2026 14:26:05 +0200 Message-ID: <20261104122606.215629-7-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261104122606.215629-1-clamor95@gmail.com> References: <20261104122606.215629-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Michał Mirosław Driver implements one battery cell per EC controller and supports reading of battery status for ASUS Transformer's pad and mobile dock. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Michał Mirosław Reviewed-by: Sebastian Reichel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + .../supply/asus-transformer-ec-battery.c | 289 ++++++++++++++++++ 3 files changed, 301 insertions(+) create mode 100644 drivers/power/supply/asus-transformer-ec-battery.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index ee7dc5f2617a4..856eb81c97ae9 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -122,6 +122,17 @@ config BATTERY_CHAGALL This driver can also be built as a module. If so, the module will be called chagall-battery. +config BATTERY_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's battery driver" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y to enable support for battery status access on Tegra based + ASUS Transformer devices. + + This sub-driver supports battery cells found in Asus Transformer + tablets and mobile docks and controlled by a special embedded + controller. + config BATTERY_CPCAP tristate "Motorola CPCAP PMIC battery driver" depends on MFD_CPCAP && IIO diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index f3c0d1006c1a2..bec4a6263048c 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -22,6 +22,7 @@ obj-$(CONFIG_TEST_POWER) += test_power.o obj-$(CONFIG_BATTERY_88PM860X) += 88pm860x_battery.o obj-$(CONFIG_CHARGER_ADP5061) += adp5061.o obj-$(CONFIG_BATTERY_ACT8945A) += act8945a_charger.o +obj-$(CONFIG_BATTERY_ASUS_TRANSFORMER_EC) += asus-transformer-ec-battery.o obj-$(CONFIG_BATTERY_AXP20X) += axp20x_battery.o obj-$(CONFIG_CHARGER_AXP20X) += axp20x_ac_power.o obj-$(CONFIG_BATTERY_CHAGALL) += chagall-battery.o diff --git a/drivers/power/supply/asus-transformer-ec-battery.c b/drivers/power/supply/asus-transformer-ec-battery.c new file mode 100644 index 0000000000000..46bd50001e47d --- /dev/null +++ b/drivers/power/supply/asus-transformer-ec-battery.c @@ -0,0 +1,289 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_BATTERY_DATA_FRESH_MSEC 5000 + +#define ASUSEC_BATTERY_DISCHARGING BIT(6) +#define ASUSEC_BATTERY_FULL_CHARGED BIT(5) +#define ASUSEC_BATTERY_NOT_CHARGING BIT(4) + +#define TEMP_CELSIUS_OFFSET 2731 + +struct asus_ec_battery_data { + struct asusec_core *ec; + struct power_supply *battery; + struct power_supply_desc psy_desc; + struct delayed_work poll_work; + struct mutex battery_lock; /* for data refresh */ + unsigned long batt_data_ts; + int last_state; + u8 batt_data[ASUSEC_ENTRY_BUFSIZE]; +}; + +static int asus_ec_battery_refresh(struct asus_ec_battery_data *priv) +{ + struct i2c_client *client = priv->ec->dockram; + struct device *dev = &client->dev; + int ret = 0; + + if (time_before(jiffies, priv->batt_data_ts)) + return ret; + + memset(priv->batt_data, 0, ASUSEC_ENTRY_BUFSIZE); + ret = i2c_smbus_read_i2c_block_data(client, ASUSEC_DOCKRAM_BATT_CTL, + ASUSEC_ENTRY_SIZE, priv->batt_data); + if (ret < ASUSEC_ENTRY_SIZE) + return ret < 0 ? ret : -EIO; + + if (priv->batt_data[0] > ASUSEC_ENTRY_SIZE) { + dev_err(dev, "bad data len; buffer: %*ph; ret: %d\n", + ASUSEC_ENTRY_BUFSIZE, priv->batt_data, ret); + return -EPROTO; + } + + priv->batt_data_ts = jiffies + + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC); + + return ret; +} + +static enum power_supply_property asus_ec_battery_properties[] = { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_VOLTAGE_MAX, + POWER_SUPPLY_PROP_CURRENT_MAX, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, + POWER_SUPPLY_PROP_TIME_TO_FULL_NOW, + POWER_SUPPLY_PROP_PRESENT, +}; + +static const unsigned int asus_ec_battery_prop_offs[] = { + [POWER_SUPPLY_PROP_STATUS] = 1, + [POWER_SUPPLY_PROP_VOLTAGE_MAX] = 3, + [POWER_SUPPLY_PROP_CURRENT_MAX] = 5, + [POWER_SUPPLY_PROP_TEMP] = 7, + [POWER_SUPPLY_PROP_VOLTAGE_NOW] = 9, + [POWER_SUPPLY_PROP_CURRENT_NOW] = 11, + [POWER_SUPPLY_PROP_CAPACITY] = 13, + [POWER_SUPPLY_PROP_CHARGE_NOW] = 15, + [POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW] = 17, + [POWER_SUPPLY_PROP_TIME_TO_FULL_NOW] = 19, +}; + +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv, + enum power_supply_property psp) +{ + int ret, offs; + + guard(mutex)(&priv->battery_lock); + + if (psp >= ARRAY_SIZE(asus_ec_battery_prop_offs)) + return -EINVAL; + + offs = asus_ec_battery_prop_offs[psp]; + if (!offs) + return -EINVAL; + + ret = asus_ec_battery_refresh(priv); + if (ret < 0) + return ret; + + if (offs >= priv->batt_data[0]) + return -ENODATA; + + return get_unaligned_le16(priv->batt_data + offs); +} + +static int asus_ec_battery_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_battery_data *priv = power_supply_get_drvdata(psy); + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_PRESENT: + val->intval = 1; + break; + + default: + ret = asus_ec_battery_get_value(priv, psp); + if (ret < 0) + return ret; + + val->intval = (s16)ret; + + switch (psp) { + case POWER_SUPPLY_PROP_STATUS: + if (ret & ASUSEC_BATTERY_FULL_CHARGED) + val->intval = POWER_SUPPLY_STATUS_FULL; + else if (ret & ASUSEC_BATTERY_NOT_CHARGING) + val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (ret & ASUSEC_BATTERY_DISCHARGING) + val->intval = POWER_SUPPLY_STATUS_DISCHARGING; + else + val->intval = POWER_SUPPLY_STATUS_CHARGING; + break; + + case POWER_SUPPLY_PROP_TEMP: + val->intval -= TEMP_CELSIUS_OFFSET; + break; + + case POWER_SUPPLY_PROP_CHARGE_NOW: + case POWER_SUPPLY_PROP_CURRENT_NOW: + case POWER_SUPPLY_PROP_CURRENT_MAX: + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + case POWER_SUPPLY_PROP_VOLTAGE_MAX: + val->intval *= 1000; + break; + + case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW: + case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW: + val->intval = ret * 60; + break; + + default: + break; + } + + break; + } + + return 0; +} + +static void asus_ec_battery_poll_work(struct work_struct *work) +{ + struct asus_ec_battery_data *priv = + container_of(work, struct asus_ec_battery_data, poll_work.work); + int state; + + state = asus_ec_battery_get_value(priv, POWER_SUPPLY_PROP_STATUS); + if (state < 0) + goto reschedule; + + if (state & ASUSEC_BATTERY_FULL_CHARGED) + state = POWER_SUPPLY_STATUS_FULL; + else if (state & ASUSEC_BATTERY_NOT_CHARGING) + state = POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (state & ASUSEC_BATTERY_DISCHARGING) + state = POWER_SUPPLY_STATUS_DISCHARGING; + else + state = POWER_SUPPLY_STATUS_CHARGING; + + if (priv->last_state != state) { + priv->last_state = state; + power_supply_changed(priv->battery); + } + +reschedule: + /* continuously send uevent notification */ + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); +} + +static const struct power_supply_desc asus_ec_battery_desc = { + .name = "asus-ec-battery", + .type = POWER_SUPPLY_TYPE_BATTERY, + .properties = asus_ec_battery_properties, + .num_properties = ARRAY_SIZE(asus_ec_battery_properties), + .get_property = asus_ec_battery_get_property, + .external_power_changed = power_supply_changed, +}; + +static int asus_ec_battery_probe(struct platform_device *pdev) +{ + struct asusec_core *ec = dev_get_drvdata(pdev->dev.parent); + struct asus_ec_battery_data *priv; + struct device *dev = &pdev->dev; + struct power_supply_config cfg = { }; + int ret; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + mutex_init(&priv->battery_lock); + + priv->ec = ec; + priv->batt_data_ts = jiffies - 1; + priv->last_state = POWER_SUPPLY_STATUS_UNKNOWN; + + cfg.fwnode = dev_fwnode(dev->parent); + cfg.drv_data = priv; + + memcpy(&priv->psy_desc, &asus_ec_battery_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name = devm_kasprintf(dev, GFP_KERNEL, "%s-battery", + priv->ec->name); + if (!priv->psy_desc.name) + return -ENOMEM; + + priv->battery = devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->battery)) + return dev_err_probe(dev, PTR_ERR(priv->battery), + "Failed to register power supply\n"); + + ret = devm_delayed_work_autocancel(dev, &priv->poll_work, + asus_ec_battery_poll_work); + if (ret) + return ret; + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static int __maybe_unused asus_ec_battery_suspend(struct device *dev) +{ + struct asus_ec_battery_data *priv = dev_get_drvdata(dev); + + cancel_delayed_work_sync(&priv->poll_work); + + return 0; +} + +static int __maybe_unused asus_ec_battery_resume(struct device *dev) +{ + struct asus_ec_battery_data *priv = dev_get_drvdata(dev); + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(asus_ec_battery_pm_ops, + asus_ec_battery_suspend, asus_ec_battery_resume); + +static struct platform_driver asus_ec_battery_driver = { + .driver = { + .name = "asus-transformer-ec-battery", + .pm = &asus_ec_battery_pm_ops, + }, + .probe = asus_ec_battery_probe, +}; +module_platform_driver(asus_ec_battery_driver); + +MODULE_ALIAS("platform:asus-transformer-ec-battery"); +MODULE_AUTHOR("Michał Mirosław "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's battery driver"); +MODULE_LICENSE("GPL"); -- 2.53.0