From: Tristan Madani <tristmd@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: robin@protonic.nl, o.rempel@pengutronix.de,
socketcan@hartkopp.net, mkl@pengutronix.de,
kernel@pengutronix.de, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net] can: j1939: fix skb refcount underflow in session teardown paths
Date: Wed, 4 Nov 2026 13:01:51 +0000 [thread overview]
Message-ID: <20261104130151.2659605-1-tristmd@gmail.com> (raw)
In-Reply-To: <179376780412.488853.11738408007557929503@kernel.org>
From: Tristan Madani <tristan@talencesecurity.com>
On Wed, 04 Nov 2026, netdev-bot+sashiko@kernel.org wrote:
> [Severity: Critical]
> Does this leak every skb on session->skb_queue?
Yes, this is correct. Queued skbs carry refcount 2 (one from the
allocation and one from skb_get in j1939_session_new /
j1939_session_skb_queue), so the existing skb_unref + kfree_skb
sequence is the intended teardown path. Removing skb_unref would
leave every skb at refcount 1 after kfree_skb, leaking it.
Withdrawing this patch.
pw-bot: cr
prev parent reply other threads:[~2026-11-04 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 15:53 Tristan Madani
2026-11-04 4:50 ` netdev-bot+sashiko
2026-11-04 13:01 ` Tristan Madani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104130151.2659605-1-tristmd@gmail.com \
--to=tristmd@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®