mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jude Gyimah <jude.gyimah87@gmail.com>
To: matthew.brost@intel.com, thomas.hellstrom@linux.intel.com,
	rodrigo.vivi@intel.com
Cc: airlied@gmail.com, simona@ffwll.ch,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Jude Gyimah <jude.gyimah87@gmail.com>
Subject: [PATCH] drm/xe: fix CONFIGFS_FS dependency
Date: Wed,  4 Nov 2026 14:47:28 +0100	[thread overview]
Message-ID: <20261104134728.3723002-1-jude.gyimah87@gmail.com> (raw)

xe_configfs.o is pulled into the xe module only when configfs is enabled:

  xe-$(CONFIG_CONFIGFS_FS) += xe_configfs.o

With CONFIG_DRM_XE=y and CONFIG_CONFIGFS_FS=m that line becomes xe-m,
which Kbuild ignores for a built-in module, so the object is left out
while the rest of xe still calls into it:

  xe_guc.c:(.text+0x217e): undefined reference to
    `xe_configfs_get_psmi_enabled'
  xe_guc_ads.c:(.text+0x1a28): undefined reference to
    `xe_configfs_get_enable_multi_queue'

Eleven xe_configfs_* symbols are undefined in all, referenced from
xe_module.o, xe_guc.o and xe_guc_ads.o.

Require configfs to be at least as available as xe, which is what the
stanza already does for KUNIT, INTEL_VSEC and X86_PLATFORM_DEVICES.

Reproduced on v7.3, x86_64, with:

  CONFIG_DRM_XE=y
  CONFIG_CONFIGFS_FS=m
  CONFIG_DRM=y
  CONFIG_PCI=y
  CONFIG_MODULES=y

Found with kreach, a static check that compares what Kconfig allows
against the symbols the compiled objects actually reference.

Fixes: 16280ded45fb ("drm/xe: Add configfs to enable survivability mode")
Signed-off-by: Jude Gyimah <jude.gyimah87@gmail.com>
---
The checker is at https://github.com/JGyimah/kreach, and the
reproducer configuration for each finding is published with it
under results/.

 drivers/gpu/drm/xe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 4d7dcaff2b91..fe3061f3b4ec 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -4,6 +4,7 @@ config DRM_XE
 	depends on DRM && PCI
 	depends on KUNIT || !KUNIT
 	depends on INTEL_VSEC || !INTEL_VSEC
+	depends on CONFIGFS_FS || !CONFIGFS_FS
 	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)
 	depends on PAGE_SIZE_4KB || COMPILE_TEST || BROKEN
 	select INTERVAL_TREE
-- 
2.43.0


                 reply	other threads:[~2026-11-04 13:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104134728.3723002-1-jude.gyimah87@gmail.com \
    --to=jude.gyimah87@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®