mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jude Gyimah <jude.gyimah87@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: chancel.liu@nxp.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jude Gyimah <jude.gyimah87@gmail.com>
Subject: [PATCH 1/3] ASoC: fsl_aud2htx: select missing dependencies
Date: Wed,  4 Nov 2026 14:49:58 +0100	[thread overview]
Message-ID: <20261104135000.3723017-2-jude.gyimah87@gmail.com> (raw)
In-Reply-To: <20261104135000.3723017-1-jude.gyimah87@gmail.com>

This driver is short two selects, not one: its configuration fails to
link on a symbol from each.

fsl_aud2htx calls __devm_regmap_init_mmio_clk, which
drivers/base/regmap/regmap-mmio.c provides under REGMAP_MMIO.
fsl_aud2htx calls devm_snd_dmaengine_pcm_register, which
sound/soc/soc-generic-dmaengine-pcm.c provides under
SND_SOC_GENERIC_DMAENGINE_PCM.

  fsl_aud2htx.c:(.text+0x30c): undefined reference to
    `__devm_regmap_init_mmio_clk'

The driver can be built into vmlinux while REGMAP_MMIO is a module, in
which case the symbol is not there at link time.

Select rather than depend on: REGMAP_MMIO has no prompt of its own and is
only ever enabled by a select, so a depends on would leave
SND_SOC_FSL_AUD2HTX unselectable.

Reproduced on v7.3, x86_64, with CONFIG_SND_SOC_FSL_AUD2HTX=y and
CONFIG_REGMAP_MMIO=m.

Found with kreach, a static check that compares what Kconfig allows
against the symbols the compiled objects actually reference.

Fixes: 8a24c834c053 ("ASoC: fsl_aud2htx: Add aud2htx module driver")
Signed-off-by: Jude Gyimah <jude.gyimah87@gmail.com>
---
 sound/soc/fsl/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 04940879dfd8..e8924ed652ba 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -116,6 +116,8 @@ config SND_SOC_FSL_XCVR
 config SND_SOC_FSL_AUD2HTX
 	tristate "AUDIO TO HDMI TX module support"
 	depends on ARCH_MXC || COMPILE_TEST
+	select REGMAP_MMIO
+	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n
 	help
 	  Say Y if you want to add AUDIO TO HDMI TX support for NXP.
-- 
2.43.0


  reply	other threads:[~2026-11-04 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 13:49 [PATCH 0/3] ASoC: fsl: fix missing GENERIC_BITREVERSE and REGMAP_MMIO dependencies Jude Gyimah
2026-11-04 13:49 ` Jude Gyimah [this message]
2026-11-04 13:49 ` [PATCH 2/3] ASoC: fsl: lpc3xxx-i2s: select REGMAP_MMIO Jude Gyimah
2026-11-04 13:50 ` [PATCH 3/3] ASoC: fsl_xcvr: select BITREVERSE Jude Gyimah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104135000.3723017-2-jude.gyimah87@gmail.com \
    --to=jude.gyimah87@gmail.com \
    --cc=broonie@kernel.org \
    --cc=chancel.liu@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®