From: Sasha Levin <sashal@kernel.org>
To: Tao Cui <cui.tao@linux.dev>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Yosry Ahmed" <yosry@kernel.org>, "Nhat Pham" <nphamcs@gmail.com>,
"Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>,
"Chengming Zhou" <chengming.zhou@linux.dev>,
"Shuah Khan" <shuah@kernel.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/cgroup: test_zswap: use the total RAM in bytes
Date: Wed, 4 Nov 2026 09:51:20 -0500 [thread overview]
Message-ID: <20261104145120.3806026-1-sashal@kernel.org> (raw)
In-Reply-To: <0fd8f5aa-2636-4171-9300-3e04ab98d393@linux.dev>
On Wed, Nov 04, 2026 at 09:22:31PM +0800, Tao Cui wrote:
> One small thing: could you add a Fixes tag? The issue seems to date
> back to a549f9f31561a ("selftests: cgroup: add test_zswap with no kmem
> bypass test"), which introduced the sysinfo block, and 6f615890b848
> later reshaped it into the current GB(4) comparison with the warning.
Yes, the original check against 5000000000 could never be true on
32-bit either, and it already used totalram as bytes:
Fixes: a549f9f31561 ("selftests: cgroup: add test_zswap with no kmem bypass test")
--
Thanks,
Sasha
prev parent reply other threads:[~2026-11-04 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 16:39 Sasha Levin
2026-11-04 13:22 ` Tao Cui
2026-11-04 14:51 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104145120.3806026-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=cui.tao@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=nphamcs@gmail.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®