From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.216.248.212 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793805385; b=A83Yt8vXBbT4N1NKzra/wStA8iUzmUMK1pYEAVROZ5uI7VHUEAXJ9CxZrqnPsml4tlx4 m+goriivlpDrlbHp4xn1pQSrIuQrG/A7MWFwU8uPsTIQ0/JGXsEvfOjI+mELv9shTIYEe axA+VbE63pbHLJ3puZdMy6h3tRlpWgXwB9M46M7UXdcqVN4DuW1v+FcWASRtNwPUA/uqT fdtiltOHiDAom8AjL13kzGSW/EOrNtvKTgw6w+Ai19pu33s8V6BsY5fJdHw6I4JJGPOIf 4ZRuQlELLolObd+ifijRpuMwXVpcTngcQXY/Jgpt0x27VnrtSqW9ykqNosZaF4q6vwg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793805385; h=DMARC-Filter:From:X-Lima-ML-UUID:DKIM-Signature:To:Cc:Subject:Date: Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=veOCBJc4xQGLueCe31gFSubXd0ziZWXjaL41iibTarI=; b=MaDNMQswm5RkW1FlW//P6YG3B8+36VKELUVq70iHX4OoltVikE1t8QLc8PEVeynsWnZC 6r0w1DNxeEhqGLrFhNjfM5FBy/gXnBSsp/ZXF+vCE//CZcZV1gUromEzMCVQBrlq+CCqV w41YCOt5c5j+5TxPsGVd+K5YdoVbwS+9SMKP40NQ5ROFtngt9VMxTVJqN84pbFG0LCbpX Ig3EF5ExJ3qX2XSjg81LK+GhKSMHTZK7eH8bMP7JzUSgZYgknID2hj9adDPf4MbD7Ur6I cobC8T4DG51QjWYLVHkjnvy8mMGlCbwtVIpICX8pjNlavwqnENzaZmhfNMMDewY9xng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=deq.rocks; spf=none smtp.mailfrom=deq.rocks; dkim=pass header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=RK0hgEaN; arc=none smtp.remote-ip=91.216.248.212 Received: from bulk0.mail-out.lima-city.de (bulk0.mail-out.lima-city.de [91.216.248.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98479608362C; Wed, 4 Nov 2026 15:16:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 98479608362C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=deq.rocks Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=deq.rocks Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=deq.rocks header.i=@deq.rocks header.a=rsa-sha256 header.s=securedbylima-20251205 header.b=RK0hgEaN From: Andre Eikmeyer X-Lima-ML-UUID: 903a7948-7f1a-4e14-bb37-a07f42de5f8f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=deq.rocks; s=securedbylima-20251205; t=1793805382; bh=eupOqmAAU46z8qOMqQd0xPrh++Oe1vOk26hytDYZR7o=; h=From:To:Cc:Subject:Date:From; b=RK0hgEaNXwNVNGNQna8waW9gIgTDRA1h+nifW3idUxfOgVPxYm49BP8fb2e8NomhA S6Ez9zBVKd13dyZNj8lUoM2kn42kVG5ZpOiP+Z7QyTJQ1afS3j86/3/Z/HYHSIrNq1 1iUCwXmjBzgcv4pLAJMNvGoZlbFkzxjAPiO2UI4PTfw0luMlG/XTIraFDLvO8kDZMU IG6WwwamLMd4ObJ3/QtX4MxDzleMstm8EE+x/UWeBUwPNOwo6mhZ3GOO8zbz4AZIjL Y3krHlu1lvYkhK5I7A0JeqIivFV5WtNHc2Q/FCRv0XkV3EXaeO9Ck5tfAEjdmO8si7 paJPFUIpltluA== To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Andre Eikmeyer , Yossef Osman , Aditya Garg Subject: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 Date: Wed, 4 Nov 2026 16:16:20 +0100 Message-ID: <20261104151620.70671-1-dev@deq.rocks> X-Mailer: git-send-email 2.56.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever the interface is up and not promiscuous. On the Apple firmware for the BCM4364, ndoe makes IPv6 downloads collapse. IPv6 downloads topped out at 55 Mbit/s on a MacBookPro15,1 with the BCM4364/3 and on the MacBookPro16,1 with the later revision. The BCM4377 is not affected. macOS enables ND offload for associated sleep only. A trace under macOS 26.6.1 on a MacBookPro16,2 shows nd_hostip_clear, ndoe=1 and the IPv6 addresses before sleep and ndoe cleared again on wake, see the first report below. Keep them off on the BCM4364. Closes: https://github.com/t2linux/kernel/issues/34 Closes: https://github.com/t2linux/T2-Debian-and-Ubuntu-Kernel/issues/227 Tested-by: Yossef Osman Tested-by: Aditya Garg Signed-off-by: Andre Eikmeyer --- The KaiT2en community runs this patch with its kernels, no regression was reported. .../net/wireless/broadcom/brcm80211/brcmfmac/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 92ec269f43b..6eae7135aeb 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include @@ -103,6 +104,15 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) return; } + /* With ND offload on while awake, the Apple firmware for the BCM4364 + * makes IPv6 downloads drop to low rates. macOS runs ARP and ND + * offload only in sleep, keep both off on this chip. + */ + if (enable && ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) { + brcmf_dbg(TRACE, "Skip ARP/ND offload enable on BCM4364\n"); + enable = false; + } + if (enable) mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY; else base-commit: 991a73f4909f1348ffb4b38765cdb522a775e4c2