From: Andreas Kemnade <andreas@kemnade.info>
To: dmitry.torokhov@gmail.com, andreas@kemnade.info,
bartosz.golaszewski@oss.qualcomm.com, marco.crivellari@suse.com,
arnd@arndb.de, tony@atomide.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, brgl@kernel.org
Subject: [PATCH] Input: gpio-keys - do not BUG() on requested wakeirqs
Date: Wed, 4 Nov 2026 17:03:05 +0100 [thread overview]
Message-ID: <20261104160305.2501369-1-andreas@kemnade.info> (raw)
Having the IRQ handler called when enabled IRQs arrive should be considered
as a feature not as a bug. So do not BUG() there when this happens.
Fixes: 3717194f24922 ("Input: gpio-keys - add system suspend support for dedicated wakeirqs")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/input/keyboard/gpio_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index fbc31c5db3db..f1c31c5366f0 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -412,7 +412,7 @@ static irqreturn_t gpio_keys_gpio_isr(int irq, void *dev_id)
{
struct gpio_button_data *bdata = dev_id;
- BUG_ON(irq != bdata->irq);
+ BUG_ON((irq != bdata->irq) && (irq != bdata->wakeirq));
if (bdata->button->wakeup) {
const struct gpio_keys_button *button = bdata->button;
--
2.47.3
next reply other threads:[~2026-11-04 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:03 Andreas Kemnade [this message]
2026-11-04 22:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104160305.2501369-1-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®