From: Koichiro Den <den@valinux.co.jp>
To: "Joerg Roedel (AMD)" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Magnus Damm <damm+renesas@opensource.se>,
Jason Gunthorpe <jgg@ziepe.ca>,
Lu Baolu <baolu.lu@linux.intel.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Marek Vasut <marek.vasut@mailbox.org>,
iommu@lists.linux.dev, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] iommu/ipmmu-vmsa: Propagate errors from iommu_fwspec_add_ids()
Date: Thu, 5 Nov 2026 01:22:49 +0900 [thread overview]
Message-ID: <20261104162251.1749998-2-den@valinux.co.jp> (raw)
In-Reply-To: <20261104162251.1749998-1-den@valinux.co.jp>
iommu_fwspec_add_ids() can fail while extending the ID array. Ignoring
its return value lets IOMMU setup continue with missing micro-TLB IDs.
Propagate the error so of_iommu_configure() can discard the incomplete
fwspec.
Cc: stable@vger.kernel.org
Fixes: 7b2d59611fef ("iommu/ipmmu-vmsa: Replace local utlb code with fwspec ids")
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
drivers/iommu/ipmmu-vmsa.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 9386b752dea2..99586c68ef35 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -778,10 +778,14 @@ static bool ipmmu_device_is_allowed(struct device *dev)
static int ipmmu_of_xlate(struct device *dev,
const struct of_phandle_args *spec)
{
+ int ret;
+
if (!ipmmu_device_is_allowed(dev))
return -ENODEV;
- iommu_fwspec_add_ids(dev, spec->args, 1);
+ ret = iommu_fwspec_add_ids(dev, spec->args, 1);
+ if (ret)
+ return ret;
/* Initialize once - xlate() will call multiple times */
if (to_ipmmu(dev))
--
2.54.0
next prev parent reply other threads:[~2026-11-04 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:22 [PATCH 0/3] iommu/ipmmu-vmsa: Keep shared micro-TLBs enabled Koichiro Den
2026-11-04 16:22 ` Koichiro Den [this message]
2026-11-04 16:22 ` [PATCH 2/3] iommu/ipmmu-vmsa: Move device initialization to probe_device() Koichiro Den
2026-11-04 16:22 ` [PATCH 3/3] iommu/ipmmu-vmsa: Keep shared micro-TLBs enabled while in use Koichiro Den
2026-11-04 17:42 ` Robin Murphy
2026-11-05 2:34 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104162251.1749998-2-den@valinux.co.jp \
--to=den@valinux.co.jp \
--cc=baolu.lu@linux.intel.com \
--cc=damm+renesas@opensource.se \
--cc=geert+renesas@glider.be \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut@mailbox.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®