From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=136.143.188.112 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1793814049; b=GjZOoZ1SWydbJ8JHCU/Saa+2mLu/lN2QvRpzceIAOHhxw2VtXiBI392RFoOBwCaXyDwY umTDvUJXNihhpQMuH9b5Bmfj3Ove9trWL6KyEIwhIFsMQ/yp6aLqqKLLocfhZVLaZCbJk gNA8iLWsLi8RDfnxz1lyIpncnW93jQL4CxB/gKsH2s57dhRSmHFJGStn6jDQq6dGZWxZH D4k2KSlmh606QN2JH1OzsDQaXbxQm+9ngayqKZlNzJpuyPT3NN4chqyXNp6bHLcBPTi3W 9Zb9z0VYF8dSQRmZj7Tg2hGz9mTPdkqBz8Cd74MCITtOXVuJYVOjwBmi30ncpuTVC7Q== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793814049; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-ZohoMailClient; bh=QKddt74ZqQTluxfuLkY271yIpgW5Ov4BfqlAi2z7wts=; b=xq/y9FNuaXqoQVtLUq7uhVRNr4FEH8FpFZRx9QdCnQu482zbVIkt0mFKxwphWOoFqmTU 2lJyDEidcgVpT2NQIEWR3FLNDgA5plPQ6ZrqjUpZC/R+08tvEPpyYn4vV7AVJDcy2ibCt K1sOIv0/BQJHqrqKxjSEXYQGLnjMNAm0hi5VgZjuM962pTSSh4ECf6BFhrkx+ErHBktZ8 MLg6qTV7P33t8CBooljaem2QKM7iyjM6rfBWqkce9+DiNIJTDujsFrKuJc1ahBu3KJOQo H8CWK3h+ZF4l5xQbzqyaww4MEmTjVHlUd+k3v6bSSf0mmsH7OT/CeqsdZI8uo9DPLrw== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=zohomail header.b="T/m33FHa"; arc=pass header.oldest-pass=0 smtp.remote-ip=136.143.188.112 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50E17606A923 for ; Wed, 4 Nov 2026 17:40:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 50E17606A923 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=zohomail header.b=T/m33FHa ARC-Seal: i=1; a=rsa-sha256; t=1793814032; cv=none; d=zohomail.com; s=zohoarc; b=fyLHYoTLHPy/OmgcjvtH57cttrGPYnFcqkkkMsMb2NglM0pi/lE5+PvFVGb1d9z/Tu0EsThE5tiESq/Br7PFHzMxEef754KM17Krf4kGmj66MzodQQFMw+Q7Udus/3px/vXQmROUtGA/p03rX8OTED5oqv/mx5bXMSKdfM+RejI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1793814032; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=QKddt74ZqQTluxfuLkY271yIpgW5Ov4BfqlAi2z7wts=; b=FBuccM9SoJ1oCkKiIJEZM0IbSPYCJFeXFf8MTGgmnPqMwLDcUDP3dLZQlR+dG76mxVJ8FZLchY4GtHw4vxraVGj7cPR55P5xKLwXh9D9SHgE169bXlRP78wtvLILeX8JxQ9Q7Y9nStRu01WAQMG5dT2xwQ4lI+aXHdBQtke0XgY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ashley.smith@collabora.com; dmarc=pass header.from= DKIM-Signature: a=rsa-sha256; b=T/m33FHaKqLFKrONL8rFKQYzrmoVlopvbBS18bhld2i1V+VCTJNFQJ7NZ5Jc4Ukmlv9M/97liHbiXpzR2V34xSD5jF3FpMLT83zBbI/WtWq5eEfbPKCwNgTIlonXzZwY5niReJ74PgfsA6BazegUSIvTtAEn/3zXVuM+M3oxVLY=; c=relaxed/relaxed; s=zohomail; d=collabora.com; v=1; bh=QKddt74ZqQTluxfuLkY271yIpgW5Ov4BfqlAi2z7wts=; h=Content-Description:Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Sender:Resent-Cc:Resent-Date:Resent-To:Reply-To:Resent-Message-ID:Resent-From:Sender:Subject:To:Date:From:Message-Id:Reply-To:Subject:To:Cc; Received: by smtp.zohomail.com with SMTPS id 1793814030702293.8570495916671; Wed, 4 Nov 2026 09:40:30 -0800 (PST) From: Ashley Smith To: lukas.zapolskas@arm.com Cc: airlied@gmail.com, aliceryhl@google.com, boris.brezillon@collabora.com, daniel.almeida@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, nd@arm.com, simona@ffwll.ch, steven.price@arm.com, tzimmermann@suse.de, Ashley Smith Subject: Re: [PATCH v7 5/8] drm/panthor: Introduce sampling sessions to handle userspace clients Date: Wed, 4 Nov 2026 17:39:01 +0000 Message-ID: <20261104173921.4117593-1-ashley.smith@collabora.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261011-panthor-performance-counters-v7-5-12c32495062f@arm.com> References: <20261011-panthor-performance-counters-v7-5-12c32495062f@arm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On Sun, Oct 11, 2026 at 06:36:52PM +0100, Lukas Zapolskas wrote: > + ret = panthor_perf_bo_get(file, create_args->control_handle, 0, &control); Like the ringbuffer BO above, I think we need to include the size here since if the actual size is less than what the kernel expects it could lead to writing to out of bounds memory (imported BOs): ret = panthor_perf_bo_get(file, create_args->control_handle, sizeof( struct drm_panthor_perf_ringbuf_control), &control); Could also change panthor_perf_bo_get() to always test and instead of != use <= if (obj->size <= PFN_ALIGN(expected_size)) so callers cant silently skip validation. FWIW, I have tested v7 of this patch series on a Rock5B and can see reliable counter values. Tested-by: Ashley Smith