From: Sasha Levin <sashal@kernel.org>
To: Shuah Khan <shuah@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Aleksei Oladko <aleksey.oladko@virtuozzo.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] selftests/prctl: select the tests by ARCH alone
Date: Wed, 4 Nov 2026 14:36:39 -0500 [thread overview]
Message-ID: <20261104193639.333186-1-sashal@kernel.org> (raw)
The prctl tests are only built for x86, and only when CROSS_COMPILE is
not set. In every other case the Makefile defines no rules, so building
or installing the suite fails:
make[1]: *** No targets. Stop.
TuxMake sets CROSS_COMPILE for every build, native x86_64 ones
included, so CI systems that use it, such as KernelCI, see prctl fail
on every architecture and never build its tests.
Like breakpoints, ipc and x86, decide by ARCH alone whether the tests
are built, and give the Makefile empty targets on other architectures,
as sparc64 and drivers/s390x/uvdevice do, so that the suite builds and
installs nothing there.
Fixes: 92dd8dd4d07f ("selftests: move prctl tests from Documentation/prctl")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Found with KernelCI-style TuxMake builds that record per-suite results
with KSFT_BUILD_REPORT. With this, an x86_64 build with CROSS_COMPILE
set builds and installs the five tests, arm64 and arm builds succeed
without installing anything, and the tests also compile for i386.
tools/testing/selftests/prctl/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/prctl/Makefile b/tools/testing/selftests/prctl/Makefile
index e770e86fad9ac..b230e4d955061 100644
--- a/tools/testing/selftests/prctl/Makefile
+++ b/tools/testing/selftests/prctl/Makefile
@@ -1,5 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-ifndef CROSS_COMPILE
ARCH ?= $(shell uname -m 2>/dev/null || echo not)
override ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
@@ -10,5 +9,8 @@ all: $(TEST_PROGS)
include ../lib.mk
-endif
+else
+nothing:
+.PHONY: all clean run_tests install
+.SILENT:
endif
--
2.53.0
next reply other threads:[~2026-11-04 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 19:36 Sasha Levin [this message]
2026-11-04 20:08 ` Andrew Morton
2026-11-04 22:39 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104193639.333186-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aleksey.oladko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®