From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.199 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793825996; b=L1TKUjdMrgKQVdx5nMjSNqojxTYHbHPYng/Mhr5jCv7VQJE3wGx9HcnbFBMXnrAWm+Wb sM+texGqin2Z27mAumEQfK+2xf99KpJFGNFDSh1rRpY3FDvmo81YFAcnhKeQCgSrZXkel JZRLQ4Pphaelr12k73IXvt+m2j9ArJ86Rn1csE/1OTiUOrbT1ptpNjFeP+frefVm1qyvi mg0Zy+QVqz1bWcRuSdWAZFdim88J8XeuG4QuLe8oMyFnqZH4ApK52WdOJwc0hqnOp+J+T a+GHFPmBMejgXfE9snYsncxPjltqQitsyNjLI4rYgpR3b/ZGir3VgZ55iAz6Iwa2RMw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793825996; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=s+LKsLtKc7ulezBt7HmxTKR0/xXGanuGt+VOskH+kfo=; b=F3eXP6KkhNcc8aA43wS2OBTTB8Qv2DV3wMWBu6Y0V4/I0eFuSdiojp0bp9fsNJNkpqiL 3ezd4jQv9FLpumwt11mpxun4XaKdMC0TYc8fS8TZb7JCGV467q/UMxJW3GqcljgAIrezx 0kvaZvad2bcQeuHmtmB3kxAyzHADcvhVglCKaDJwAieI7A6nPfFbOALYdAskAX5Z5koL3 FcVEsASr5CMcq8C7RADQIr5Mokfp8JeMEXZ8LWCHn97M47uW3qPRmiqfiQeeKL8qHWNR3 rGNas72GXxEI9ULdq3YDIsjBwMlVxKOCgaWmRA6d7agAlp6bBgyEabvqGaxMA54EW6Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=M50Eh4sY; arc=none smtp.remote-ip=74.125.82.199 Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D2560E7530 for ; Wed, 4 Nov 2026 20:59:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A1D2560E7530 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=M50Eh4sY Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-36a223755e4so3901480eec.0 for ; Wed, 04 Nov 2026 12:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793825995; x=1794430795; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s+LKsLtKc7ulezBt7HmxTKR0/xXGanuGt+VOskH+kfo=; b=M50Eh4sYl+3VfXyCaP384V1c3ENBlNstv1HxZDhmYi1A3GiUZq6LGAinXigr4BOI/8 rhO4a2Pf/TnJQHzQRSNYnoW9j3mU05oDnaQQZXykS/hXMVr4Pi76sz9qbmsmfZfDC87w SpKeTcET+OMcIPD/+/0fe/BlKFlqOHRmH69+7bO6VzXHMEvfx5fUnZpgjilBaU1rjPs9 1SZfFg4nUb74vCI9LiNTgK0AZyQSZCQtIbiTjgo47inMu3eLBV3rA4FbTPci8wvlw7jy CQOOq1fnQET0tCpQI01abN1gV/TE0ljvYGTg/RZrMtUniWPI8VrYqtI1Wm/3k/PCWNDc rshA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793825995; x=1794430795; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s+LKsLtKc7ulezBt7HmxTKR0/xXGanuGt+VOskH+kfo=; b=lbfui8Vh02J+VAnVRI5OkoJysSlkCzd6pEpMICh7cZ7BnrSsjxohlAu/B/5desjrnY Q0dj7qTk6We5GerL72V0eg4EXNK0PqV/hm17PxnxML0HtTYpdmbOQ4YFNp8TRcsMH0r8 6gyO+mf+ybZzIfBqyrn/L3PpzIpwPBY3jFBBFBY+B8mlsYNOH9LBjCtsy6qtSC/ioCAZ T/DxC8kv+tjJ1enn725fagOhBArYjbXHZuKcGozSl3WBTjWsvjJJbewebqvrZBZ8gNCr sFtTs6s0PatuIXVaiHNmp//Mt7qRRrsfPCQnhpUcU2+kgaSVYAQqa3bTBLcgnFLPbGST 0l7g== X-Forwarded-Encrypted: i=1; AKwUvByrkIO4/ePT02PjwECLjLQe53lo0h7x/rQP8oFCkOJhzC5OiaAl+EOqhstZbTQqQMrqXHIHXNmyux0CbXw=@vger.kernel.org X-Gm-Message-State: APuU4Z9z68xRc8PuDGEQ/jI45T2K6LSb4gFOSk5AF08iq2XKwM7/ULe7 OWYLuC+JxWcKbGSQIAl/uXNeik/IiKCL+RJkN94oaCij72vmX1dyVGSWGIvwX8Xr3+kBXWwkE6o +KlsNL+6OOQ== X-Received: from dyad26.prod.google.com ([2002:a05:693c:835a:b0:36a:de0:d28a]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:60cf:b0:36d:a465:b38e with SMTP id 5a478bee46e88-36da465c483mr1907124eec.5.1793825994640; Wed, 04 Nov 2026 12:59:54 -0800 (PST) Date: Wed, 4 Nov 2026 12:59:06 -0800 In-Reply-To: <20261104205909.2078411-1-irogers@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261104205909.2078411-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261104205909.2078411-17-irogers@google.com> Subject: [PATCH v9 16/19] perf intel-tpebs: Use DEFINE_MUTEX for tpebs_mtx From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org Cc: adrian.hunter@intel.com, bvanassche@acm.org, elver@google.com, james.clark@linaro.org, jolsa@kernel.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev, mingo@redhat.com, morbo@google.com, nathan@kernel.org, ndesaulniers@google.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" Replace tpebs_mtx_get() and its pthread_once() initialization helper tpebs_init() with DEFINE_MUTEX(tpebs_mtx) and static initializers for control_fd and ack_fd. Signed-off-by: Ian Rogers --- tools/perf/util/intel-tpebs.c | 79 ++++++++++++++--------------------- 1 file changed, 32 insertions(+), 47 deletions(-) diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c index 47c939fc2058..1812917bfb85 100644 --- a/tools/perf/util/intel-tpebs.c +++ b/tools/perf/util/intel-tpebs.c @@ -38,11 +38,11 @@ bool tpebs_recording; enum tpebs_mode tpebs_mode; +static DEFINE_MUTEX(tpebs_mtx); static LIST_HEAD(tpebs_results); static pthread_t tpebs_reader_thread; static struct child_process tpebs_cmd; -static int control_fd[2], ack_fd[2]; -static struct mutex tpebs_mtx; +static int control_fd[2] = { -1, -1 }, ack_fd[2] = { -1, -1 }; static bool tpebs_stopping; struct tpebs_retire_lat { @@ -59,23 +59,8 @@ struct tpebs_retire_lat { bool started; }; -static void tpebs_init(void) -{ - mutex_init(&tpebs_mtx); - control_fd[0] = control_fd[1] = -1; - ack_fd[0] = ack_fd[1] = -1; -} - -static struct mutex *tpebs_mtx_get(void) -{ - static pthread_once_t tpebs_once = PTHREAD_ONCE_INIT; - - pthread_once(&tpebs_once, tpebs_init); - return &tpebs_mtx; -} - static struct tpebs_retire_lat *tpebs_retire_lat__find(struct evsel *evsel) - __must_hold(tpebs_mtx_get()); + __must_hold(&tpebs_mtx); static int evsel__tpebs_start_perf_record(struct evsel *evsel) { @@ -205,19 +190,19 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused, { struct tpebs_retire_lat *t; - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); if (tpebs_cmd.pid == 0) { /* Record has terminated. */ - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return 0; } t = tpebs_retire_lat__find(sample->evsel); if (!t) { - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return -EINVAL; } if (should_ignore_sample(sample, t)) { - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return 0; } /* @@ -227,7 +212,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused, */ t->last = sample->weight3; update_stats(&t->stats, sample->weight3); - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return 0; } @@ -257,7 +242,7 @@ static void *__sample_reader(void *arg) return NULL; } -static int tpebs_send_record_cmd(const char *msg) __must_hold(tpebs_mtx_get()) +static int tpebs_send_record_cmd(const char *msg) __must_hold(&tpebs_mtx) { struct pollfd pollfd = { .events = POLLIN, }; int ret, len, retries = 0; @@ -271,7 +256,7 @@ static int tpebs_send_record_cmd(const char *msg) __must_hold(tpebs_mtx_get()) * Let go of the lock while sending/receiving as blocking can starve the * sample reading thread. */ - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); /* Send perf record command.*/ len = strlen(msg); @@ -327,14 +312,14 @@ static int tpebs_send_record_cmd(const char *msg) __must_hold(tpebs_mtx_get()) pr_err("tpebs: perf record control ack failed\n"); out: /* Re-take lock as expected by caller. */ - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); return ret; } /* * tpebs_stop - stop the sample data read thread and the perf record process. */ -static int tpebs_stop(void) __must_hold(tpebs_mtx_get()) +static int tpebs_stop(void) __must_hold(&tpebs_mtx) { int ret = 0; @@ -355,9 +340,9 @@ static int tpebs_stop(void) __must_hold(tpebs_mtx_get()) */ tpebs_cmd.pid = 0; reader_thread = tpebs_reader_thread; - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); pthread_join(reader_thread, NULL); - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); if (control_fd[0] >= 0) { close(control_fd[0]); control_fd[0] = -1; @@ -493,20 +478,20 @@ static int evsel__tpebs_prepare(struct evsel *evsel) struct evsel *pos; struct tpebs_retire_lat *tpebs_event; - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); tpebs_event = tpebs_retire_lat__find(evsel); if (tpebs_event) { /* evsel, or an identically named one, was already prepared. */ - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return 0; } tpebs_event = tpebs_retire_lat__new(evsel); if (!tpebs_event) { - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return -ENOMEM; } list_add_tail(&tpebs_event->nd, &tpebs_results); - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); /* * Eagerly prepare all other evsels on the list to try to ensure that by @@ -541,9 +526,9 @@ int evsel__tpebs_open(struct evsel *evsel) if (!tpebs_recording) return 0; - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); if (tpebs_stopping) { - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return -EBUSY; } /* Only start the events once. */ @@ -553,17 +538,17 @@ int evsel__tpebs_open(struct evsel *evsel) t = tpebs_retire_lat__find(evsel); valid = t && t->started; - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); /* May fail as the event wasn't started. */ return valid ? 0 : -EBUSY; } - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); ret = evsel__tpebs_prepare(evsel); if (ret) return ret; - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); if (tpebs_stopping || tpebs_cmd.pid != 0) { ret = -EBUSY; goto out; @@ -618,9 +603,9 @@ int evsel__tpebs_open(struct evsel *evsel) if (started_thread) { pthread_t reader_thread = tpebs_reader_thread; - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); pthread_join(reader_thread, NULL); - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); } tpebs_cmd.pid = actual_pid; finish_command(&tpebs_cmd); @@ -649,7 +634,7 @@ int evsel__tpebs_open(struct evsel *evsel) } } } - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); return ret; } @@ -669,7 +654,7 @@ int evsel__tpebs_read(struct evsel *evsel, int cpu_map_idx, int thread) count = perf_counts(evsel->counts, cpu_map_idx, thread); - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); t = tpebs_retire_lat__find(evsel); /* * If reading the first tpebs result, send a ping to the record @@ -678,10 +663,10 @@ int evsel__tpebs_read(struct evsel *evsel, int cpu_map_idx, int thread) */ if (t && &t->nd == tpebs_results.next) { ret = tpebs_send_record_cmd(EVLIST_CTL_CMD_PING_TAG); - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); if (ret) return ret; - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); } if (t == NULL || t->stats.n == 0) { /* No sample data, use default. */ @@ -720,7 +705,7 @@ int evsel__tpebs_read(struct evsel *evsel, int cpu_map_idx, int thread) break; } } - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); if (old_count) { count->val = old_count->val + val; @@ -745,7 +730,7 @@ void evsel__tpebs_close(struct evsel *evsel) { struct tpebs_retire_lat *t; - mutex_lock(tpebs_mtx_get()); + mutex_lock(&tpebs_mtx); t = tpebs_retire_lat__find(evsel); if (t) { list_del_init(&t->nd); @@ -754,5 +739,5 @@ void evsel__tpebs_close(struct evsel *evsel) if (list_empty(&tpebs_results)) tpebs_stop(); } - mutex_unlock(tpebs_mtx_get()); + mutex_unlock(&tpebs_mtx); } -- 2.56.0.455.g6c5a503b38-goog