From: Rosen Penev <rosenp@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/5] gpio: ppc44x: drop redundant label and parent assignments
Date: Wed, 4 Nov 2026 13:59:55 -0800 [thread overview]
Message-ID: <20261104215959.24035-2-rosenp@gmail.com> (raw)
In-Reply-To: <20261104215959.24035-1-rosenp@gmail.com>
gpio_generic_chip_init() already sets gc->parent to the device and
gc->label to dev_name() of it. Drop the duplicate assignments from
probe.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpio/gpio-ppc44x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-ppc44x.c b/drivers/gpio/gpio-ppc44x.c
index 189667e0e1ba..01dd5e7cc311 100644
--- a/drivers/gpio/gpio-ppc44x.c
+++ b/drivers/gpio/gpio-ppc44x.c
@@ -178,8 +178,6 @@ static int ppc44x_gpio_probe(struct platform_device *ofdev)
return ret;
gc = &chip->chip.gc;
- gc->label = dev_name(dev);
- gc->parent = dev;
gc->direction_input = ppc44x_gpio_dir_in;
gc->direction_output = ppc44x_gpio_dir_out;
--
2.56.0
next prev parent reply other threads:[~2026-11-04 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 21:59 [PATCH 0/5] gpio: ppc44x: assorted cleanups Rosen Penev
2026-11-04 21:59 ` Rosen Penev [this message]
2026-11-04 21:59 ` [PATCH 2/5] gpio: ppc44x: factor out the OSR/TSR source selection Rosen Penev
2026-11-04 21:59 ` [PATCH 3/5] gpio: ppc44x: fold __ppc44x_gpio_set() into ppc44x_gpio_dir_out() Rosen Penev
2026-11-04 21:59 ` [PATCH 4/5] gpio: ppc44x: use BIT() and GENMASK() for the pin masks Rosen Penev
2026-11-04 21:59 ` [PATCH 5/5] gpio: ppc44x: tidy up includes and probe Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104215959.24035-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®