From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793829674; b=ixEfm4Xha8WMJ020ake8K0rUbPjMCy+TJI87L3yRQTVtyWT4FYmrIVggGKbhVghd3nqM CNhm3VJiEeSKIOuj0Q3uBHJ4ASVLlpzzWwS+yZh/xRKz1PlA4U6/gCdpjqDkjo3K+2BGf ZB3plYvnQHGlBTRK1Ye/exq3Ry7zFejZAfUTmvHQJNYAYcRdFTi0CabEvgpBhPxQP81of zflKAeFmz4AgrzD62nPJaksxZQCr7xT6AVQp9svJWuwjDsirDwlLZbC3WATsAWFKq6QKy Z1o69giknwBKxNU3N42JbRzvmGuCvsAeOWpSbjT/gRV7Rdk83ikWzZG+zfee47D9zbA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793829674; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:From:To:Cc:Subject:Date: Message-ID:MIME-Version:Content-Transfer-Encoding:X-Scanned-By; bh=w9CdwPErUt55SviF3rKSmqb1tl8IBDbw/57AfeFpaXU=; b=clKGRkkRBX1L/RkrJFbWcY7ZgnQWcvnwnqE5ffM0SrwHokST/wEMujiqJhlxfyc1PpP4 +uHKP43wIGn9FmA+VGvA6mtjtT+NU88t4z1CPyocVcstjpcC2IuA8En0iujZcquc5w2uw JT1EVJMxPLCDUgiuTDZ7r83wq3flQrTYhG5Q2MFowrYd9XEo1MWh1eYGsKTSJyBgXVSk3 QcTwgMn/aF0qhMUd6BQO2qAGt5jMfTfgBk91UFKPJKa+ZKmys5LK3GgIWYGrdtWsdRdbK B7e1xMFkkS5LIjjtUoLzWZP+wNU2vQ7TpuViRa2RvpwqFBGKjzsg+4Mje1rpr2Gu87w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZdxJm6fq; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E1F606C58E for ; Wed, 4 Nov 2026 22:01:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E7E1F606C58E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZdxJm6fq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793829672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=w9CdwPErUt55SviF3rKSmqb1tl8IBDbw/57AfeFpaXU=; b=ZdxJm6fqgqKzi6kjy9PCgLpJWGcDjjLIBp1IwdsKtemOG3IZ9SYsnvYzK6N6clzaj1RSL6 s0nz7qrPbWQCrJURjUSWL2beBy2IPeZLw+7ySpeyihARKbHsx388oj33lTUqd8dmBtXRC8 G5G0S7NOLAtywAQZbxspQ+sHrQ09HrE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-nPOl_08aPTO2CdaX177x4A-1; Wed, 04 Nov 2026 17:01:07 -0500 X-MC-Unique: nPOl_08aPTO2CdaX177x4A-1 X-Mimecast-MFC-AGG-ID: nPOl_08aPTO2CdaX177x4A_1793829665 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5F6A81955F1B; Wed, 4 Nov 2026 22:01:05 +0000 (UTC) Received: from poros-thinkpadp16vgen1.tpbc.com (unknown [10.44.32.42]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 76C9B195604C; Wed, 4 Nov 2026 22:01:00 +0000 (UTC) From: Petr Oros To: netdev@vger.kernel.org Cc: Petr Oros , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Swiatkowski , Simon Horman , Larysa Zaremba , Mateusz Pacuszka , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH iwl-net] ice: do not classify EAPOL MAC address as LLDP Date: Wed, 4 Nov 2026 23:00:42 +0100 Message-ID: <20261104220042.1421735-1-poros@redhat.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 01:80:c2:00:00:03 (Nearest Non-TPMR Bridge) is also the 802.1X PAE group address used by EAPOL, and the virtchnl MAC filter API carries no ethertype to tell the two apart. ice_vc_can_add_mac() therefore rejects it on untrusted VFs, which fails the whole ADD_ETH_ADDR request and breaks 802.1X authentication: [ 128.447213] ice 0000:17:00.2: An untrusted VF 0 is attempting to configure an LLDP multicast address [ 128.447301] iavf 0000:17:11.0: Failed to add MAC filter, error IAVF_ERR_ADMIN_QUEUE_ERROR Drop 0x03 from ice_is_mc_lldp_eth_addr() and treat it as a regular multicast MAC. Trusted VFs still get the ETH_P_LLDP forwarding rule through the other two LLDP addresses and the rule does not match on the destination MAC anyway. Fixes: 2296345416b0 ("ice: receive LLDP on trusted VFs") Signed-off-by: Petr Oros --- drivers/net/ethernet/intel/ice/virt/virtchnl.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/virt/virtchnl.c b/drivers/net/ethernet/intel/ice/virt/virtchnl.c index ca8018e3dd4288..27f0e1dee24642 100644 --- a/drivers/net/ethernet/intel/ice/virt/virtchnl.c +++ b/drivers/net/ethernet/intel/ice/virt/virtchnl.c @@ -744,8 +744,9 @@ ice_vfhw_mac_add(struct ice_vf *vf, struct virtchnl_ether_addr *vc_ether_addr) * ice_is_mc_lldp_eth_addr - check if the given MAC is a multicast LLDP address * @mac: address to check * - * Return: true if the address is one of the three possible LLDP multicast - * addresses, false otherwise. + * Return: true if the address is one of the LLDP multicast addresses + * handled by this driver (Nearest Bridge or Nearest Customer Bridge), + * false otherwise. */ static bool ice_is_mc_lldp_eth_addr(const u8 *mac) { @@ -754,7 +755,7 @@ static bool ice_is_mc_lldp_eth_addr(const u8 *mac) if (memcmp(mac, lldp_mac_base, sizeof(lldp_mac_base))) return false; - return (mac[5] == 0x0e || mac[5] == 0x03 || mac[5] == 0x00); + return (mac[5] == 0x0e || mac[5] == 0x00); } /** -- 2.56.0