From: "Orkun Emin Sarı via B4 Relay" <devnull+sariorkunemin.gmail.com@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
"Orkun Emin Sarı" <sariorkunemin@gmail.com>
Subject: [PATCH] fuse: don't pass a NULL inode to fuse_inode_backing() on release
Date: Thu, 05 Nov 2026 16:23:41 +0300 [thread overview]
Message-ID: <20261105-fuse-cuse-release-v1-1-8be1eec02c66@gmail.com> (raw)
From: Orkun Emin Sarı <sariorkunemin@gmail.com>
cuse_release() and the error path of fuse_create_open() call
fuse_prepare_release() with a NULL fuse_inode. Since commit bbe2d73a8231
("fuse: don't assume ff->passthrough is set for FOPEN_PASSTHROUGH"),
fuse_prepare_release() calls fuse_inode_backing(fi) whenever the open
reply had FOPEN_PASSTHROUGH set, not only when ff->passthrough was set
up. A CUSE server that sets FOPEN_PASSTHROUGH thus makes the kernel
dereference a NULL pointer when the device is closed.
Pass a NULL backing when there is no inode. fuse_passthrough_release()
only prints it.
Found with AI-assisted code review (Claude Code).
Fixes: bbe2d73a8231 ("fuse: don't assume ff->passthrough is set for FOPEN_PASSTHROUGH")
Signed-off-by: Orkun Emin Sarı <sariorkunemin@gmail.com>
---
No reproducer was run and the fix is not runtime-tested. Build-tested
with LLVM=1 W=1 and FUSE_FS, CUSE and FUSE_PASSTHROUGH enabled.
---
fs/fuse/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index d5e1cb53d8..36144fdd69 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -320,7 +320,7 @@ static void fuse_prepare_release(struct fuse_inode *fi, struct fuse_file *ff,
struct fuse_release_args *ra = &ff->args->release_args;
if (fuse_is_passthrough(ff))
- fuse_passthrough_release(ff, fuse_inode_backing(fi));
+ fuse_passthrough_release(ff, fi ? fuse_inode_backing(fi) : NULL);
/* Inode is NULL on error path of fuse_create_open() */
if (likely(fi)) {
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261105-fuse-cuse-release-db795aa69e2c
Best regards,
--
Orkun Emin Sarı <sariorkunemin@gmail.com>
next reply other threads:[~2026-11-05 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 13:23 Orkun Emin Sarı via B4 Relay [this message]
2026-11-05 15:20 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105-fuse-cuse-release-v1-1-8be1eec02c66@gmail.com \
--to=devnull+sariorkunemin.gmail.com@kernel.org \
--cc=fuse-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sariorkunemin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®