From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793893768; b=DJh7LLZBBow8rK1YVKdoQv6XMJmWIfTrMvC1ciEYNefLUunLMmG68WHE8+Q9RPI/E1W8 kCMdNq1cQbH24/JpXNNzilSwm/6GDPI2An/cjpbRKZGYev69wITUIWnXQPAuNXBOtkohb 82o3swLm4M1InLR9+50PCJOwkw2o3C8ur9XAqky7t4b70avqEpiGOKaM3LqGSRT1XqaWe TMydIqhze3muypGxTGa1vfZMVJrcJqNb4WEmoCkQK1ocio1sLjRgprBpnyogaNWUlAkQ2 cHyb8br3riha9TsX3zY7nPJSecgoZVG4htGpWQyhB2AdGZ9xRvfm6Sf4OC2ZqcmM8eQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793893768; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=z9ZWX1AR/I3jOL5o9kBh6YYdTWJixzoBFDFa25TELPs=; b=zB8sHrHYr3i9/USuiXOXRBw2QsLehj9A5dvVyeDLURLZyjtvj2LRRVmUAB/as3bc+qj0 W/0hxiSGhyafUoZplrYbR+/60HoyV6+PnI7k2HAwi5P26ZQoXE1bnv1LyQacHiZjV8x9l 7rVjf29/fIBxOd0pwP8jF6utB6hp0Mio0Ugb2sH1w645esoK5IZdf0N3YtQJIqMFPMNdr nb55AwhK6WpN7bh6UJHxUEi+8vDruGPJ1JXy5UGyCnXOfy2D4pywbzf9lZHLCQDL2oB/h JomOlBP0DqGZGOh9dMe+dYS+WIc9kfCAAQZYSOtr+umLxFAjpDbRDii8Y0A34aUwCkw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=xiJvYG26; arc=none smtp.remote-ip=209.85.128.41 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF39760A380C for ; Thu, 5 Nov 2026 15:49:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EF39760A380C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=xiJvYG26 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4a2167bd087so18270995e9.3 for ; Thu, 05 Nov 2026 07:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1793893766; x=1794498566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z9ZWX1AR/I3jOL5o9kBh6YYdTWJixzoBFDFa25TELPs=; b=xiJvYG26Gk6GQsqAPvh+SQWZFIGO/rHqmstYmlfElJ9iVS5GyH5Ked1Kr9zramjBV6 aYOxhOzqz1BT7VQRgIxXNrv7LRsTON+oBTDO6HplcKDrUhWSm3ME1iIRDHhywlxjDJje 3kIPhYntJIdqOzVyAavYTSG1+dkjPmvFn1D/a4B++LYr38pzPLFgKpgLQ6e0/BRszpLE vxSgOuP2OLg0EoMeX1/Mlq6QA6wxrJLenD7IU6mQn6lbV4+asp8Rne2AoURo04fW1Zd5 e5aigVDEZpglDNRo2tHq8WYGXS76OEfV7W7PLM0lSO6gJtlulFu8wHX1KjmfhqJ5gfYe jGAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793893766; x=1794498566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z9ZWX1AR/I3jOL5o9kBh6YYdTWJixzoBFDFa25TELPs=; b=2laSY8S56GVuX2gbii4MgkTTUCd5Og5Zo49uYdpwYey+DJ0LUXmRHENLr2GQDb411Z ILrW8fi9iksGquDWEnumWWAAPviODJzMHMB5Wtm8WQdV3otP8v+QpjyYtkivUGF1nU3H 4Dh1/SWI6w2Ljwvp1fWaoGwgz1H66UdJun3mfy5GeM6M0PTgOYB3+xX807AMDY1jiOtp yuFz/PCF9vwrDCGisAabD3mwrKDMm+ozHyc5yAq65J84ublEH2xZjZXD+MDMzE8vMTCL Sn+iki4qCnWIL7FKIKTyFVqwmek/IdloF9kPvIgSaxbgWgjHpcZWW8kgjLbR396mUU97 ls1w== X-Forwarded-Encrypted: i=1; AKwUvBwCLQYoPjTCPTnNzWrW2YnpFAGEDvCP+/gK1nqf5Y3rEeX+1bB2xOS5g3hBX9o4WiTCz9PU8KheFOrc38E=@vger.kernel.org X-Gm-Message-State: APuU4Z92XItxvGfxX3oTjyqgjp3Z0yxzIY6icfPjCC/giEuoWFy0zY6D EWNGmVZa6zJr+jInCITqDBR84b3wveSvlYI/fECgpsM+rTIAsOYdyo40dheP6ulzcSI= X-Gm-Gg: AYBFou094afaH4hRUdUvP7ziHSQyavK9XYVfAvSXRf324R0ecsKex8IkiCRPnUSpksr g/yKm+L0XKAdagumwdavHKcZRHTTHNURUuSJDvJVQGfF371wwGKUatSv5MNhwccv16n2dEoyzbu uaJcTX66C199wI9g3uid9aNKJEZ8v5LLtTjOLtDRQG6ybG7CZP89Bz+zGzcK8g+tkjE0ly3zb/E yk94grkdFcsUfocWR0bRatlmwbZpSml/OGVjM3Zs5qh/VgYvwErV6QE2+gzeot8e/oKSpcD4SOo ftGxzU6U9KkgNjaLUpGMGSRacmSYscwkMBLnYnCjwXxt3MYGjubuRTjwT78yfPMdv3uPaX1N1rF lL/b1yjkRVD3ffSuYi0S7FKUiClkaxRNb0/sGhD0i9f3B4BsIMttlhQRivKaIsC3Ai4f0RvhEig B2AzzMbB9j4XSp0TKtm8MgMZF52e0yG7hh7i0movJeH908gpxP3i8p4Izyj0qYOwxxFHVgNz8Ke Gmvc5woI/mo4y2MZWP08aJ58Fkmz4IT/tgIXlaH1o2OcZDX5+08k55Vy3vsPFdzc3d/ltgYkzoT PtdZMa/ORdyjqFEaHgUYSyeX3D8RZTfr X-Received: by 2002:a05:600c:c16a:b0:4a1:fbd2:f689 with SMTP id 5b1f17b1804b1-4ac16fa352emr435548945e9.7.1793893766216; Thu, 05 Nov 2026 07:49:26 -0800 (PST) Received: from pop-os.local ([37.18.141.193]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48fec9cd40csm10650462f8f.13.2026.11.05.07.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 07:49:25 -0800 (PST) From: James Clark Date: Thu, 05 Nov 2026 15:49:05 +0000 Subject: [PATCH 3/4] perf test probe_vfs_getname: Fix missing debuginfo detection X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261105-james-perf-test-fixes-v1-3-0b279bee5830@linaro.org> References: <20261105-james-perf-test-fixes-v1-0-0b279bee5830@linaro.org> In-Reply-To: <20261105-james-perf-test-fixes-v1-0-0b279bee5830@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Jakub Brnak , Leo Yan Cc: Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.15.2 skip_if_no_debuginfo() looks for the errors that 'perf probe' prints when there is no debuginfo in the output of add_probe_vfs_getname(). But since commit 92b664dcefab ("perf test probe_vfs_getname: Skip if no suitable line detected"), add_probe_vfs_getname() returns early without adding a probe if 'perf probe -L' doesn't find the line, which is also what happens when there is no debuginfo. The error from 'perf probe -L' is discarded, so the debuginfo errors are never found. This causes the debuginfo dependent subtests of the "perftool-testsuite_probe" test to fail instead of being skipped on kernels without debuginfo, because test_adding_kernel.sh calls skip_if_no_debuginfo() unconditionally. The other users only call it when add_probe_vfs_getname() returns 1, so they aren't affected. Fix it by doing a dry run of a probe that needs debuginfo instead. This works without libdw too, where 'perf probe -L' isn't available, and also avoids adding a real probe just to check for debuginfo. This fixes the "perftool-testsuite_probe" test: $ sudo perf test -vvv "perftool-testsuite_probe" ... -- [ FAIL ] -- perf_probe :: test_adding_kernel :: listing added probe :: perf probe -l (output regexp parsing) ... -- [ FAIL ] -- perf_probe :: test_adding_kernel :: wildcard adding support (command exitcode + output regexp parsing) ... -- [ FAIL ] -- perf_probe :: test_adding_kernel :: non-existing variable (output regexp parsing) ... ## [ FAIL ] ## perf_probe :: test_adding_kernel SUMMARY :: 3 failures found ... 189: perftool-testsuite_probe : FAILED! Fixes: 92b664dcefab ("perf test probe_vfs_getname: Skip if no suitable line detected") Signed-off-by: James Clark --- tools/perf/tests/shell/lib/probe_vfs_getname.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh index 57a59ae7d4ae..1c3af5771bcf 100644 --- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh +++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh @@ -64,7 +64,8 @@ add_probe_vfs_getname() { } skip_if_no_debuginfo() { - add_probe_vfs_getname -v 2>&1 | grep -E -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)|(file has no debug information)" && return 2 + # Dry run a probe that needs debuginfo. + perf probe -n -v 'getname_flags $params' 2>&1 | grep -E -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)|(file has no debug information)" && return 2 return 1 } -- 2.43.0