From: Amit Patole <amit.patole@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,
Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Patole <amit.patole@gmail.com>
Subject: [PATCH] jbd2: document the h_invalid handle flag
Date: Thu, 05 Nov 2026 09:00:36 -0500 [thread overview]
Message-ID: <20261105-kdoc-jbd2-h_invalid-v1-1-4bc224f7d0a2@gmail.com> (raw)
Commit 61e2a90a910c ("ext4: enable scoped NOFS when starting a handle
in nojournal mode") added the h_invalid bit to struct
jbd2_journal_handle but did not add it to the kernel-doc comment above
the structure, so kernel-doc now warns:
include/linux/jbd2.h:523 struct member 'h_invalid' not described in
'jbd2_journal_handle'
Describe the new flag. It is set by ext4_get_nojournal() on a handle
that is not attached to any journal and is tested by
ext4_handle_valid().
The warning was found by running scripts/kernel-doc over the headers
pulled into the htmldocs build. An AI coding assistant (Claude Opus
5.5) was used to locate the warning and draft this change; it was
verified with scripts/kernel-doc (no warnings left) and checkpatch.
Fixes: 61e2a90a910c ("ext4: enable scoped NOFS when starting a handle in nojournal mode")
Signed-off-by: Amit Patole <amit.patole@gmail.com>
---
Comment-only change. Built with W=1 on x86_64 (fs/jbd2/, fs/ext4/)
with no new warnings.
---
include/linux/jbd2.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index e3886963ba00..69f12366a09a 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -482,6 +482,7 @@ struct jbd2_revoke_table_s;
* @h_sync: Flag for sync-on-close.
* @h_reserved: Flag for handle for reserved credits.
* @h_aborted: Flag indicating fatal error on handle.
+ * @h_invalid: Flag for a handle not attached to a journal (ext4 nojournal mode).
* @h_type: For handle statistics.
* @h_line_no: For handle statistics.
* @h_start_jiffies: Handle Start time.
---
base-commit: 05441d697f7f9a927264f4058cbbc6a03dfcac9d
change-id: 20261105-kdoc-jbd2-h_invalid-8297dd06f190
Best regards,
--
Amit Patole <amit.patole@gmail.com>
next reply other threads:[~2026-11-05 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:00 Amit Patole [this message]
2026-11-05 19:11 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105-kdoc-jbd2-h_invalid-v1-1-4bc224f7d0a2@gmail.com \
--to=amit.patole@gmail.com \
--cc=adilger@dilger.ca \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®