From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793868254; b=cJ8nw5MQsZSyNpb2hH947MPi9zFelQxjc1t9Y3Hvlnjv+8bfMD70UYX+TaQ2zWosNSts twCsSNz7DaQgmqzgV3CLmhEwsFE43KItCAJMkNyQcu3K8XkP7BfUbDAW47y1wO8SoFzXM EBVdhNFBgLBeFH2fQ+XvaxiL3vyLIvnx3yipHg/wDN6xj6e7dPbfgj7QWRRNY1R6DNslL zQ7RI/RH+VxioQFHYvUrzYdsAw6vTbJe+UHkT2Bt4QdPZUDKZfDMfEy7sc2qU/7Xtvf+e oDml/aKo4Xr23uUf/WbXf1EwdAF4KiDZsswt5D4jPvWAqkI48cteXVwSW/OZlcCeYEA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793868254; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer; bh=QcwWyu992adRNRov8at/qT9yIPityd08l/5rPv4jP5c=; b=Ok7SL5P1TUcbVqBZ7m1n5pST+LFkLSFt84bDl7cH5yMOVNYTA4e6QqTaZEEyhk55G3bD qRc1+xDO15vy043KgkfYh4L+nbpQai1L39z7JYoHCMKeHtxSQu+UWeICxx8QnPUcuXudC Sk7T8tVEB3zVotsSHYOASYv8+zmtmPD52oiPeiXtLdqcwqGgN66GHWRQA4PS0nc04riy9 XvzbON9TaztZlYXmz6TCoHnqgmJpso3dl9j5eFfLlRNtXpfOCNsjuWcKiYOhlAEK+XhID nZkOHXi2/0Vk4E89Q8yfl+RNRdDNB68KneKbueWhFTviGrR8Op5hidAjczazRILXCBw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SyJ9C7b1; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25982606A326 for ; Thu, 5 Nov 2026 08:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=SyJ9C7b1 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF8EB1F00919; Thu, 5 Nov 2026 08:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793868254; bh=QcwWyu992adRNRov8at/qT9yIPityd08l/5rPv4jP5c=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=SyJ9C7b1l3U73nQZClRGK9zBmL1sF5CWoGhfFhSSl+lKyRetzKE1PW29I66jfia99 5d/dp7f/9g72dI5q3lOooXb+PUZTfDQEo25fPrQGjMYSJtHbE5zV0Uf6MkXb48MdLV cCO6P23MJrokKAe98Dyy1CH1OZjL6Uiym3qojlUFBv4ZK9R989pQA8fMzo1JTWTeip SG58nRI+GlbiEJuGe1ClxZGWmAEmI+i8baDgzX0qTt2CtRVvyPWNki5YBqPHxrfX/f hY5fgBJd78NHNKdYEHf2Gv+kbAjNyrhlQe9Fuc3wRjT8IlvrA6PcKkkE6a4MOcLcoU 51IRH/1bskBxQ== From: "Vlastimil Babka (SUSE)" Date: Thu, 05 Nov 2026 09:43:54 +0100 Subject: [PATCH v3 05/10] mm, slab: rework KMALLOC_RECLAIM handling of SLUB_TINY X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261105-slub_tiny_rework-v3-5-0484ce59eabb@kernel.org> References: <20261105-slub_tiny_rework-v3-0-0484ce59eabb@kernel.org> In-Reply-To: <20261105-slub_tiny_rework-v3-0-0484ce59eabb@kernel.org> To: Harry Yoo , Andrey Ryabinin Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Geert Uytterhoeven , Conor Dooley , Damien Le Moal , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "Vlastimil Babka (SUSE)" X-Mailer: b4 0.16.0 One (relatively minor) aspect of CONFIG_SLUB_TINY is the assumption that letting reclaimable and non-reclaimable caches merge will save more memory, which is more important on small systems than the page allocator level fragmentation (where distinguishing reclaimable slabs should help). For now that has been achieved by #ifdefs that result in making the SLAB_RECLAIM_ACCOUNT no-op and aliasing KMALLOC_RECLAIM to KMALLOC_NORMAL on the enum values level. With the goal of converting CONFIG_SLUB_TINY to a boot-time decision, rework this so that SLAB_RECLAIM_ACCOUNT and KMALLOC_RECLAIM are distinctly defined always. Now, creation of kmalloc-rcl caches is avoided by assigning a pointer to the normal kmalloc cache on the kmalloc_caches array level. To prepare disconnecting of this boot-time decision (and the evaluation of the need for kmalloc_no_objext) from CONFIG_SLUB_TINY, introduce a slub_tiny_enabled variable that's initialized to the CONFIG_SLUB_TINY state. There is one minor functional change for CONFIG_SLUB_TINY=y. Since SLAB_RECLAIM_ACCOUNT is not 0 anymore, caches that differ only in that flag will stop being mergeable. If that turns out to have a noticeable impact on memory footprint, we can adjust the merging decisions to ignore SLAB_RECLAIM_ACCOUNT when slub_tiny_enabled is true. Signed-off-by: Vlastimil Babka (SUSE) --- include/linux/slab.h | 10 ---------- mm/slab.h | 5 +++-- mm/slab_common.c | 12 ++++++------ mm/slub.c | 2 ++ 4 files changed, 11 insertions(+), 18 deletions(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index ed949e8522be..930dd64b9ad6 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -55,9 +55,7 @@ enum _slab_flag_bits { #ifdef CONFIG_KFENCE _SLAB_SKIP_KFENCE, #endif -#ifndef CONFIG_SLUB_TINY _SLAB_RECLAIM_ACCOUNT, -#endif _SLAB_OBJECT_POISON, _SLAB_CMPXCHG_DOUBLE, #ifdef CONFIG_SLAB_OBJ_EXT @@ -241,11 +239,7 @@ enum _slab_flag_bits { * pages are allocated with __GFP_RECLAIMABLE, which affects grouping pages by * mobility, and are accounted in SReclaimable counter in /proc/meminfo */ -#ifndef CONFIG_SLUB_TINY #define SLAB_RECLAIM_ACCOUNT __SLAB_FLAG_BIT(_SLAB_RECLAIM_ACCOUNT) -#else -#define SLAB_RECLAIM_ACCOUNT __SLAB_FLAG_UNUSED -#endif #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ /* Slab caches without obj_exts array */ @@ -724,11 +718,7 @@ enum kmalloc_cache_type { #endif KMALLOC_PARTITION_START = KMALLOC_NORMAL, KMALLOC_PARTITION_END = KMALLOC_PARTITION_START + KMALLOC_PARTITION_CACHES_NR, -#ifdef CONFIG_SLUB_TINY - KMALLOC_RECLAIM = KMALLOC_NORMAL, -#else KMALLOC_RECLAIM, -#endif #ifdef CONFIG_ZONE_DMA KMALLOC_DMA, #endif diff --git a/mm/slab.h b/mm/slab.h index 79774e2be3bb..835d977634ec 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -396,6 +396,8 @@ extern const struct kmalloc_info_struct { unsigned int size; } kmalloc_info[]; +extern bool slab_tiny_enabled; + /* Kmalloc array related functions */ void setup_kmalloc_cache_index_table(void); void create_kmalloc_caches(void); @@ -576,8 +578,7 @@ static inline bool need_kmalloc_no_objext(void) if (!mem_alloc_profiling_permanently_disabled()) return true; - if (!mem_cgroup_kmem_disabled() && - (KMALLOC_NORMAL == KMALLOC_RECLAIM)) + if (!mem_cgroup_kmem_disabled() && slab_tiny_enabled) return true; return false; diff --git a/mm/slab_common.c b/mm/slab_common.c index 6036ce1ac333..b7a4e32c7a11 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -836,11 +836,7 @@ EXPORT_SYMBOL(kmalloc_size_roundup); #define KMALLOC_CGROUP_NAME(sz) #endif -#ifndef CONFIG_SLUB_TINY #define KMALLOC_RCL_NAME(sz) .name[KMALLOC_RECLAIM] = "kmalloc-rcl-" #sz, -#else -#define KMALLOC_RCL_NAME(sz) -#endif #ifdef CONFIG_KMALLOC_PARTITION_CACHES #define __KMALLOC_PARTITION_CONCAT(a, b) a ## b @@ -977,7 +973,11 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type) unsigned int aligned_size = kmalloc_info[idx].size; int aligned_idx = idx; - if ((KMALLOC_RECLAIM != KMALLOC_NORMAL) && (type == KMALLOC_RECLAIM)) { + if (type == KMALLOC_RECLAIM) { + if (slab_tiny_enabled) { + kmalloc_caches[type][idx] = kmalloc_caches[KMALLOC_NORMAL][idx]; + return; + } flags |= SLAB_RECLAIM_ACCOUNT; } else if (IS_ENABLED(CONFIG_MEMCG) && (type == KMALLOC_CGROUP)) { if (mem_cgroup_kmem_disabled()) { @@ -1010,7 +1010,7 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type) * KMALLOC_NO_OBJ_EXT cache. */ if (!mem_cgroup_kmem_disabled()) { - if (type == KMALLOC_NORMAL && KMALLOC_RECLAIM != KMALLOC_NORMAL) + if (type == KMALLOC_NORMAL && !slab_tiny_enabled) flags |= SLAB_NO_MERGE; else if (!(flags & SLAB_NO_OBJ_EXT)) flags |= SLAB_MAY_ACCOUNT; diff --git a/mm/slub.c b/mm/slub.c index 51daf361c601..a3ee1bdf0eb3 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -219,6 +219,8 @@ DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT, slab_obj_ext_has_codetag_key); #endif +bool slab_tiny_enabled __read_mostly = IS_ENABLED(CONFIG_SLUB_TINY); + /* Structure holding extra parameters for slab allocations */ struct slab_alloc_context { unsigned long caller_addr; -- 2.56.0