mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
	 Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	 Linus Walleij <linusw@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-acpi@vger.kernel.org,
	Mario Limonciello <superm1@kernel.org>
Subject: [PATCH] pinctrl: amd: Drop CONFIG_ACPI ifdef
Date: Thu, 05 Nov 2026 12:03:36 -0600	[thread overview]
Message-ID: <20261105-superm1-pinctrl-acpi-v1-1-2367e584912f@kernel.org> (raw)

commit e7280ab196ba4 ("ACPI: bus: Use acpi/acpi_bus.h without
CONFIG_ACPI") added a stub that means that we don't need a #ifdef
anymore for the _AEI check

Signed-off-by: Mario Limonciello <superm1@kernel.org>
---
 drivers/pinctrl/pinctrl-amd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 9fa752f552d43..efe8859fcd5a9 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -955,14 +955,12 @@ static void amd_gpio_irq_init(struct amd_gpio *gpio_dev)
 
 	mask = BIT(WAKE_CNTRL_OFF_S0I3) | BIT(WAKE_CNTRL_OFF_S3);
 
-#ifdef CONFIG_ACPI
 	/*
 	 * Platforms without _AEI leave GPIO wake sources to firmware, so
 	 * preserve their S4 wake bits.
 	 */
 	if (acpi_has_method(ACPI_HANDLE(&gpio_dev->pdev->dev), "_AEI"))
 		mask |= BIT(WAKE_CNTRL_OFF_S4);
-#endif
 
 	for (i = 0; i < desc->npins; i++) {
 		int pin = desc->pins[i].number;

---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261101-superm1-pinctrl-acpi-faeed4581e60

Best regards,
--  
Mario Limonciello <superm1@kernel.org>


             reply	other threads:[~2026-11-05 18:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 18:03 Mario Limonciello [this message]
2026-11-06 13:32 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105-superm1-pinctrl-acpi-v1-1-2367e584912f@kernel.org \
    --to=superm1@kernel.org \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®