From: Lisa Wang <wyihan@google.com>
To: Andrew Jones <ajones@ventanamicro.com>,
Ackerley Tng <ackerleytng@google.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Chao Gao <chao.gao@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Ira Weiny <iweiny@kernel.org>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Kiryl Shutsemau <kas@kernel.org>,
linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
"Pratik R. Sampat" <pratikrajesh.sampat@amd.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Roger Wang <runanwang@google.com>,
Ryan Afranji <afranji@google.com>,
Sagi Shahar <sagis@google.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>, Xiaoyao Li <xiaoyao.li@intel.com>,
Oliver Upton <oupton@kernel.org>
Cc: Jeremiah McReynolds <jmcrey@google.com>,
kvm@vger.kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, x86@kernel.org,
Lisa Wang <wyihan@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ira Weiny <iweiny@kernel.org>
Subject: [PATCH v16 00/20] TDX KVM selftests
Date: Thu, 05 Nov 2026 23:46:44 +0000 [thread overview]
Message-ID: <20261105-tdx-selftests-v16-0-2024e8fa517a@google.com> (raw)
This patch series focuses on setting up a TDX VM and adding all code
necessary to run a basic lifecycle test.
Unlike standard KVM selftests can set up the VM through guest registers,
TDX module protects TDs' register state from the host. This feature of
TDX causes problems on VM boot state initialization and the ucall
implementation.
In standard KVM selftests, the host directly initializes the guest state
by manipulating Special Registers (SREGs) and General Purpose Registers
(GPRs) via IOCTLs (KVM_SET_SREGS, etc.) before the first KVM_RUN.
To bypass direct register initialization by the host, we utilize the
standard x86 reset vector as the default entry point.
The mechanism works as follows:
1. The host places register values into a specific memory region and
inserts boot code at the VM's default starting point.
2. When the VM starts, it executes this boot code to "pull" values from
memory and manually set up its own SREGs and GPRs.
3. Once the environment is ready, the boot code jumps to the guest code.
The standard x86 ucall() implementation uses PIO, but it does not
actually transmit data through the 4-byte PIO data. Instead, it relies
on the host reading the ucall address directly from the guest's RDI
register.
TDX selftests cannot utilize the standard x86 ucall implementation
because the host is unable to access the guest's RDI register. Between
the two alternatives, TDVMCALL_MMIO and TDVMCALL_REPORT_FATAL_ERROR,
TDVMCALL_MMIO has fragility concerns and requires hardcoding a magic
address while ignoring mmio_gpa. Therefore, the Report Fatal Error
TDVMCALL is the cleanest and most efficient solution for TDX ucalls.
Main Changes from v15[1]:
1. Rebase onto kvm/next:
- Replace vm_phy_pages_alloc() with ____vm_phy_pages_alloc(...,
true, false) in tdx_vm_setup_boot_code_region() and
tdx_vm_setup_boot_parameters_region() to allocate protected pages
at fixed GPAs in custom memslots (TD_BOOT_CODE_SLOT and
TD_BOOT_PARAMETERS_SLOT), as vm_phy_pages_alloc() now takes an
enum kvm_mem_region_type.
- Drop 3 patches.
2. Simplify tdx_init_vm() by dropping the intermediate CPUID allocation
and clearing init_vm->cpuid.padding.
3. Move tdx_vcpu_init() to tdx_util.c, use PRIx64 for hw_error in
tdx_vm_ioctl(), and align tdx_vcpu_ioctl() error formatting with
tdx_vm_ioctl().
4. Decouple tdx_load_private_memory() from tdx_vm_finalize() and call
both explicitly in kvm_arch_vm_finalize_vcpus().
5. Check 32-bit address bounds on idt, gdt, and esp_gva before assigning
them to 32-bit boot parameter fields.
6. Refine comments, commit messages, and __tdvmcall().
Thanks for the reviews from Binbin and Xiaoyao!
Series is organized by:
Patches 1 - 3: Initialize the TDX VM
Patches 4 - 7: Add the TDX boot code
Patches 8 - 11: Set up the boot region
Patches 12 - 14: Set up the vCPU
Patches 15 - 16: Finalize the TDX VM
Patches 17 - 20: Implement the ucall and run the TDX test
[1]: https://lore.kernel.org/all/20261001-tdx-selftests-v15-0-7c62a5d8a992@google.com/
Signed-off-by: Lisa Wang <wyihan@google.com>
---
Ackerley Tng (1):
KVM: selftests: Add helpers to init TDX memory and finalize VM
Erdem Aktas (2):
KVM: selftests: Add TDX boot code
KVM: selftests: Add a helper to issue TDVMCALLs from the TDX vm
Isaku Yamahata (1):
KVM: selftests: Update kvm_init_vm_address_properties() for TDX
Lisa Wang (1):
KVM: selftests: Require guest_memfd for TDX VMs
Sagi Shahar (12):
KVM: selftests: Initialize the TDX VM
KVM: selftests: Expose segment definitions to assembly files
tools: include: Add kbuild.h for assembly structure offsets
KVM: selftests: Introduce structures for TDX guest boot parameters
KVM: selftests: Expose functions to get default sregs values
KVM: selftests: Set up TDX boot code region
KVM: selftests: Set up TDX boot parameters region
KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu
KVM: selftests: Load per-vCPU guest stack in TDX boot parameters
KVM: selftests: Set entry point for TDX guest code
KVM: selftests: Load private memory and finalize TDX VM in kvm_arch_vm_finalize_vcpus()
KVM: selftests: Add TDX lifecycle test
Sean Christopherson (3):
KVM: selftests: Add macros to simplify creating VM shapes for non-default types
KVM: selftests: Add support for per-VM ucall ops on x86
KVM: selftests: Add support for TDX ucalls, via TDVMCALL_REPORT_FATAL_ERROR
tools/include/linux/kbuild.h | 11 +
tools/testing/selftests/kvm/.gitignore | 3 +-
tools/testing/selftests/kvm/Makefile.kvm | 33 ++-
tools/testing/selftests/kvm/include/kvm_util.h | 27 +-
.../testing/selftests/kvm/include/x86/processor.h | 42 +++
.../selftests/kvm/include/x86/processor_asm.h | 12 +
tools/testing/selftests/kvm/include/x86/sev.h | 2 -
.../selftests/kvm/include/x86/tdx/td_boot.h | 81 ++++++
tools/testing/selftests/kvm/include/x86/tdx/tdx.h | 16 ++
.../selftests/kvm/include/x86/tdx/tdx_util.h | 85 ++++++
tools/testing/selftests/kvm/include/x86/ucall.h | 6 +-
tools/testing/selftests/kvm/lib/kvm_util.c | 2 +-
tools/testing/selftests/kvm/lib/x86/processor.c | 105 +++++---
tools/testing/selftests/kvm/lib/x86/sev.c | 16 --
tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S | 71 +++++
.../selftests/kvm/lib/x86/tdx/td_boot_offsets.c | 21 ++
tools/testing/selftests/kvm/lib/x86/tdx/tdx.S | 39 +++
tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c | 300 +++++++++++++++++++++
tools/testing/selftests/kvm/lib/x86/ucall.c | 58 +++-
tools/testing/selftests/kvm/x86/sev_dbg_test.c | 13 +-
tools/testing/selftests/kvm/x86/sev_smoke_test.c | 40 +--
tools/testing/selftests/kvm/x86/tdx_vm_test.c | 33 +++
22 files changed, 913 insertions(+), 103 deletions(-)
---
base-commit: 1689c80fca308978ea1c9f03d15a500f4e44e2e1
change-id: 20260722-tdx-selftests-1da5587cf047
Best regards,
--
Lisa Wang <wyihan@google.com>
next reply other threads:[~2026-11-05 23:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 23:46 Lisa Wang [this message]
2026-11-05 23:46 ` [PATCH v16 01/20] KVM: selftests: Add macros to simplify creating VM shapes for non-default types Lisa Wang
2026-11-05 23:46 ` [PATCH v16 02/20] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Lisa Wang
2026-11-05 23:46 ` [PATCH v16 03/20] KVM: selftests: Initialize the TDX VM Lisa Wang
2026-11-05 23:46 ` [PATCH v16 04/20] KVM: selftests: Expose segment definitions to assembly files Lisa Wang
2026-11-05 23:46 ` [PATCH v16 05/20] tools: include: Add kbuild.h for assembly structure offsets Lisa Wang
2026-11-05 23:46 ` [PATCH v16 06/20] KVM: selftests: Introduce structures for TDX guest boot parameters Lisa Wang
2026-11-05 23:46 ` [PATCH v16 07/20] KVM: selftests: Add TDX boot code Lisa Wang
2026-11-05 23:46 ` [PATCH v16 08/20] KVM: selftests: Expose functions to get default sregs values Lisa Wang
2026-11-05 23:46 ` [PATCH v16 09/20] KVM: selftests: Set up TDX boot code region Lisa Wang
2026-11-05 23:46 ` [PATCH v16 10/20] KVM: selftests: Set up TDX boot parameters region Lisa Wang
2026-11-05 23:46 ` [PATCH v16 11/20] KVM: selftests: Require guest_memfd for TDX VMs Lisa Wang
2026-11-05 23:46 ` [PATCH v16 12/20] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu Lisa Wang
2026-11-05 23:46 ` [PATCH v16 13/20] KVM: selftests: Load per-vCPU guest stack in TDX boot parameters Lisa Wang
2026-11-05 23:46 ` [PATCH v16 14/20] KVM: selftests: Set entry point for TDX guest code Lisa Wang
2026-11-05 23:46 ` [PATCH v16 15/20] KVM: selftests: Add helpers to init TDX memory and finalize VM Lisa Wang
2026-11-05 23:47 ` [PATCH v16 16/20] KVM: selftests: Load private memory and finalize TDX VM in kvm_arch_vm_finalize_vcpus() Lisa Wang
2026-11-05 23:47 ` [PATCH v16 17/20] KVM: selftests: Add a helper to issue TDVMCALLs from the TDX vm Lisa Wang
2026-11-05 23:47 ` [PATCH v16 18/20] KVM: selftests: Add support for per-VM ucall ops on x86 Lisa Wang
2026-11-06 16:47 ` [PATCH v16.1] KVM: selftests: Add support for TDX ucalls, via TDVMCALL_REPORT_FATAL_ERROR Sean Christopherson
2026-11-05 23:47 ` [PATCH v16 19/20] " Lisa Wang
2026-11-05 23:47 ` [PATCH v16 20/20] KVM: selftests: Add TDX lifecycle test Lisa Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105-tdx-selftests-v16-0-2024e8fa517a@google.com \
--to=wyihan@google.com \
--cc=ackerleytng@google.com \
--cc=adrian.hunter@intel.com \
--cc=afranji@google.com \
--cc=ajones@ventanamicro.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=chenyi.qiang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=erdemaktas@google.com \
--cc=isaku.yamahata@intel.com \
--cc=iweiny@kernel.org \
--cc=jmcrey@google.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pratikrajesh.sampat@amd.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=runanwang@google.com \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®