mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: lirongqing <lirongqing@baidu.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	<linux-rtc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Li RongQing <lirongqing@baidu.com>
Subject: [PATCH] rtc: interface: skip the RTC read in rtc_timer_do_work() on an empty queue
Date: Thu, 5 Nov 2026 15:37:42 +0800	[thread overview]
Message-ID: <20261105073742.2193-1-lirongqing@baidu.com> (raw)

From: Li RongQing <lirongqing@baidu.com>

After rtc_set_time(), the RTC core schedules rtc->irqwork to re-read
the clock and reprocess the timer queue.

When the timer queue is empty, there is no timer to expire and no
next alarm to program, so reading the RTC is unnecessary. However,
an RTC read can take up to 3ms on some systems, blocking the CPU for
a significant amount of time. Even on faster systems, it can still
take around 50us.

Check whether the timer queue is empty under ops_lock before reading
the RTC. If it is empty, release the lock and return immediately.

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 drivers/rtc/interface.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
index 96626f8..a65b594 100644
--- a/drivers/rtc/interface.c
+++ b/drivers/rtc/interface.c
@@ -977,6 +977,11 @@ void rtc_timer_do_work(struct work_struct *work)
 		container_of(work, struct rtc_device, irqwork);
 
 	mutex_lock(&rtc->ops_lock);
+	if (!timerqueue_getnext(&rtc->timerqueue)) {
+		pm_relax(rtc->dev.parent);
+		mutex_unlock(&rtc->ops_lock);
+		return;
+	}
 again:
 	err = __rtc_read_time(rtc, &tm);
 	if (err) {
-- 
2.9.4


                 reply	other threads:[~2026-11-05  7:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105073742.2193-1-lirongqing@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®