From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793887566; b=RRDfKInHqN6VgFUJPRHVCdPNTSHqlwASXuKfT31vKMMDjHqHsmcb34JM+SHwm+7MqMNA mRiChYPlAAGRhwUrTLNd1AcDFc1BKnGFD15ck/162IkkyaM4n52oHf3LLBUVK+LyH0jyx 9jkIv6jHO1BVd5j+ILfUNf10mfbFAmJmj6K707cewGg4grNetsghA/E1OrYhKubz923y3 jX9xrFEr6OlCqt5qfgDdXGC2MDogksJXehsBhYuzO0VFwI1YaCBAwJgwGdk1m+yjd8AdD gE20zt7Kmkmade8+t/OKZa0g4zdhxUg8enC7N84+sZcQ6ejblq9P2DrZC58OzJrOVGQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793887566; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=/TZdy0v25LHQ/8qZj/SLbaFNwYCRnqtlTMoJLynwB7k=; b=DFGkyIQwASl4+RXZ8UWSk/BZvJq7U5Atode9ajHXaZDBq1X8Aabz/h0YsM9a/iZCsVTg ZrX3akaZI/EUFbtvt+J/zY8FxxREmZk38PK5fE1NuUeE7wdgh6fvks/Km+RgBuQAO8uut OTPGh0uIzfzaciJOPIpFwaKbCRO06WFR3GxoIbrtMh2d+mzCIwDb8/tiQE+SqFe0qe29V XrGZcp2D5JaEj0i5OQ6yJMEuw6YStFq+V/Y+II9biS/w4tfnP67jnoWSmrFM84lVB/QzG xf3FiZYT9yBPbacFjwbFzdC6YHx4Xfdwz2/VO0vLg/6iVcxhCcCzXx+594CDQEXXWiQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=PzGmAogF; arc=none smtp.remote-ip=209.85.128.45 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D60E1606A32C for ; Thu, 5 Nov 2026 14:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D60E1606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=PzGmAogF Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4a5177d78c7so17783935e9.2 for ; Thu, 05 Nov 2026 06:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793887564; x=1794492364; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/TZdy0v25LHQ/8qZj/SLbaFNwYCRnqtlTMoJLynwB7k=; b=PzGmAogFk5pSFK+wRR9BO/6p0BoRe9LotWLbM+RS9OR9kFRGX0Fus28SaCZHTGG88U EPKw2Cc9cpeAr99lWCcTu5Vmk4jyf/vjnH5dYm7Icj0AYxqLi7vt/dyF/EybyeBhDqeY kXME8cwLrQNVhJDa2beTo+cY2ZCQ0qzs+Ofze8rkUO5o4l2Zf6OoEnYFBqI7nw2EuQMk rX4NkywdVM0w1kS2Zrn+dEQ3Bnss2G5/Qd6B4OuGMU25VFuVH/4SdgcpBvAwFEvpQZkp 2fOOz0jj3KYGOUQwCn/bmfrSkLeo5V9kyGZuJm9DUv65PJn27GU6OQmjxRB6JbTlBDLZ M4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793887564; x=1794492364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/TZdy0v25LHQ/8qZj/SLbaFNwYCRnqtlTMoJLynwB7k=; b=L+RvfCbPEqiDyg+Wr5CqWMVywyYef7fXUKexJvmnG4es4zBWN83Gh4jT6z/Z938VUK 9m/sKx6K5rpQHyu/R9OlwjteRlhYJxWtTgUIJ8mx4ub0bF5oJmeNCw4fHJQkapzVzMaH chfVt3zUUhZdGuPmVI0Jn/oy9qIiD30szWKIpQVmsSyy7XWTsawxyF539O/5sMBOVzLc TvK/hrgtyR/Bx5KGGmSa7eSrbISS/npoY2VQkz7AtXHke+nbmZfNlb1H2NkIxKYbjH/Q vVFA22qNPZcZ0Az7/RbZaYYMgAMWzhISqUB0mTl3TPpT4AMnV5J7wTpyxMkG2honhA9/ bVdQ== X-Forwarded-Encrypted: i=1; AKwUvBwe+5OSwVwWwxic/3Hii6jAQxuq0COBWl9HZ3qjl7FUbhYyW3tSpL6ECIb14RUtQeZ8lgoumX3VJUotl+I=@vger.kernel.org X-Gm-Message-State: APuU4Z/2WQ6GkOUCRzt468MHl0Bn1XY47Xe6hciRZ7oUMK9yN2U7i/BZ mB1shTlwJdq8p+ACYdMpmbKanjpLsyz8IFy+UvEOGqs/RGgLAUHus25W X-Gm-Gg: AYBFou3QDe/uN11NCinvkFDOYDkM6fWup/BnpYBzTrJmwZaRTXg4Zyuj4YhEMsAr+N7 5XBR6wxOzXknQPoMQHq2avCZYcC0Y599DTO7ce8iv48sLHY7yZqxVcxAdKkT9qIK16dNQ2lSES+ MrW3la+DOVRUQyImpJcJy7sLs/XP/+gx5mt/pRQdZvBrVQmvXifOjwYIHip2Ra3LgkmV8tZ4Bjb bm3k5YcvPY5nxAmnT1nNgiyFmwgaZd0zzpMiIUGIdPZUiXEqZKNlTTqA5ceUZXFlGRDBo5zSaK6 rsKNmGao7+/bOVlDFHluQYl0OpdKSRJ/Jrt4Z3gUcZuVwLtWx8RNk/WmdggmBMLamYYJgmXFIBY E94ZYBcSqwOqAL2OmF6XrT82tOomo374ROpw+v92ScD5YtCt3z+jbVdDLabac229L3CnDZ9/ekI jpbKdJgwr+aKAZjaf89fAevyOZfe5yXotgcwHf7pXpWIS60Ix+vnCf8w10pSC0VIHjg0woR/YS7 l9km2h4WJyPDrYBn+t4jUsKxUYzmFYv5aCAkQh+Ksv4F0TH7+moirubmRuOjmVpFkRRCT2JEZ0O WB/iLQDgbrNVXXEyCKcVVX0OLS4pavViI+VtkAZ4y1Q2DNFrAQ== X-Received: by 2002:a05:600c:628d:b0:4a1:f7f4:7ced with SMTP id 5b1f17b1804b1-4ac185bd243mr424532335e9.17.1793887564261; Thu, 05 Nov 2026 06:06:04 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48fed92a753sm11454111f8f.45.2026.11.05.06.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 06:06:03 -0800 (PST) From: Svyatoslav Ryhel To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Neil Armstrong , Jessica Zhang , Mikko Perttunen , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 06/10] drm/tegra: Make panel parsing by tegra_output_probe() optional Date: Thu, 5 Nov 2026 16:05:06 +0200 Message-ID: <20261105140510.165165-7-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261105140510.165165-1-clamor95@gmail.com> References: <20261105140510.165165-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The tegra_output_probe() performs panel parsing unconditionally, even for devices that do not require it (such as HDMI) or that handle panel parsing on their own (like DSI). Make panel parsing configurable. Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/drm.h | 2 +- drivers/gpu/drm/tegra/dsi.c | 2 +- drivers/gpu/drm/tegra/hdmi.c | 2 +- drivers/gpu/drm/tegra/output.c | 52 ++++++++++++++++++---------------- drivers/gpu/drm/tegra/rgb.c | 2 +- drivers/gpu/drm/tegra/sor.c | 2 +- 6 files changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h index bc720ae8d95e1..e53fe68161cb8 100644 --- a/drivers/gpu/drm/tegra/drm.h +++ b/drivers/gpu/drm/tegra/drm.h @@ -156,7 +156,7 @@ static inline struct tegra_output *connector_to_output(struct drm_connector *c) } /* from output.c */ -int tegra_output_probe(struct tegra_output *output); +int tegra_output_probe(struct tegra_output *output, bool get_panel); void tegra_output_remove(struct tegra_output *output); int tegra_output_init(struct drm_device *drm, struct tegra_output *output); void tegra_output_exit(struct tegra_output *output); diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 7b595310e7379..a4c0c63bbe567 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev) if (err < 0) return err; - err = tegra_output_probe(&dsi->output); + err = tegra_output_probe(&dsi->output, false); if (err < 0) return err; diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 0d2c0ab0a63e9..fc6eb7410045c 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1855,7 +1855,7 @@ static int tegra_hdmi_probe(struct platform_device *pdev) hdmi->output.dev = &pdev->dev; - err = tegra_output_probe(&hdmi->output); + err = tegra_output_probe(&hdmi->output, true); if (err < 0) return err; diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index d0ba3bd0aab8f..ff2e28a1e00b7 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -94,7 +94,7 @@ static irqreturn_t hpd_irq(int irq, void *data) return IRQ_HANDLED; } -int tegra_output_probe(struct tegra_output *output) +int tegra_output_probe(struct tegra_output *output, bool get_panel) { struct device_node *ddc, *panel; const void *edid; @@ -104,31 +104,33 @@ int tegra_output_probe(struct tegra_output *output) if (!output->of_node) output->of_node = output->dev->of_node; - err = drm_of_find_panel_or_bridge(output->of_node, -1, -1, - &output->panel, &output->bridge); - if (err && err != -ENODEV) - return err; - - panel = of_parse_phandle(output->of_node, "nvidia,panel", 0); - if (panel) { - /* - * Don't mix nvidia,panel phandle with the graph in a - * device-tree. - */ - WARN_ON(output->panel || output->bridge); - - if (output->panel) { - drm_panel_put(output->panel); - output->panel = NULL; - } - - output->panel = of_drm_find_panel(panel); - of_node_put(panel); - - if (IS_ERR(output->panel)) { - err = PTR_ERR(output->panel); - output->panel = NULL; + if (get_panel) { + err = drm_of_find_panel_or_bridge(output->of_node, -1, -1, + &output->panel, &output->bridge); + if (err && err != -ENODEV) return err; + + panel = of_parse_phandle(output->of_node, "nvidia,panel", 0); + if (panel) { + /* + * Don't mix nvidia,panel phandle with the graph in a + * device-tree. + */ + WARN_ON(output->panel || output->bridge); + + if (output->panel) { + drm_panel_put(output->panel); + output->panel = NULL; + } + + output->panel = of_drm_find_panel(panel); + of_node_put(panel); + + if (IS_ERR(output->panel)) { + err = PTR_ERR(output->panel); + output->panel = NULL; + return err; + } } } diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index addcecf8592b1..01475995d9cc8 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -236,7 +236,7 @@ int tegra_dc_rgb_probe(struct tegra_dc *dc) rgb->output.of_node = np; rgb->dc = dc; - err = tegra_output_probe(&rgb->output); + err = tegra_output_probe(&rgb->output, true); if (err < 0) return err; diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index e384cbd0cbf72..ab81e412e05f1 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3806,7 +3806,7 @@ static int tegra_sor_probe(struct platform_device *pdev) if (err < 0) goto put_aux; - err = tegra_output_probe(&sor->output); + err = tegra_output_probe(&sor->output, true); if (err < 0) { dev_err_probe(&pdev->dev, err, "failed to probe output\n"); goto put_aux; -- 2.53.0