mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Sandeep Haemoon <sandeeph@loljews.com>
Cc: netdev@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add 9K jumbo frame
Date: Thu, 5 Nov 2026 14:26:34 +0000	[thread overview]
Message-ID: <20261105142634.GT865646@horms.kernel.org> (raw)
In-Reply-To: <patch-f1b04513b0fe3fb0a35ac744799fb0f3@loljews.com>

On Mon, Nov 02, 2026 at 12:48:45AM +0200, Sandeep Haemoon wrote:
> The driver caps max_mtu at 2030 bytes and programs the MAC max-rx field
> for at most 2048-byte frames, so MTU > 2K is rejected and 9K jumbo
> frames are not usable on the 10G XGMII MACs.
> 
> Add a MTK_NETSYS_RX_9K capability for MT7988 and:
> - advertise 9K max_mtu on XGMII MACs, derived from the DT phy_mode at
>   probe time so DSA can raise the conduit MTU before the netdev is
>   opened;
> - program XMAC_RX_CFG2 on the XGMII MACs;
> - derive the shared RX buffer length from the largest MTU and size the
>   RX rings from it;
> - program the PDMA RX SDL max frame so the DMA engine accepts jumbo
>   frames;
> - reject a runtime MTU change that would need a different ring buffer
>   size while DMA is running; the rings are sized at the next open.
> 
> This is a forward-port of the MediaTek downstream jumbo series:
> Mason Chang's "change default rx buffer length", "add 9k jumbo frame
> support" and "add dynamic rx buffer adjustment support" (MediaTek
> OpenWrt feed 999-eth-30/31/33, carried in
> frank-w/BPI-Router-Linux 92bfdbdd4de1/b4c6cb1d5532/ca4c976dce22),
> plus Frank Wunderlich's "try to fix crash the right way"
> (a3207a383794).
> 
> Link: https://github.com/frank-w/BPI-Router-Linux/commit/b4c6cb1d5532
> Link: https://github.com/mediatek/mtk-openwrt-feeds
> Signed-off-by: Sandeep Haemoon <sandeeph@loljews.com>

Reviewed-by: Simon Horman <horms@kernel.org>


  parent reply	other threads:[~2026-11-05 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 22:58 [PATCH net-next 0/2] net: ethernet: mtk_eth_soc: 9K jumbo frame support Sandeep Haemoon
2026-11-01 22:48 ` [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add 9K jumbo frame Sandeep Haemoon
2026-11-01 22:48   ` [PATCH net-next 2/2] net: ethernet: mtk_eth_soc: skip page_pool for Sandeep Haemoon
2026-11-05 14:27     ` Simon Horman
2026-11-05 14:26   ` Simon Horman [this message]
2026-11-05 22:22   ` [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add 9K jumbo frame Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105142634.GT865646@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=sandeeph@loljews.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®