From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.173 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793890943; b=cJve4+PNFpvgv3A/lOkn4m9TR1LbQU1WKA//NSQK7HOrCxy7GlcXIZt7mKNGq4vXmS1/ HPubllGae9bIZajNEN6nP9ZwiA2HxOCGzZuAZ/51dpAK355VIm0ZNIdBaZ+mZEseY3tLO 8wuSs7pWeTbqKcxpmWrtgUzoQQPhSyo0ftfXLgIrSIhxpoMcnM0SPBneBjPsRHJQUO7BY rFF15Jm4N4/sbX91TrEKgA8/ZiKjP2g2k0ga8awG8aB5OKSXyAkzrFXh8C6lOaQyLc/VV 6BaoCMF0ZzG7FwNsd9B0wb9E75r85XhGIlhQ0m3Z6AKxK9rjMmx9fv2qRTqXotIMpGA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793890943; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=WhfC9zLe5HZoGXWudWFtnEm8q0utD3cNm8ZYGhH+ONg=; b=5sl006jV+/CbW+fOveM8fEENut/mZVI+ql4wjllK0Lc8suHvqm3XkP4pzf6SjvSAhdbp F9sy0rL9DHequkQuAcmGn3EAmGyIzS9bhJnz2IoIdgRR12ICQAKYBXTpYOk0fmftfQsvL ojl8HOLYZEMX5k3LOZYh0Q0T9X9Cqzf4C/Pkeo0KZfduqzSvQAnf1cTB2S5Hs+x7Fn4Dn z8WR4n5dIusttNipr+dnbb4VjLL7UkheRwc9XYgM0DFAVjhY+gM6oV5lK3yCu/1En4sCo Rhn808vzLCcMTT1JsC+Spp6Sp1H9ja46cVFuFm9X/GzVUKpoCKMYJK1jbI1Agk6y4WA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=cYVeN9Ge; arc=none smtp.remote-ip=209.85.208.173 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38505606A32F for ; Thu, 5 Nov 2026 15:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 38505606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=cYVeN9Ge Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-3aced9804e8so5027481fa.2 for ; Thu, 05 Nov 2026 07:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793890941; x=1794495741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WhfC9zLe5HZoGXWudWFtnEm8q0utD3cNm8ZYGhH+ONg=; b=cYVeN9GeZ3cisxISnKLjZlIyT+rK1yLbIVjHn5XG6in28/fMG2xB8+9AzlcEOP3Tn+ VWBWNJJyGExU/01KlsfcjQ+ylMG6QiMGe7FF1KzSz3bdgs/hOnktrTMBQgpytVJYHsCQ VxX4oqX9UljaU+GOja1bnRi6DSDU/RYYYtQ875uAIOB0AIqf3y5s0sNK5613hTZlRUwh YTq+1kF0XuEAtTJAcUlXa5P8jsHKU9NgU76fRFs4U3Tj9Ks4SRZ9+J/XLxF72xbqMsdM 0OaWT8ZikeZZ+jueJ/8LZekROr5y/eg/X/huh5HKUob+CIZk68DcDtROzj2ZNupegUDU miMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793890941; x=1794495741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WhfC9zLe5HZoGXWudWFtnEm8q0utD3cNm8ZYGhH+ONg=; b=M30S+cz+snzGtGPa+PqIrms6zInsauy1ZpI07OkV4cw6zNEzJ3cZcOiFKdUPG2UrRl 9YvkIUy7oURF3X5v7gDjRT9wFnTbruFfSuTehHDpqHkJRqFEWLO0ShAnh6XSDudvy7Il 8UeXBN9EW/pCFhLUyw5sxFuENlof30grsS0GaZE1lQLsHOtc4T+URbOhUodjCk8MSD4Z Lcc9diZnu4sOWHZbeefPt/znhGB7Do1jkiWxzZkDyAm647jiM1d1mNbr2aJJeA3fvHFi p4Wh91CejSpE6CinKEhgEi9s1JI0rldk6zSsJUznULTN5lGXbLnKGj0lbc2aaehlo/Qc UCfA== X-Forwarded-Encrypted: i=1; AKwUvBxpXsp0ziNdiyBKIUemD4/jpcqS/J7g8tgUVxADbtPnOao7+MQ7elEnHUtUltiDS6s3VZr+cvBbdZj0jQQ=@vger.kernel.org X-Gm-Message-State: APuU4Z9ZYFhHT8C/s+jbZja82znQVAX/mCKVaz+rhsWudTqtnf1Hhr1r RrF9VlNN/jUaXHFTUF4sdNnzOS1DrK80LPlM4/sndwEFkT6unF8xMDqK X-Gm-Gg: AYBFou1AeTh2EWJZrc9/TCnjtZsXxABy0GFw3U6oWxrXxWCLZKBX+elS7v2YR1msZ7i HbCXcfTbi1ZVMJLqMoK+Q/il5ONG+dZOPZ2+nOjTVyiRD2O+OJA05JzELTaEot18FuuNaH9a9eV dZrgF16A31wnBDDx/ScwUZJppzds1dq3rU9wOawznUMApZpRHHG6WHdtbeU1aNUmyNDFNLmrYte HI3g3JD7K4LIMKbtgkXyvGbDkdJlAuzrt2HLhfTHsdLFh+0n5VkjXwi3aVgWVU/+smlo7FBwUyZ W2/wp7sKo3V0cWcYAFNvt/xnyOa0YFmo//HVqMIhtm/qwjc/u3ESTENpSkHv6RZl+o9pMDFlUFr abY6bHpLAI6ObXHof4xsr4Z2g+hcis+8xlOoMT0a6vWjsTDIjOrxJNnjfLoSDDxYdZus1oez9iY CLp+kqgxpTUKFcAFitfpfeyqlUEoiesjEWeeHxX9djVld6t2m1GW17deezs8ON6o2aOgEmLPZFY RJR1YNlY6CcrYStckUMJDpSZyqD6DHXvdew+daU/JJ1dVdckaTVSXHrw+/0P/tPnV9OROeChT3d 1zklUIz9NU4n6wwwNvDvIUz7GfGqkNJ4EU+ETGv1fflOPkvH7+bPm6+5UDjldddLmCmFzavvYto 4kz4Lklfqqoi+s6FA6GDzSrwZ X-Received: by 2002:a05:6512:3d17:b0:5bf:a27e:e23e with SMTP id 2adb3069b0e04-5bfd957fbe0mr7482897e87.57.1793890941006; Thu, 05 Nov 2026 07:02:21 -0800 (PST) Received: from Ansuel-XPS24.lan (93-34-90-148.ip49.fastwebnet.it. [93.34.90.148]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48fed552aaesm11042960f8f.40.2026.11.05.07.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 07:02:19 -0800 (PST) From: Christian Marangi To: Stephen Boyd , Brian Masney , Jerome Brunet , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christian Marangi Subject: [PATCH v3 1/2] clk: en7523: convert to full clk_hw implementation for en7581 Date: Thu, 5 Nov 2026 16:02:05 +0100 Message-ID: <20261105150207.23023-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261105150207.23023-1-ansuelsmth@gmail.com> References: <20261105150207.23023-1-ansuelsmth@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for support of .set_rate, convert the clock register logic from fixed clock implementation to full clk_hw implementation with dedicated OPs for Airoha EN7581 SoC. This is just a rework and no behaviour change is expected. Signed-off-by: Christian Marangi --- drivers/clk/clk-en7523.c | 75 +++++++++++++++++++++++++++++----------- 1 file changed, 55 insertions(+), 20 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 24fdec2e6198..6640e814d36a 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -126,6 +126,12 @@ struct en_clk_gate { struct clk_hw hw; }; +struct en_clk { + struct regmap *map; + const struct en_clk_desc *desc; + struct clk_hw hw; +}; + struct en_rst_data { const u16 *bank_ofs; const u16 *idx_map; @@ -742,42 +748,71 @@ static int en7523_clk_hw_init(struct platform_device *pdev, en7581_rst_ofs); } +static unsigned long en7581_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct en_clk *c = container_of(hw, struct en_clk, hw); + const struct en_clk_desc *desc = c->desc; + struct device *dev = clk_hw_get_dev(hw); + struct regmap *map = c->map; + u32 val, reg; + u32 rate; + int err; + + err = regmap_read(map, desc->base_reg, &val); + if (err) { + dev_err(dev, "Failed reading fixed clk rate %s: %d\n", + desc->name, err); + return 0; + } + rate = en7523_get_base_rate(desc, val); + + reg = desc->div_reg ? desc->div_reg : desc->base_reg; + err = regmap_read(map, reg, &val); + if (err) { + dev_err(dev, "Failed reading fixed clk div %s: %d\n", + desc->name, err); + return 0; + } + + return rate / en7523_get_div(desc, val); +} + +static const struct clk_ops en7581_clk_ops = { + .recalc_rate = en7581_recalc_rate, +}; + static void en7581_register_clocks(struct device *dev, struct clk_hw_onecell_data *clk_data, struct regmap *map, void __iomem *base) { struct clk_hw *hw; - u32 rate; int i; for (i = 0; i < ARRAY_SIZE(en7581_base_clks); i++) { const struct en_clk_desc *desc = &en7581_base_clks[i]; - u32 val, reg = desc->div_reg ? desc->div_reg : desc->base_reg; + struct clk_init_data init = { + .ops = &en7581_clk_ops, + }; + struct en_clk *en_clk; int err; - err = regmap_read(map, desc->base_reg, &val); - if (err) { - pr_err("Failed reading fixed clk rate %s: %d\n", - desc->name, err); + en_clk = devm_kzalloc_obj(dev, *en_clk); + if (!en_clk) continue; - } - rate = en7523_get_base_rate(desc, val); - err = regmap_read(map, reg, &val); - if (err) { - pr_err("Failed reading fixed clk div %s: %d\n", - desc->name, err); - continue; - } - rate /= en7523_get_div(desc, val); + init.name = desc->name; + en_clk->map = map; + en_clk->desc = desc; + en_clk->hw.init = &init; - hw = clk_hw_register_fixed_rate(dev, desc->name, NULL, 0, rate); - if (IS_ERR(hw)) { - pr_err("Failed to register clk %s: %ld\n", - desc->name, PTR_ERR(hw)); + err = devm_clk_hw_register(dev, &en_clk->hw); + if (err) { + dev_err_probe(dev, err, "Failed to register clk %s\n", + desc->name); continue; } - clk_data->hws[desc->id] = hw; + clk_data->hws[desc->id] = &en_clk->hw; } hw = en7523_register_pcie_clk(dev, base); -- 2.55.0