From: Alex Elder <elder@riscstar.com>
To: bhelgaas@google.com, robh@kernel.org
Cc: herve.codina@bootlin.com, daniel@riscstar.com,
mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 0/4] PCI: of: warn on bogus device_type property
Date: Thu, 5 Nov 2026 09:37:57 -0600 [thread overview]
Message-ID: <20261105153801.435566-1-elder@riscstar.com> (raw)
*** Bjorn seems happy with this series, and Herve has reviewed ***
*** almost all of it, but we'd prefer to get an ACK from Rob ***
Add a check when adding a PCI device to ensure the device_type
property is (or is not) correctly defined when the device has
a non-null devicetree node pointer.
This series also includes three other minor cleanups to the PCI
devicetree code. The first patch prevents a possible null pointer
dereference that Sashiko pointed out some time back. The second
and third patches are simple cleanups. The last adds the new PCI
devicetree node checks and warnings.
-Alex
Between version 6 and version 7:
- Simplified the wording on this cover letter
- No longer check for snprintf() overflow in of_pci_prop_compatible()
- Rebased onto 7.4-rc1
Version 6 is available here:
https://lore.kernel.org/lkml/20260924150222.1179235-1-elder@riscstar.com/
Between version 5 and version 6:
- Simplified the patch header on the last patch, as suggested by
Bjorn
- Rebased on v7.3-rc4; otherwise no code changes
Version 5 is available here:
https://lore.kernel.org/lkml/20260908213459.2519059-1-elder@riscstar.com/
Between version 4 and version 5:
- Made a local variable (bufp) a pointer type in the first patch
- Eliminated an unused local variable (i) in the first patch
Version 4 is available here:
https://lore.kernel.org/lkml/20260904134607.1856121-1-elder@riscstar.com/
Between version 3 and version 4:
- Insert a first patch that fixes a Sashiko-reported issue
- Drop the final "duplicate warning" patch from v3
- Include "pciex" as a valid PCI bridge device_type property value
- Add Herve's Reviewed-by tag on the last patch
Version 3 is available here:
https://lore.kernel.org/lkml/20260901011338.1323243-1-elder@riscstar.com/
Between version 2 and version 3:
- Drop a patch that made a change only needed by a different series
- Switch a function header to use kernel-doc format
- Add a warning if a PCI bridge node has no device_type property
- Added a patch to remove a duplicate warning in the devicetree code
Version 2 is available here:
https://lore.kernel.org/lkml/20260812172247.276554-1-elder@riscstar.com/
Between version 1 and version 2:
- Check the PCI devicetree node even when PCI_DYNAMIC_OF_NODES is
not enabled
Version 1 is available here:
https://lore.kernel.org/lkml/20260807194100.455599-1-elder@riscstar.com/
Alex Elder (4):
PCI: of: avoid allocations in of_pci_prop_compatible()
PCI: of: drop the reg_num argument to of_pci_set_address()
PCI: of: don't zero flags in of_pci_get_addr_flags()
PCI: of: introduce of_pci_verify_node()
drivers/pci/bus.c | 1 +
drivers/pci/of.c | 32 +++++++++++++++++++++++++++++
drivers/pci/of_property.c | 43 +++++++++++++++++++++------------------
drivers/pci/pci.h | 3 +++
4 files changed, 59 insertions(+), 20 deletions(-)
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.53.0
next reply other threads:[~2026-11-05 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 15:37 Alex Elder [this message]
2026-11-05 15:37 ` [PATCH v7 1/4] PCI: of: avoid allocations in of_pci_prop_compatible() Alex Elder
2026-11-05 15:37 ` [PATCH v7 2/4] PCI: of: drop the reg_num argument to of_pci_set_address() Alex Elder
2026-11-05 15:38 ` [PATCH v7 3/4] PCI: of: don't zero flags in of_pci_get_addr_flags() Alex Elder
2026-11-05 15:38 ` [PATCH v7 4/4] PCI: of: introduce of_pci_verify_node() Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105153801.435566-1-elder@riscstar.com \
--to=elder@riscstar.com \
--cc=bhelgaas@google.com \
--cc=daniel@riscstar.com \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®