mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Cercueil <paul.cercueil@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Paul Cercueil <paul.cercueil@bootlin.com>
Subject: [PATCH 01/12] mtd: Remove #ifdef guards for PM related functions
Date: Thu,  5 Nov 2026 18:11:47 +0100	[thread overview]
Message-ID: <20261105171158.399247-2-paul.cercueil@bootlin.com> (raw)
In-Reply-To: <20261105171158.399247-1-paul.cercueil@bootlin.com>

Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Paul Cercueil <paul.cercueil@bootlin.com>
---
 drivers/mtd/mtdcore.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 82b1e6392b16..037fe292867b 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -40,8 +40,6 @@
 
 struct backing_dev_info *mtd_bdi;
 
-#ifdef CONFIG_PM_SLEEP
-
 static int mtd_cls_suspend(struct device *dev)
 {
 	struct mtd_info *mtd = dev_get_drvdata(dev);
@@ -58,15 +56,11 @@ static int mtd_cls_resume(struct device *dev)
 	return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(mtd_cls_pm_ops, mtd_cls_suspend, mtd_cls_resume);
-#define MTD_CLS_PM_OPS (&mtd_cls_pm_ops)
-#else
-#define MTD_CLS_PM_OPS NULL
-#endif
+static DEFINE_SIMPLE_DEV_PM_OPS(mtd_cls_pm_ops, mtd_cls_suspend, mtd_cls_resume);
 
 static struct class mtd_class = {
 	.name = "mtd",
-	.pm = MTD_CLS_PM_OPS,
+	.pm = pm_sleep_ptr(&mtd_cls_pm_ops),
 };
 
 static DEFINE_IDR(mtd_idr);
-- 
2.47.3


  reply	other threads:[~2026-11-05 17:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 17:11 [PATCH 00/12] mtd: Remove #ifdef guards for PM related Paul Cercueil
2026-11-05 17:11 ` Paul Cercueil [this message]
2026-11-05 17:11 ` [PATCH 02/12] mtd: rawnand: vf610: Remove #ifdef guards for PM related functions Paul Cercueil
2026-11-05 17:11 ` [PATCH 03/12] mtd: spear_smi: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 04/12] mtd: physmap: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 05/12] mtd: maps: pxa2xx: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 06/12] mtd: nand: mtk: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 07/12] mtd: rawnand: fsmc: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 08/12] mtd: rawnand: hisi504: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 09/12] mtd: rawnand: mtk: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 10/12] mtd: rawnand: omap_elm: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 11/12] mtd: rawnand: r852: " Paul Cercueil
2026-11-05 17:11 ` [PATCH 12/12] mtd: rawnand: txx9ndfmc: " Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105171158.399247-2-paul.cercueil@bootlin.com \
    --to=paul.cercueil@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®