From: Mark Bundschuh <mkbund@amazon.com>
To: <jiaqiyan@google.com>
Cc: <akpm@linux-foundation.org>, <muchun.song@linux.dev>,
<osalvador@suse.de>, <david@kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: add htlb_dissolve vmstat event
Date: Thu, 5 Nov 2026 19:12:21 +0000 [thread overview]
Message-ID: <20261105191221.1010676-1-mkbund@amazon.com> (raw)
In-Reply-To: <CACw3F50bfsm0pZoEYL=y_9yiQ2XEQTjCE=496D-=MJbRnXGhQQ@mail.gmail.com>
On Thu, Nov 5, 2026 at 09:46:58AM -0800, Jiaqi Yan wrote:
> > update_and_free_hugetlb_folio(h, folio, false);
> > + count_vm_event(HTLB_DISSOLVE);
>
> What if update_and_free_hugetlb_folio() failed / bailed out?
dissolve_free_hugetlb_folio() already rejects gigantic folios without
runtime support, and restores the vmemmap itself before calling it, so
the only bail out left is a folio with unreliable raw hwpoison, which is
leaked on purpose. That folio still leaves the pool, so I think it should
be counted. "frees" in the commit message is misleading though, I'll fix
that in v2.
prev parent reply other threads:[~2026-11-05 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 2:03 Mark Bundschuh
2026-11-05 17:46 ` Jiaqi Yan
2026-11-05 19:12 ` Mark Bundschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105191221.1010676-1-mkbund@amazon.com \
--to=mkbund@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jiaqiyan@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®