From: Borislav Petkov <bp@alien8.de>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: tony.luck@intel.com, linux-edac@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC/i3200: drop the PCI device reference on module exit
Date: Thu, 5 Nov 2026 11:45:29 -0800 [thread overview]
Message-ID: <20261105194529.GAauzc2axWPncLCpVo@fat_crate.local> (raw)
In-Reply-To: <20261104033833.1566974-1-vulab@iscas.ac.cn>
On Wed, Nov 04, 2026 at 03:38:33AM +0000, Wentao Liang wrote:
> i3200_init_one() takes an extra reference on the memory controller with
> pci_dev_get() and stores it in the global mci_pdev pointer. When the
> driver probed a device, i3200_registered stays set and i3200_exit()
> calls pci_dev_put() only in the !i3200_registered branch, so the
> reference is never dropped and the PCI device can not be released.
>
> Move the put out of the conditional. i3200_remove_one() still has to be
> called by hand only for the i3200_init() fallback that probed the device
> outside the PCI driver core.
>
> Fixes: dd8ef1db87a4 ("edac: i3200 memory controller driver")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Grep the kernel tree for Assisted-by guidance.
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/edac/i3200_edac.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
$ ./scripts/get_maintainer.pl -f drivers/edac/i3200_edac.c
Borislav Petkov <bp@alien8.de> (maintainer:EDAC-CORE)
Tony Luck <tony.luck@intel.com> (maintainer:EDAC-CORE)
linux-edac@vger.kernel.org (open list:EDAC-I3200)
linux-kernel@vger.kernel.org (open list)
EDAC-I3200 status: Orphan
^^^^^^^
All your patches touching orphaned EDAC drivers are going to be ignored - you
don't want to spend any effort or burn AI energy on them.
I already told you that the last time you sent patches. It looks like probably
no human even read my responses.
Quickly grepping through lore.kernel.org it looks like this effort you're
doing is some AI gunk mindlessly sending kernel patches.
So you will be ignored too.
Just remember that if you don't listen to maintainers and ignore their
feedback, all your effort and wasted energy will be for nothing.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next parent reply other threads:[~2026-11-05 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261104033833.1566974-1-vulab@iscas.ac.cn>
2026-11-05 19:45 ` Borislav Petkov [this message]
2026-11-06 3:28 ` Wentao Liang
2026-11-06 7:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105194529.GAauzc2axWPncLCpVo@fat_crate.local \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®