From: Albu Victor-Marian <albu.victor.m@gmail.com>
To: albu.victor.m@gmail.com, Dan Carpenter <dan.carpenter@linaro.org>
Cc: christian.gromm@microchip.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
parthiban.veerasooran@microchip.com
Subject: [PATCH v2] staging: most: dim2: add missing Return: documentation
Date: Thu, 5 Nov 2026 22:21:10 +0200 [thread overview]
Message-ID: <20261105202110.1081296-1-albu.victor.m@gmail.com> (raw)
In-Reply-To: <20261104205108.1041666-1-albu.victor.m@gmail.com>
Add missing Return: descriptions to functions in dim2.c.
Signed-off-by: Albu Victor-Marian <albu.victor.m@gmail.com>
---
Changes in v2:
* Simplified the Return: descriptions
modified: drivers/staging/most/dim2/dim2.c
---
drivers/staging/most/dim2/dim2.c | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index 0e2512d166329..34c0eb796c291 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -156,6 +156,8 @@ void dimcb_on_error(u8 error_id, const char *error_message)
* @hdm_ch: channel specific data
*
* Transfer a buffer from pending_list if the channel is ready
+ *
+ * Return: 0 on success, negative on failure.
*/
static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
{
@@ -211,6 +213,8 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
* @data: private data
*
* Wait for network status and deliver it to mostcore once it is received
+ *
+ * Return: 0 when the thread stops without error.
*/
static int deliver_netinfo_thread(void *data)
{
@@ -392,6 +396,9 @@ static irqreturn_t dim2_task_irq(int irq, void *_dev)
*
* Acknowledge the interrupt and service each initialized channel,
* if needed, in task context.
+ *
+ * Return: IRQ_WAKE_THREAD after acknowledging the interrupt and
+ * servicing each initialized channel.
*/
static irqreturn_t dim2_ahb_isr(int irq, void *_dev)
{
@@ -442,7 +449,9 @@ static void complete_all_mbos(struct list_head *head)
* @ccfg: structure that holds the configuration information
*
* Receives configuration information from mostcore and initialize
- * the corresponding channel. Return 0 on success, negative on failure.
+ * the corresponding channel.
+ *
+ * Return: 0 on success, negative on failure.
*/
static int configure_channel(struct most_interface *most_iface, int ch_idx,
struct most_channel_config *ccfg)
@@ -561,7 +570,9 @@ static int configure_channel(struct most_interface *most_iface, int ch_idx,
* @mbo: pointer to the buffer object
*
* Push the buffer into pending_list and try to transfer one buffer from
- * pending_list. Return 0 on success, negative on failure.
+ * pending_list.
+ *
+ * Return: 0 on success, negative on failure.
*/
static int enqueue(struct most_interface *most_iface, int ch_idx,
struct mbo *mbo)
@@ -637,7 +648,9 @@ static void request_netinfo(struct most_interface *most_iface, int ch_idx,
* @ch_idx: corresponding channel ID
*
* Destroy a channel and complete all the buffers in both started_list &
- * pending_list. Return 0 on success, negative on failure.
+ * pending_list.
+ *
+ * Return: 0 on success, negative on failure.
*/
static int poison_channel(struct most_interface *most_iface, int ch_idx)
{
@@ -710,6 +723,8 @@ static struct {
*
* By success stores one of the CLK_{NUMBER}FS in the *val and returns 0,
* otherwise returns -EINVAL.
+ *
+ * Return: 0 on success, negative on failure.
*/
static int get_dim2_clk_speed(const char *clock_speed, u8 *val)
{
@@ -746,7 +761,8 @@ static void dim2_release(struct device *d)
* @pdev: platform device structure
*
* Register the dim2 interface with mostcore and initialize it.
- * Return 0 on success, negative on failure.
+ *
+ * Return: 0 on success, negative on failure.
*/
static int dim2_probe(struct platform_device *pdev)
{
--
2.43.0
prev parent reply other threads:[~2026-11-05 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 20:51 [PATCH] " Albu Victor-Marian
2026-11-05 5:11 ` Dan Carpenter
2026-11-05 20:21 ` Albu Victor-Marian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105202110.1081296-1-albu.victor.m@gmail.com \
--to=albu.victor.m@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®