From: Ian Bridges <icb@fastmail.org>
To: Wahid Khan <wahidzk0091@gmail.com>
Cc: linkinjeon@kernel.org, smfrench@gmail.com,
senozhatsky@chromium.org, tom@talpey.com,
chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Ian Bridges <icb@fastmail.org>
Subject: Re: [PATCH] ksmbd: refuse to read a handle that is not open for reading
Date: Thu, 5 Nov 2026 15:19:43 -0600 [thread overview]
Message-ID: <20261105211943.696696-1-icb@fastmail.org> (raw)
In-Reply-To: <20261105173838.1882328-1-wahidzk0091@gmail.com>
On Thu, Nov 05, 2026 at 11:08:38PM +0530, Wahid Khan wrote:
> Return STATUS_ACCESS_DENIED when the file is not readable.
Tested on ksmbd-for-next with KASAN. A READ on a handle opened for
FILE_WRITE_DATA | FILE_EXECUTE | FILE_READ_ATTRIBUTES hits the warning
before and gets STATUS_ACCESS_DENIED after. smbtorture gives the same
results as without the patch.
Reviewed-by: Ian Bridges <icb@fastmail.org>
Tested-by: Ian Bridges <icb@fastmail.org>
next prev parent reply other threads:[~2026-11-05 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 17:38 Wahid Khan
2026-11-05 21:19 ` Ian Bridges [this message]
2026-11-05 22:34 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105211943.696696-1-icb@fastmail.org \
--to=icb@fastmail.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
--cc=wahidzk0091@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®