From: Greg KH <gregkh@linuxfoundation.org>
To: Tian Xuechen <202300460064@mail.sdu.edu.cn>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
prashantrahul23@gmail.com
Subject: Re: [PATCH] staging: octeon: unwind receive initialization on IRQ failure
Date: Thu, 5 Nov 2026 06:27:48 -0500 [thread overview]
Message-ID: <2026110532-succulent-chug-b9d5@gregkh> (raw)
In-Reply-To: <20261105083628.4043124-1-202300460064@mail.sdu.edu.cn>
On Thu, Nov 05, 2026 at 04:36:28PM +0800, Tian Xuechen wrote:
> cvm_oct_rx_initialize() returns immediately when request_irq() fails.
> The failing receive group has already had its NAPI instance added and
> enabled, and earlier selected groups can still have registered IRQ
> handlers and active NAPI instances.
>
> When RX initialization fails, cvm_oct_probe() unwinds and returns an
> error. The driver core then releases the managed platform data, even
> though earlier RX IRQ actions still reference NAPI instances embedded
> in that data.
>
> Disable and delete NAPI for the failing group, then unwind the previously
> initialized groups in reverse order. Mask their POW interrupts, disable
> and delete their NAPI instances, and free their IRQs before returning the
> original error.
>
> Fixes: ae4350364008 ("staging: octeon: Propagate rx initialization failures")
> Signed-off-by: Tian Xuechen <202300460064@mail.sdu.edu.cn>
> ---
> An AI coding assistant helped analyze the RX error path, draft the
> unwind, and edit the changelog.
Please read: https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
prev parent reply other threads:[~2026-11-05 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 8:36 Tian Xuechen
2026-11-05 11:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026110532-succulent-chug-b9d5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=202300460064@mail.sdu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=prashantrahul23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®