From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793977914; b=VMVd/ngBGoIMnxMerFi/rkw/uVo/JsJMV92gBVIFaD+BBFw8EsWqys6ErSleULWAVSyn +sXtfXlrllvRRnX2TI8ag/4XmhG1Fn2In90Q6cJzZPSm4LUWNIUDSydAL5XaDZG7yjBVN sDwyfR7glzvdFlNqkm0CiwZ8LVki77m1ACBlmJArBJ9DXs3sUXmopxTsEn4YXy43G/BUl v5YIjViwX32NpiG9sXw5BUL1IjvCHo+81juGt4aAcqRvrUKfbluTZFuQU8FOWcwQvrYWy DtCkdEQnAuujHgLWYqN2TaDZzNUVNyi/Wa+Cfr/6WgnFGzlMctC0LUQRK0aNCP8P9qQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793977914; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=Cv8s/0EAszCylBUn/l89HelJSiucOWcHTNPbi/BT1f4=; b=ANmWrmGh92obI/V4oabZuCbu+kcA7Z2WnltmIG4BvjIdk5kDjXdWgLGg98Conv9Sx0O5 c3gd3PvEawF01/oQkSIgTPZn3IVqwwN+GB2DIgg3vesLMEKB3aLG5bt9avdDBo++xK759 IlHUqvHxiXhrQkQQbL/vu1nE6dm1K4mQheUMedhRg/6yOQeDMQgHUpXl3ga8fVln6AZxw 0ENkkPJhgdm4aaEE8rAafqJRfl65v7AWYCh6JmNcz2/m6vZ4SmdHXVmMbFVnWsoN6NVKL JfHWdFTfWaa0OBYh76u2nJXmevumfHCEEFDG4UniopLD5/VDz1iLV0D4TKKfHZqM0pw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GEgasTjq; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7731606A337 for ; Fri, 6 Nov 2026 15:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=GEgasTjq Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BA4C1F008A4; Fri, 6 Nov 2026 15:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793977913; bh=Cv8s/0EAszCylBUn/l89HelJSiucOWcHTNPbi/BT1f4=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=GEgasTjq4ZPejm9sZ6app4Zav04q8SnDv5Sz56BoI4EjUc0+UNxHgnhxGfXgCUGKI bB/o9zqedy3xsYWqQCVeeas6wqJ2FYuEzTyrjPEtILtbZba1c993EoX25FW2KN8DTB kRh3gtka5lyJy5Omf0ExDF9VYIPWtyxpGj5L8B9DlM9/K/kKKXkZeZ6noJ1hpRQmPP GMPPo3Af0Get2HZzjbnS9GGswq6ZTLHgh4e+zjK3vpkjeVmuej+qE0IBeUYJVvPWTf YfySTNr0KbgY7B4sDKyr3NUnfbBpu4dbeEcxXUn6zz8bye260u5qMt0l+mfhSie/e2 2dX7T6ZtCH0VQ== From: Maxime Ripard Date: Fri, 06 Nov 2026 16:11:39 +0100 Subject: [PATCH v8 1/7] drm/amd/display: Fix planes atomic_create_state implementation X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261106-drm-reset-state-flag-v8-1-50fd046b705f@kernel.org> References: <20261106-drm-reset-state-flag-v8-0-50fd046b705f@kernel.org> In-Reply-To: <20261106-drm-reset-state-flag-v8-0-50fd046b705f@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Daniel Stone , Harry Wentland , Jocelyn Falempe , =?utf-8?q?Jonas_=C3=85dahl?= , =?utf-8?q?Michel_D=C3=A4nzer?= , Pekka Paalanen , Sebastian Wick , Simon Ser , Victoria Brekenfeld , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , amd-gfx@lists.freedesktop.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1628; i=mripard@kernel.org; h=from:subject:message-id; bh=UXJpmo5ROHPzhMg+de0zko6SddYMdKZssZ+0PtShoSM=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFlv3+nLT/Gddj9hytw5so6XPcTSr3rpvQ08u0hR8GDRm f3Vir23O6ayMAhzMsiKKbI8kQk7vbx9cZWD/cofMHNYmUCGMHBxCsBEVjxirDP5ZDxLNnTi8cMq B7ZJ7T+l8kVw9hYrz+NXou1tbGKmR1x97/DPpu5Ghpj4pJcad7b8nsZYp7w5kpEnPE2T42OUYej Ek7YNSndm75ZZdGx1p2ldsff1Ddf+/clKyJmxp8emgj9t8dUKAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Commit 2bcec01cf105 ("drm/amdgpu_dm: Convert to atomic_create_state") converted the amdgpu planes to use atomic_create_state instead of reset. Unlike reset, atomic_create_state is meant to allocate a new default state without any side effect on the hardware or software state. However, during the conversion we forgot to remove the call to destroy the existing plane state if any. While this was expected from a reset implementation, it's not for an atomic_create_state one. Remove it. Fixes: 2bcec01cf105 ("drm/amdgpu_dm: Convert to atomic_create_state") Signed-off-by: Maxime Ripard --- To: Harry Wentland To: Leo Li To: Rodrigo Siqueira To: Alex Deucher To: Christian König Cc: amd-gfx@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c index 91398230d408..31101c810bac 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c @@ -1804,7 +1804,4 @@ STATIC_IFN_KUNIT struct drm_plane_state *amdgpu_dm_plane_drm_plane_create_state( } - if (plane->state) - plane->funcs->atomic_destroy_state(plane, plane->state); - __drm_atomic_helper_plane_state_init(&amdgpu_state->base, plane); amdgpu_state->degamma_tf = AMDGPU_TRANSFER_FUNCTION_DEFAULT; -- 2.55.0