Re: [PATCH v2 1/3] dt-bindings: thermal: amlogic: add S4

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

On Fri, Nov 06, 2026 at 11:19:11AM +0100, christian.koever-draxl@student.uibk.ac.at wrote:
> From: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
> 
> The S4 temperature sensors are the G12A design, but like on T7 their
> calibration value is only available through the secure monitor: the
> ao-secure register used on G12A holds unrelated data on S4. Add a
> compatible for them. As on T7 the sensor index is the argument of the
> secure monitor phandle, so one compatible serves the CPU and the DDR
> sensor. Each sensor has a bus clock gating register access (ts_pll /
> ts_ddr in the S4 peripheral clock controller) besides the functional
> clock, so it takes both, named.

Why can this not use the t7 as a fallback? Driver suggest it can.

> 
> Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
> ---
>  .../devicetree/bindings/thermal/amlogic,thermal.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> index e72cb39ac635..66dd572ff44b 100644
> --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
> @@ -23,6 +23,7 @@ properties:
>            - const: amlogic,g12a-thermal
>        - enum:
>            - amlogic,a1-cpu-thermal
> +          - amlogic,s4-thermal
>            - amlogic,t7-thermal
>  
>    reg:
> @@ -84,7 +85,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: amlogic,t7-thermal
> +            enum:
> +              - amlogic,s4-thermal
> +              - amlogic,t7-thermal
>      then:
>        properties:
>          clocks:
> -- 
> 2.56.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]