From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793972683; b=Wzw95WBN4JHCPZbE9i/qaJmA9a3TpbjwAEKoGLR5aNIi86pczoWpuTwn7Kufka1Cdjzh 8QCJlJ6IGURHSRxLi8VuiZJGZr/daKZetF95r80+79MA4FvjiBlI1IQwdLH+4Ps2OnK+n MDxecUpYFbHtXemsBEt4WX3Wwa2HyyFk9nzmZ4qAojjK5qTzctyds7Kc3J1MFydum4WBf AkuP1pQMrEyN0TrnU+2TwetCzc4bZpoGxziraWxAG3Yra4WswlDXCKXVZuymjQ7A4t4Rl dX36seEYk4311N5O2KGiBXKriA36Rcbu4orGbz2VfeeTRA9epCLguXiU+sIpopDnjpQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793972683; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-ORIG-GUID:X-Authority-Analysis: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=X74gM1bp+SoEVAkxrQgSjNlyuK9X9pX12qrSj0XV6aI=; b=zAnFmCSJPDAGz3KJdUvBmQmg+yUDmRwdA4szLIjJA3kiqf8inm+kshSa1mcS3e1ZcWAP 9/ci1d1z1MAqXCQC1wVx46PhOXMqWTcz5qM9bX8sLaXW6kOQ/J5wvgKQMhHfXFT+f0VdO TNUd2iVMqxroZzCBatRfzSqGQUHYQBXEp6Xu/37NziqTFTdGGg5FjAqbUI21ws4kwgYRB MPqs/3Bqfs9f9dqeNjMHgI6BJ/gTQOYGAa7uCZt/xi8f6868IiRwW7gY9dTd6gsNSjctw 0nqtJsCOYd9QBumPpbUuW61rOqCOyGbhobIt6J7yIW3+YZXPORyyyZMQMMvwVI1UdkQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=pg9iyBc5; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=MUXC+1Hp; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB501606D809 for ; Fri, 6 Nov 2026 13:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AB501606D809 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=pg9iyBc5; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=MUXC+1Hp Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A6APBCt444185 for ; Fri, 6 Nov 2026 13:44:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X74gM1bp+SoEVAkxrQgSjNlyuK9X9pX12qrSj0XV6aI=; b=pg9iyBc5WIMupZ9y VA7bc0RKC7mqvAH3ZqmJ3zDwPKrjMEp2I4Tuu81EODHGyzwHeqErGAOvVCOouQGZ 9XSZXh+/7siDPbkBxrKh+BOOJQnfAfK5yQDAy/0sSNY/9C7SK2Yh3fD8zuKfvrXw 4DWMJftjR9pVcWOlakPaucfIJ88rVc5DeHn4aQA6/TvcEcDyg3AhEapV4ibpmCPn p985hIy0ESjDZwgpDHE7KZqp8X3ZL9tOgaRm8yXhcZ+3xHWfV34SdEVfQqWQEuvg JUBJQiS1qORcUkQxEhKxiwE4ooLjIIm7DJKRwid3FKvxL5km1R2fvc9GtnjUK/sV zGnb9A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hs3p9u1fw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Nov 2026 13:44:41 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-934963b2bc0so152753185a.3 for ; Fri, 06 Nov 2026 05:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793972681; x=1794577481; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X74gM1bp+SoEVAkxrQgSjNlyuK9X9pX12qrSj0XV6aI=; b=MUXC+1HpXN7iCVzGguaeQJ1Qg9fTAzj9OpGSOXAKtERfu/7NYbusSVpr6fGDxOjzGL 1k/KLvcPPN7D9Gl7SKlWQWsjbnaHSAHm1YsgBcvXgvA7q2XOR/d6bUECPOtzMyAh/zl6 6b5TpemCOzVe3vfUSNk5DRBRVhcffrHJTzdu//qzyIc8d/y9yxKvqtN0WkhIjI5OaGs9 fYkOm7GOVRTYZTyDnXlA/MMbKSovti+sW3vLR7vsvrx9RSUqm0ARcJiCEA7D9cv0oTLt MA0ENt/ZjeHjU8UVG56z2oIKl+9pezvni0hGXEqjQmKHRtTbdM49gsPKzTFUsPzceN5l SgNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793972681; x=1794577481; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X74gM1bp+SoEVAkxrQgSjNlyuK9X9pX12qrSj0XV6aI=; b=dcLDNGp/LKGANLFpJIc2cOKng/gSE/40NULFkkgcRQYJR9rfG3VaYE2ANgxVTt+p+a c5eNHAFIpYhD0Z6ZfJhzYLjoW+t06TJn4nNYPcbB6wGU6oXr0yXXkeZVRgmfwzvgF4NQ mqkxrZ6nCBovNDdhfwerOqmgxEwNfD3fwRJVaZNUpxOPzoWMRcEcU/G9IWSOOiwx3Ohr KcwKWAqx+J7M0MrcEpcwHmFjoA2lmu6VQL1Cc77xoJC0Pn85HoOYmm7wa51wY9Goh/1q KOH4TNg5oPlBc8mVjFzIO57xwkKp7p31TLAflhdCWyeBd8TrgRTzh/Ce3OOWQS/4Mft/ jFzg== X-Forwarded-Encrypted: i=1; AKwUvBz50rc0BkqdFUni/30YbudIIDu2YNcpf9mYkbhlTbv26J5Sq3TXOSDlsvi/nQEMPy7KZXWOsMDHD0yB9Kw=@vger.kernel.org X-Gm-Message-State: APuU4Z839dze8WRmQ16YMkioVWx7q39q3W2CiCGjlUchHcVS014pNqYv f01F8611K7FrwGjWLz/hxazIVPCl2pL3MAKyf2JDVowp13keBLerdQxsSkHwhXkkloU16yvB0Kw a6NF6TWwLOb3VYWePe4P+bUdgL41ifckqeQ7/sqmBAWX3I2+GLBOdpLCRchDO4d/RYYU= X-Gm-Gg: AYBFou1CmHc26nZpZvPytNhsyqO52wZ+ed84fnZ9Q8I7exVnC18w4FKwZXTvtiwXHIZ wX6OznD/Orc/GlVtGUwv3kZYbOXsZ41VtjPrAhgvmMCMjsjWpyuM38gdDBKLziD5Xzde1wIZ3fe 8oCS13TT+rD1egTyxGn+PN0866qbLdUKMgHi3GgQiBBQcaiIfa/QYp/S8MJmMSfWtTI6Ow1ubyU d8QLhLaZO4J7eL3hekKAQ8iFip4u68sp5bVwTei3KW4vUGKWYndf3mJemBtYeAowgInyc++Db1w RECCHUyzkpttAnF9vsxkrO4eCe1vHo0qVNkq45tGgsIZgfHJXVwl2yzN0T0gAvRZTe+6P4W9a8+ 8FA4a1A5aUibEYtWMeRjYHhU5ppIZe1csETv5qaBFX9vQ3RVitm/ELPYsiK2Ai/ZUa4/6RVC97j +8aeLljdcY+4BFxQ3E1AMrqeTtqWYgHQJNKtoExXZbITI0H+LHEReafP63gMs2XQ== X-Received: by 2002:a05:620a:4515:b0:93c:6534:d04d with SMTP id af79cd13be357-945f34ffe72mr328909385a.35.1793972680840; Fri, 06 Nov 2026 05:44:40 -0800 (PST) X-Received: by 2002:a05:620a:4515:b0:93c:6534:d04d with SMTP id af79cd13be357-945f34ffe72mr328904385a.35.1793972680295; Fri, 06 Nov 2026 05:44:40 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5c003055a5csm382747e87.13.2026.11.06.05.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2026 05:44:37 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Nov 2026 15:44:09 +0200 Subject: [PATCH v2 3/8] drm/msm: move the UBWC plane size calculation out of DPU X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261106-ubwc-format-docs-v2-3-82949f88f030@oss.qualcomm.com> References: <20261106-ubwc-format-docs-v2-0-82949f88f030@oss.qualcomm.com> In-Reply-To: <20261106-ubwc-format-docs-v2-0-82949f88f030@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Mauro Carvalho Chehab , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , linux-media@vger.kernel.org, Nicolas Dufresne , Vikash Garodia , Dikshita Agarwal , Robert Mader , Neil Armstrong X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=8736; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=5IhPgv4vcHizwDpAPh96mpXfWHFvDsJ77WdWDQntwOM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBq7dmzmMoPIpfABi0aq2VOyhe9NZJKm/HiCBayP Y2rEaMdZNeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCau3ZswAKCRCLPIo+Aiko 1curCACp4z5hzQ0f80ZRvD5UJrxNjVpnGhmVPetmQvA4Xhxx7kS3v/SnC0cvBTsMhEYjAv52pBp u0dEc6JYMy7CinD6/FPJflLdLsPuKUSxlBADmPp5H7h68CqRzyNW4irwzI/LlZgqJ3gfj6qDLgx aK7ANvDatSNgXgWGQb2MEac066R3E1t4UrIfbCiMWf0thd8jp6EB3br4PnNbEzFpXpyVUZggZST Wx42CkJ8diDF7qpVitmF6IzpYB32/n03vcq/6LEaAsUlg0mfTbYM8c+XdxYs+4u2L9eSgDzl5O3 4x8itu/M/ZqgqIyhOp7+nh8EPaj+byVggz5fYk84Ejg0bzoV X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA2MDA1NCBTYWx0ZWRfXwT9je32GGjXB k80nYfaiKf32wLk6hxzMsB6Z0Il+0TfLkUXtdc0wLThba9VXl4i6dGPAjidCW6ttorQq1sNekpj 02iWAG5W+EdFrdrGEoP8e57bqdnjyrA= X-Proofpoint-GUID: 02lUWj-NgY9r3P_JObObf2L6ItZXQ3jg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA2MDA1NCBTYWx0ZWRfXxFuMRAEU9FM8 6Q5MfTlw9mHB1++2+jKBv7LzS43d1DXSMb/QG3UTCKvEcilwKeCy7VW7nhW5gE8/01NkNg4MunL JJope1LXypUM4/c/E9ty9cou1iwdE1ZFKfrLR+8LHoi/Jauy/yxGWlOVJZnSrC2QeWU+XRUHHSY mH+3cHp4vZy6KxNkwnk8GcBpc/L8eJeH15ZGRKI5AteNAdPXF7fEcdF5i9HhVQfHJmU/0qHMyQ0 Vblp6RlRJftuFzjcl1WRiQ5/vs246rvFPxmGBba2D1A/JNHsQuEd4KVDqscjLocK2mAdjNTSLMO WLK9EKsXO0+f1WjSveCBkUgxIWqiupr/N8ZSiI6TXtaPUC4eC7XjfzxNss6za+sxpLfcQmBOeM4 hQsFdL2Ic7Pa6Np9RmrUkbxr+atbuzi6je1WO17GSdIior+7AYzmMJaYsvy34cL1Ehct3oY5Avy J0CgYflMDgH3vvPvgcQ== X-Proofpoint-ORIG-GUID: 02lUWj-NgY9r3P_JObObf2L6ItZXQ3jg X-Authority-Analysis: v=2.4 cv=ZIZCCn7b c=1 sm=1 tr=0 ts=6aedd9ca cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=iK4Z-rw_lK1HlppuerAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-06_03,2026-11-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611060054 The layout of a UBWC framebuffer is only known to the DPU, which computes it from the framebuffer at atomic check time. msm_framebuffer_init() cannot check such a framebuffer against its layout, so it applies the linear size check instead, which neither matches what the DPU fetches nor what userspace allocates. Move the calculation next to mdp_get_format() and make it take the format and the image size instead of the framebuffer, so that it can be used before the framebuffer is created. No functional change. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 84 ++--------------------- drivers/gpu/drm/msm/disp/mdp_format.c | 100 ++++++++++++++++++++++++++++ drivers/gpu/drm/msm/msm_drv.h | 3 + 3 files changed, 107 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c index a8e9a69834af..06903325e7e7 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c @@ -10,8 +10,6 @@ #include "dpu_kms.h" #include "dpu_formats.h" -#define DPU_UBWC_PLANE_SIZE_ALIGNMENT 4096 - /* * struct dpu_media_color_map - maps drm format to media format * @format: DRM base pixel format @@ -58,87 +56,13 @@ static int _dpu_format_populate_plane_sizes_ubwc( struct drm_framebuffer *fb, struct dpu_hw_fmt_layout *layout) { - bool meta = MSM_FORMAT_IS_UBWC(fmt); - - if (MSM_FORMAT_IS_YUV(fmt)) { - unsigned int stride, y_sclines, uv_sclines; - unsigned int y_tile_width, y_tile_height; - unsigned int y_meta_stride, y_meta_scanlines; - unsigned int uv_meta_stride, uv_meta_scanlines; - - if (MSM_FORMAT_IS_DX(fmt)) { - if (fmt->flags & MSM_FORMAT_FLAG_UNPACK_TIGHT) { - /* can't use round_up() here because 192 is NPoT */ - stride = roundup(fb->width, 192); - stride = round_up(stride * 4 / 3, 256); - y_tile_width = 48; - } else { - stride = round_up(fb->width * 2, 256); - y_tile_width = 32; - } - - y_sclines = round_up(fb->height, 16); - uv_sclines = round_up((fb->height+1)>>1, 16); - y_tile_height = 4; - } else { - stride = round_up(fb->width, 128); - y_tile_width = 32; - - y_sclines = round_up(fb->height, 32); - uv_sclines = round_up((fb->height+1)>>1, 32); - y_tile_height = 8; - } - - layout->plane_pitch[0] = stride; - layout->plane_size[0] = round_up(layout->plane_pitch[0] * - y_sclines, DPU_UBWC_PLANE_SIZE_ALIGNMENT); - - layout->plane_pitch[1] = stride; - layout->plane_size[1] = round_up(layout->plane_pitch[1] * - uv_sclines, DPU_UBWC_PLANE_SIZE_ALIGNMENT); - - if (!meta) - return 0; - - y_meta_stride = DIV_ROUND_UP(fb->width, y_tile_width); - layout->plane_pitch[2] = round_up(y_meta_stride, 64); + mdp_format_ubwc_plane_sizes(fmt, fb->width, fb->height, + layout->plane_pitch, layout->plane_size); - y_meta_scanlines = DIV_ROUND_UP(fb->height, y_tile_height); - y_meta_scanlines = round_up(y_meta_scanlines, 16); - layout->plane_size[2] = round_up(layout->plane_pitch[2] * - y_meta_scanlines, DPU_UBWC_PLANE_SIZE_ALIGNMENT); - - uv_meta_stride = DIV_ROUND_UP((fb->width+1)>>1, y_tile_width / 2); - layout->plane_pitch[3] = round_up(uv_meta_stride, 64); - - uv_meta_scanlines = DIV_ROUND_UP((fb->height+1)>>1, y_tile_height); - uv_meta_scanlines = round_up(uv_meta_scanlines, 16); - layout->plane_size[3] = round_up(layout->plane_pitch[3] * - uv_meta_scanlines, DPU_UBWC_PLANE_SIZE_ALIGNMENT); - } else { - unsigned int rgb_scanlines, rgb_meta_scanlines, rgb_meta_stride; - - layout->plane_pitch[0] = round_up(fb->width * fmt->bpp, 256); - rgb_scanlines = round_up(fb->height, 16); - layout->plane_size[0] = round_up(layout->plane_pitch[0] * - rgb_scanlines, DPU_UBWC_PLANE_SIZE_ALIGNMENT); - - if (!meta) - return 0; - - /* RGB metadata is fetched through SRC2, SRC1 stays unused */ + /* RGB metadata is fetched through SRC2, SRC1 stays unused */ + if (!MSM_FORMAT_IS_YUV(fmt) && MSM_FORMAT_IS_UBWC(fmt)) layout->num_planes += 1; - rgb_meta_stride = DIV_ROUND_UP(fb->width, 16); - layout->plane_pitch[2] = round_up(rgb_meta_stride, 64); - - rgb_meta_scanlines = DIV_ROUND_UP(fb->height, 4); - rgb_meta_scanlines = round_up(rgb_meta_scanlines, 16); - - layout->plane_size[2] = round_up(layout->plane_pitch[2] * - rgb_meta_scanlines, DPU_UBWC_PLANE_SIZE_ALIGNMENT); - } - return 0; } diff --git a/drivers/gpu/drm/msm/disp/mdp_format.c b/drivers/gpu/drm/msm/disp/mdp_format.c index 2712a73e5783..3dc835c9b937 100644 --- a/drivers/gpu/drm/msm/disp/mdp_format.c +++ b/drivers/gpu/drm/msm/disp/mdp_format.c @@ -655,6 +655,106 @@ const struct msm_format *mdp_get_format(struct msm_kms *kms, uint32_t format, return NULL; } +#define MSM_UBWC_PLANE_SIZE_ALIGNMENT 4096 + +/** + * mdp_format_ubwc_plane_sizes - compute the layout of a UBWC or tiled buffer + * @fmt: format, which must use MDP_FETCH_UBWC + * @width: image width + * @height: image height + * @pitch: per-plane pitches + * @size: per-plane sizes + * + * Plane indices follow the hardware: 0 is the Y or RGB data, 1 the CbCr data, + * 2 the Y or RGB metadata and 3 the CbCr metadata. Planes not used by the + * format are set to zero. + */ +void mdp_format_ubwc_plane_sizes(const struct msm_format *fmt, + unsigned int width, unsigned int height, + u32 pitch[4], u32 size[4]) +{ + bool meta = MSM_FORMAT_IS_UBWC(fmt); + + memset(pitch, 0, 4 * sizeof(*pitch)); + memset(size, 0, 4 * sizeof(*size)); + + if (MSM_FORMAT_IS_YUV(fmt)) { + unsigned int stride, y_sclines, uv_sclines; + unsigned int y_tile_width, y_tile_height; + unsigned int y_meta_stride, y_meta_scanlines; + unsigned int uv_meta_stride, uv_meta_scanlines; + + if (MSM_FORMAT_IS_DX(fmt)) { + if (fmt->flags & MSM_FORMAT_FLAG_UNPACK_TIGHT) { + /* can't use round_up() here because 192 is NPoT */ + stride = roundup(width, 192); + stride = round_up(stride * 4 / 3, 256); + y_tile_width = 48; + } else { + stride = round_up(width * 2, 256); + y_tile_width = 32; + } + + y_sclines = round_up(height, 16); + uv_sclines = round_up((height + 1) >> 1, 16); + y_tile_height = 4; + } else { + stride = round_up(width, 128); + y_tile_width = 32; + + y_sclines = round_up(height, 32); + uv_sclines = round_up((height + 1) >> 1, 32); + y_tile_height = 8; + } + + pitch[0] = stride; + size[0] = round_up(pitch[0] * y_sclines, + MSM_UBWC_PLANE_SIZE_ALIGNMENT); + + pitch[1] = stride; + size[1] = round_up(pitch[1] * uv_sclines, + MSM_UBWC_PLANE_SIZE_ALIGNMENT); + + if (!meta) + return; + + y_meta_stride = DIV_ROUND_UP(width, y_tile_width); + pitch[2] = round_up(y_meta_stride, 64); + + y_meta_scanlines = DIV_ROUND_UP(height, y_tile_height); + y_meta_scanlines = round_up(y_meta_scanlines, 16); + size[2] = round_up(pitch[2] * y_meta_scanlines, + MSM_UBWC_PLANE_SIZE_ALIGNMENT); + + uv_meta_stride = DIV_ROUND_UP((width + 1) >> 1, y_tile_width / 2); + pitch[3] = round_up(uv_meta_stride, 64); + + uv_meta_scanlines = DIV_ROUND_UP((height + 1) >> 1, y_tile_height); + uv_meta_scanlines = round_up(uv_meta_scanlines, 16); + size[3] = round_up(pitch[3] * uv_meta_scanlines, + MSM_UBWC_PLANE_SIZE_ALIGNMENT); + } else { + unsigned int rgb_scanlines, rgb_meta_scanlines, rgb_meta_stride; + + pitch[0] = round_up(width * fmt->bpp, 256); + rgb_scanlines = round_up(height, 16); + size[0] = round_up(pitch[0] * rgb_scanlines, + MSM_UBWC_PLANE_SIZE_ALIGNMENT); + + if (!meta) + return; + + rgb_meta_stride = DIV_ROUND_UP(width, 16); + pitch[2] = round_up(rgb_meta_stride, 64); + + rgb_meta_scanlines = DIV_ROUND_UP(height, 4); + rgb_meta_scanlines = round_up(rgb_meta_scanlines, 16); + + size[2] = round_up(pitch[2] * rgb_meta_scanlines, + MSM_UBWC_PLANE_SIZE_ALIGNMENT); + } +} + struct csc_cfg *mdp_get_default_csc_cfg(enum csc_type type) { if (WARN_ON(type >= CSC_MAX)) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 2840e8a5052d..02fde07eb6f6 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm/msm_drv.h @@ -204,6 +204,9 @@ struct msm_drm_private { }; const struct msm_format *mdp_get_format(struct msm_kms *kms, uint32_t format, uint64_t modifier); +void mdp_format_ubwc_plane_sizes(const struct msm_format *fmt, + unsigned int width, unsigned int height, + u32 pitch[4], u32 size[4]); struct msm_pending_timer; -- 2.47.3