mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Viral Patel <viral8854@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: magnetometer: add Infineon TLE493D-W2B6
Date: Fri, 6 Nov 2026 02:36:12 +0000	[thread overview]
Message-ID: <20261106023612.344f3b86@jic23-hlaptop> (raw)
In-Reply-To: <20261105-tle493d-v1-1-3246e91e6394@gmail.com>

On Thu, 05 Nov 2026 21:23:47 +0530
Viral Patel <viral8854@gmail.com> wrote:

> Add a binding for the Infineon TLE493D-W2B6, a 3D Hall effect magnetic
> sensor with 12-bit resolution per axis and an integrated temperature
> sensor, accessed over I2C. The A0 to A3 variants of the part only differ
> in their default I2C address, so a single compatible covers all of them.
> 
> The sensor's /INT output shares a pin with SCL and cannot be wired to an
> interrupt controller as a separate line, so there is no interrupts
> property.

I haven't looked at the driver yet, but your explanation in the cover letter
of why it is a separate driver seems fine.

That doesn't exclude using a shared device tree binding (as it is a many
to many relationship between bindings and drivers) and it seems like
nothing stops you combining this with the tle493d-a1b6 binding.

Thanks,

Jonathan


> 
> Signed-off-by: Viral Patel <viral8854@gmail.com>
> ---
>  .../iio/magnetometer/infineon,tle493d-w2b6.yaml    | 48 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 +++
>  2 files changed, 54 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tle493d-w2b6.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tle493d-w2b6.yaml
> new file mode 100644
> index 000000000000..46f9c0e77e24
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tle493d-w2b6.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tle493d-w2b6.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon TLE493D-W2B6 3D Magnetic Sensor
> +
> +maintainers:
> +  - Viral Patel <viral8854@gmail.com>
> +
> +description: |
> +  Infineon TLE493D-W2B6 3D Hall effect magnetic sensor with an I2C interface
> +  and an integrated temperature sensor. The A0, A1, A2 and A3 variants only
> +  differ in their default I2C address (0x35, 0x22, 0x78 and 0x44).
> +
> +  The sensor's /INT output shares a pin with SCL, so it cannot be routed to
> +  an interrupt controller as a separate line. The binding therefore has no
> +  interrupts property.
> +
> +properties:
> +  compatible:
> +    const: infineon,tle493d-w2b6
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        magnetometer@35 {
> +            compatible = "infineon,tle493d-w2b6";
> +            reg = <0x35>;
> +            vdd-supply = <&vdd_3v3>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0017755f593b..c8916e1286d3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13110,6 +13110,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/sound/infineon,peb2466.yaml
>  F:	sound/soc/codecs/peb2466.c
>  
> +INFINEON TLE493D-W2B6 DRIVER
> +M:	Viral Patel <viral8854@gmail.com>
> +L:	linux-iio@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/magnetometer/infineon,tle493d-w2b6.yaml
> +
>  INFINEON TLV493D Driver
>  M:	Dixit Parmar <dixitparmar19@gmail.com>
>  L:	linux-iio@vger.kernel.org
> 


  reply	other threads:[~2026-11-06  2:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 15:53 [PATCH 0/2] iio: magnetometer: add Infineon TLE493D-W2B6 support Viral Patel
2026-11-05 15:53 ` [PATCH 1/2] dt-bindings: iio: magnetometer: add Infineon TLE493D-W2B6 Viral Patel
2026-11-06  2:36   ` Jonathan Cameron [this message]
2026-11-06 16:50     ` Viral Patel
2026-11-05 15:53 ` [PATCH 2/2] iio: magnetometer: add Infineon TLE493D-W2B6 driver Viral Patel
2026-11-06  3:04   ` Jonathan Cameron
2026-11-06 16:44     ` Viral Patel
2026-11-06 16:54       ` Viral Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106023612.344f3b86@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=viral8854@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®