From: Liu Chao <liuc63@xiaopeng.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Juergen Borleis <jbe@pengutronix.de>,
Denis Carikli <denis@eukrea.com>, Lee Jones <lee@kernel.org>,
fangxy@xiaopeng.com, linux-input@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] Input: mx25-tcq - clamp the FIFO sample count to the buffer size
Date: Fri, 6 Nov 2026 15:51:27 +0800 [thread overview]
Message-ID: <20261106075127.3105907-1-liuc63@xiaopeng.com> (raw)
MX25_ADCQ_SR_FDN() reports up to 31 pending samples. The IRQ thread
aligns the count down to a multiple of the sample count but never
bounds it by the size of sample_buf, so a FIFO backlog larger than
TSC_MAX_SAMPLES overruns the stack buffer.
Clamp the count before the alignment so that the result stays a
multiple of sample_count.
Fixes: 4f7ed234f2a5 ("Input: touchscreen: Add imx25 TCQ driver")
Cc: stable@vger.kernel.org
Signed-off-by: Liu Chao <liuc63@xiaopeng.com>
---
drivers/input/touchscreen/fsl-imx25-tcq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
index ff270b3b8572..fa8d8b736723 100644
--- a/drivers/input/touchscreen/fsl-imx25-tcq.c
+++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
@@ -319,6 +319,7 @@ static irqreturn_t mx25_tcq_irq_thread(int irq, void *dev_id)
*/
regmap_read(priv->regs, MX25_ADCQ_SR, &stats);
samples = MX25_ADCQ_SR_FDN(stats);
+ samples = min_t(unsigned int, samples, TSC_MAX_SAMPLES);
samples -= samples % priv->sample_count;
if (!samples)
--
2.50.1
next reply other threads:[~2026-11-06 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 7:51 Liu Chao [this message]
2026-11-06 17:36 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106075127.3105907-1-liuc63@xiaopeng.com \
--to=liuc63@xiaopeng.com \
--cc=Frank.Li@nxp.com \
--cc=denis@eukrea.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fangxy@xiaopeng.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jbe@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®