From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=213.95.11.211 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793961685; b=oCEZ9S3yVDglPR5ZZc3QlURddN702CRLbijuKw2/JMTbyoKYXMMW3gjA0MQxdkOnMwh6 mXyL2MaW3G73V/oW88PNOPstkzh5RydU8p2MsKMWreen8tGWrjjrW4+5P0h2Pb+AJVzwr v8VEMs5qIMzHRrvVDLEJOcF7pTr1twalaHnGLIgeMbZmeaJvcNM7dkLLli+KD9Ow4lHP/ 8N2GdMFB6xEIXvocgcY8+UhCVfW4VVSy3NuYYWIKXR6PfV0yYp8t6zEk3pqorBGun7a3L MjFOmp1qT2gf13fFzpljDYFzqzS7baeT4dSeOvGXYy2bLUnwCeyZMkitUuUHchX0+4Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793961685; h=DMARC-Filter:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent; bh=Y2B3K2s4CMkhzGfN/sXBCg6vT5zF/XqqON8igl9xOC0=; b=lobasmR5c5J9H/BXmqc2VdsqpFtbglUTSJd0NzYoSZCPutuiSIbAxvoTvjug0UjMrrTy jB7QG/AU9ltyzOVYqQeNkMr+954IctBkT2R3CC/PjAgLi93lxHlW/DRYtjXXKHBOCa8ZB WAL85t0D/hiFJpm7gguI9ZohXz2rciNlmth5w0VX8H0Ymb21dYl1qcV1ODrgVH1cE40MW 4fdUVpMcuomX7U0Pn58roerEgV1qqHoaPvbgmXHckSthKjam5TkBlsKu8IEGgPIe3zaRj veoMfp7E373t1Lrc4vAz2HYgQ+Usl+f0SFF4voliQp6QSTv9yoTYGzfy5+y73qpFhKw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.remote-ip=213.95.11.211 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A459606A329; Fri, 6 Nov 2026 10:41:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4A459606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id E6E2C68BFE; Fri, 6 Nov 2026 11:41:19 +0100 (CET) Date: Fri, 6 Nov 2026 11:41:19 +0100 From: Christoph Hellwig To: Mengmeng Zhao Cc: Jens Axboe , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , tytso@mit.edu, Andreas Dilger , Baokun Li , Ojaswin Mujoo , "Ritesh Harjani (IBM)" , Zhang Yi , "Darrick J. Wong" , Andrew Morton , asml.silence@gmail.com, hch@lst.de, Anuj Gupta , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Li Wang Subject: Re: [RFC 1/6] block: refuse a dma-buf bio that carries a crypto context Message-ID: <20261106104119.GA5668@lst.de> References: <20261105065847.196540-1-mengmeng.zhao@linux.dev> <20261105065847.196540-2-mengmeng.zhao@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105065847.196540-2-mengmeng.zhao@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Nov 05, 2026 at 02:58:42PM +0800, Mengmeng Zhao wrote: > + /* a dma-buf bio has no pages for integrity work or contents crypto */ > if (unlikely(op_is_dmabuf(bio->bi_opf) && > - bdev_has_integrity_csum(bio->bi_bdev))) { > + (bdev_has_integrity_csum(bio->bi_bdev) || > + bio_has_crypt_ctx(bio)))) { This could really use a factored helper explaining all the refusals. And maybe we should use the chance to sit back and think what else would blow up and add it there as well.