mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Pei <cp0613@linux.alibaba.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: alex@ghiti.fr, andrii@kernel.org, aou@eecs.berkeley.edu,
	bjorn@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net,
	eddyz87@gmail.com, emil@etsalapatis.com, guoren@kernel.org,
	ihor.solodrai@linux.dev, jolsa@kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-riscv@lists.infradead.org, luke.r.nels@gmail.com,
	martin.lau@linux.dev, memxor@gmail.com, palmer@dabbelt.com,
	pjw@kernel.org, pulehui@huawei.com, puranjay@kernel.org,
	rgbi3307@gmail.com, shuah@kernel.org, song@kernel.org,
	xi.wang@gmail.com, yonghong.song@linux.dev
Subject: Re: [PATCH v2 bpf-next 3/3] selftests/bpf: Add a runtime test for private stack and stack arguments
Date: Fri,  6 Nov 2026 19:31:42 +0800	[thread overview]
Message-ID: <20261106113148.3157-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <DMNFA3D0M816.2K02S8LB47QM4@gmail.com>

Hi Alexei,

Thanks for the review and for writing out the two programs.

> bpf ci is right in the other email.

Okay, will fix it in the next version.

> Also, the test runs on riscv64 only. BPF CI runs arm64 and not riscv64.
> arm64 has the same combination and no test for it.
> The run time part has nothing specific to riscv64.
> The __jited patterns pin the frame sizes that clang picks for C code.
> zero_stack doesn't use the private stack.
> It's the only reason for serial_.
>
> Two asm progs in verifier_stack_arg.c are enough.
> BPF_PROG_TEST_RUN runs a raw_tp prog. No need to attach it.
> The test runs on x86-64, arm64 and riscv64.
> On x86-64 both frames stay on the kernel stack.

Agreed, will redo the test this way in the next version.

Best regards,
Chen

      reply	other threads:[~2026-11-06 11:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 10:04 [PATCH v2 bpf-next 0/3] riscv: bpf: Add BPF private stack support Chen Pei
2026-11-04 10:04 ` [PATCH v2 bpf-next 1/3] " Chen Pei
2026-11-05 13:30   ` Pu Lehui
2026-11-06 11:28     ` Chen Pei
2026-11-04 10:04 ` [PATCH v2 bpf-next 2/3] selftests/bpf: Enable private stack tests for riscv64 Chen Pei
2026-11-06  3:28   ` Pu Lehui
2026-11-04 10:04 ` [PATCH v2 bpf-next 3/3] selftests/bpf: Add a runtime test for private stack and stack arguments Chen Pei
2026-11-04 10:43   ` bot+bpf-ci
2026-11-05 16:37   ` Alexei Starovoitov
2026-11-06 11:31     ` Chen Pei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106113148.3157-1-cp0613@linux.alibaba.com \
    --to=cp0613@linux.alibaba.com \
    --cc=alex@ghiti.fr \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=guoren@kernel.org \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luke.r.nels@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=pulehui@huawei.com \
    --cc=puranjay@kernel.org \
    --cc=rgbi3307@gmail.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=xi.wang@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®