From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793966346; b=QDgz+D7vfVnCpXWfBxVOb3mYEkvx1aer4sIecfi9I4N/rYcblFCRocW62ZGQ8wxvJrfn oQ+GYOOVrgGf7inRz/lQBXcG/f7OiL/eU6kJMt2vmobaOhAMxbul8mdSi+ZWbxvgT/UkK lqN5A/qoe2lTrkIrK1yb4aL8FCojW3a5jkI/JkSyXKnyTuuMGtM2eS4eWJXd4fFy7bIvx WOIL6TwUtzn+3tIGC19ii2FOT79/NQTf0EmsA9JTk2xZAlhgOmuGHly9n66vpdtxtnUOd LcOGE3dZqaN4GzllTwOv+SiBe67vwZadN8dGLMxmX1pXiKQ77Ldot+NsdOtZttEGgjQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793966346; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=jrxKnimkJlrFR0WRqhZUCXVjI+A7zsd604Fm1CjsY5Y=; b=EAqgtE3HIrfqPhNtcmGDo9KXl4jr/Ekb/OtcMbBi1TwBQnqt9zNsegy3vs1Dj/FXQ+x0 QNH/u4DU0kgx3IvsmxWNkCWsyn9CY9d3U4a1QM7KQORFqggFhuwC61EaRtcBXPPknm1a6 ZMKsTXUaEQMayRyNuUdDXRbzU/8dAaEtARpYxYIWFrdN33h7EjUcsGAzJEcoBk/NiS6oh 39j+CIRNU1tSBBvMVYXQ57DP0mjdpMPoEcTefke66lQePDXOt9UmyG6sy/MzuFFzB9hOo w280P8r1OiW5Z33BREFAA/MyeGd6wc1LMJNVzWqJok4wHYuSt24aXEZSsRwTfC1CMhA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=MxpMzx4E; arc=none smtp.remote-ip=209.85.128.50 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27901606A33F for ; Fri, 6 Nov 2026 11:59:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 27901606A33F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=MxpMzx4E Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4a210470b49so3714815e9.2 for ; Fri, 06 Nov 2026 03:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793966343; x=1794571143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jrxKnimkJlrFR0WRqhZUCXVjI+A7zsd604Fm1CjsY5Y=; b=MxpMzx4EXCrl9s9/r80CSIZEdrWtkGNBI4tsPzbGF9W4RTW0vwPYtBaBd4L5FwbNnY pnekJ2frko/Hyl9XJnPDIq1Vp46gE0w39QUttIrA/mFoiQJ38hYrkzUZ1JxUygkPp7T4 jtA+rNm9xIU37LchpUoGzylDBEztpERrFnZFJL1R36Rm+crVa0A+llSLmqDRhnMAdAHl LVFgFL1yjWAMr8VB1wQGlSfEr7/sP3rZXPeqY3ydpy5LqEJ2iBhgw4WgSOTUpkWk0SXm /02K/3e0H4VmQ2eH2GHmi/lweDD+duVaMbEouJD9VtpWV2y/kXfWGATWI6HsJ+FCyj0O ifIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793966343; x=1794571143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jrxKnimkJlrFR0WRqhZUCXVjI+A7zsd604Fm1CjsY5Y=; b=AfbstML6cruBWv4C0KM/GnJh+08XP02k4d4lKbAoX61UIAt9Yv7/jSkujCvKJsH3Ru rGvm7BA6T0ykTRNLOobeIh597CGm6NyiZOd7Jvw2QA7WtS8LkH1pZoQD91DhaZsagdCV PIjIHUWKSeNcPDsAYTEiOBPxqjEyaFNDWtZNL6V1Msj6tCLRjKzK34v6JbwiLdD4Mllx nhfID7ZmxxQcDpRFmiOoLDLhSxwTSAmp0kYXiKrWd6R80pKRuWHI5uUhZ3ollUX44RgL LDb4CigU/SxF+llfBJaN4b5yjEzp/kgOEFIyx62E63n5yTssYZcUtUefpC7CQRv3R+Gi w3ew== X-Forwarded-Encrypted: i=1; AKwUvByr+fTFNV1n750rqSIVwk9hD6lJAXQzKNG96tFurPrja9HtTDOr+oZgUWMxlFyGVHmmEoKPnCM1Ff707C0=@vger.kernel.org X-Gm-Message-State: APuU4Z/I5QfqIDp+Nhjuoo+2CqmoQmpGbHAkS4FZXYNynbf0UPHKOA64 QSySy8fZ9JkCp95Vj/zItgMmx4q8hAin7j2Qy+W/Cagv4XSvLJgn/DBn X-Gm-Gg: AYBFou1Nr2VEqJtknl/ADw8gRAKFAILF+un/PjCK/nwWIjD5mQgELhExBseExCKBx88 tKW466pQttniwGYEuZ32Jd3KHqzXk3ALzbGx/+Ta34dbmlGipvSGln233GAyazNSU/nMrIJJyLv iVbyvYuWo0qLl8Sxvzn+xIQVIKIBJLPOKAHKCqoASzDzIV7VRY7GbbMMLDsLCQilXoIo6l+2VZJ gp7OQjocZ6Meb41lBY91vnpC4j/6pr3LWFxONsU677aOECRb0pP94gTN2KFqvnm2rxNp9eAzKSu UJ88DJZkC/tR2FaHtIbQDTKHocss3OdM2n3ZMfbyrqZ+d2v8UVYucESS/OsB8+S6oqsvvxUDRKF MIibf8efY0FlTSYWpgfWh7cIGpi41rhG48s2UT2UgSkWIKrJIaU432XYg/hTKxs2l1E2B8Ewbqj 1G2TgXxNiLFvZ8UXKJyB9qiCsbvys0uHTzqOXsyi1xQP36nsgMRY+52SLwZfF6EZNdrPCS2+NwM MoqKShVVL6+u1DEiZ3HeTZynad4tQ9ND6Pd7XoPbATSE7P1wDHyUus5p/dTTH9GchdncR3aw964 u/AJYrE9NWn21kveVtw7fLLcI5H9zNtQOJ5jiMw+h4feGSQCRXuJVzbNRBVm8BrUbvRsX+ixiov WnpJ34KvtgHZPRmk4hVU6zl7FOJeB3JxBVg== X-Received: by 2002:a05:600c:c058:b0:4a2:1cc:6551 with SMTP id 5b1f17b1804b1-4b6e0172438mr27417465e9.35.1793966343552; Fri, 06 Nov 2026 03:59:03 -0800 (PST) Received: from Ansuel-XPS24.localdomain (93-34-90-148.ip49.fastwebnet.it. [93.34.90.148]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4b76b5d52a7sm4849775e9.1.2026.11.06.03.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2026 03:59:03 -0800 (PST) From: Christian Marangi To: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christian Marangi Subject: [PATCH v11 2/5] clk: en7523: use devm variant for clk_hw_register and fixed clock Date: Fri, 6 Nov 2026 12:58:47 +0100 Message-ID: <20261106115852.189098-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261106115852.189098-1-ansuelsmth@gmail.com> References: <20261106115852.189098-1-ansuelsmth@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm variant for clk_hw_register and clk_hw_register_fixed_rate to correctly unregister the clocks on probe fails. This should never happen under normal condition but it's better to handle these cleanup. Signed-off-by: Christian Marangi --- drivers/clk/clk-en7523.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 24fdec2e6198..2baec734df9f 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -651,7 +651,7 @@ static struct clk_hw *en7523_register_pcie_clk(struct device *dev, if (init.ops->unprepare) init.ops->unprepare(&cg->hw); - if (clk_hw_register(dev, &cg->hw)) + if (devm_clk_hw_register(dev, &cg->hw)) return NULL; return &cg->hw; @@ -708,7 +708,7 @@ static void en7523_register_clocks(struct device *dev, struct clk_hw_onecell_dat val = readl(base + reg); rate /= en7523_get_div(desc, val); - hw = clk_hw_register_fixed_rate(dev, desc->name, NULL, 0, rate); + hw = devm_clk_hw_register_fixed_rate(dev, desc->name, NULL, 0, rate); if (IS_ERR(hw)) { pr_err("Failed to register clk %s: %ld\n", desc->name, PTR_ERR(hw)); @@ -770,7 +770,7 @@ static void en7581_register_clocks(struct device *dev, struct clk_hw_onecell_dat } rate /= en7523_get_div(desc, val); - hw = clk_hw_register_fixed_rate(dev, desc->name, NULL, 0, rate); + hw = devm_clk_hw_register_fixed_rate(dev, desc->name, NULL, 0, rate); if (IS_ERR(hw)) { pr_err("Failed to register clk %s: %ld\n", desc->name, PTR_ERR(hw)); @@ -1105,7 +1105,7 @@ static void en751221_try_register_clk(struct device *dev, int key, if (WARN_ON_ONCE(key >= EN751221_MAX_CLKS)) return; - hw = clk_hw_register_fixed_rate(dev, name, NULL, 0, rate); + hw = devm_clk_hw_register_fixed_rate(dev, name, NULL, 0, rate); if (IS_ERR(hw)) pr_err("Failed to register clk %s: %pe\n", name, hw); else -- 2.55.0