From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.155 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793967212; b=EzOtnM134BeqRgqZ68q+xDTu4s9r9BcZt2HIB1lJJ9X4UWRoACGDru2zhsm5QuXLdEPB ZspUitRB6+2G/mf3a6t0gttOkCh9aVen0YpkbWYYLmGpFIx5PMYuhVYU7afBh/MkRaJyF oy/ciLxi3NjdOvycgvXirYBhLpiTNJQmQqynR27j0McLd0Q9eMXhyy/CIPLwPlmI/lG9e nkxWGEjJq73frQ78phabH62no7v7uhpQQyefDlMaIQPtWFWs0x2wfn7hRiuOE8dvq1HOL 6nEQvqKUbEwPY+fSHbt7y7T1/MCRdczMLe0QGklVzAZDNhndeCURqEM9TXJ0Km/pFIw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793967212; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding; bh=w0ggjq6I/XXbHR0zS8tnrBfiWpgxIQRt/7sxrjM/4G4=; b=OPCoQWBA4WhGk4Uej+qCYrD21vzqXHJoSXMspmi6YjKZPTQRXpghM98x3n8pXDnalZQ/ CSlvXN0cdUXH6fYCLnw1FUl8c5LR1OFw4hw/qq9iy7ZAgcTCXj7FUdiFMA4kzfNm3Sw7B nojWcO0vcJFjkwHTK/xYPP/revcT1bKUklKJTxbh2CX59be414RnmBYQ7pxQYWmNzvVFw LDKRorioe8RElilSSBJbaew6PEzU0P4IJkeiSh1RGv4ydl1Ktohb7ydSfY+0PbW2lo/PY OA9hDeSkuxbwrO9q5WlZNI3L3Xy5wihjNPtwwfIgqetYbXj618zJ0MEW4qH36Kk1XLg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=fastmail.org; spf=pass smtp.mailfrom=fastmail.org; dkim=pass header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm3 header.b=C0rGGYaz; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=H2q7wvJY; arc=none smtp.remote-ip=103.168.172.155 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39923606A329 for ; Fri, 6 Nov 2026 12:13:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 39923606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm3 header.b=C0rGGYaz; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=H2q7wvJY Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 555CB14000B1 for ; Fri, 6 Nov 2026 07:13:30 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Fri, 06 Nov 2026 07:13:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1793967210; x= 1794053610; bh=w0ggjq6I/XXbHR0zS8tnrBfiWpgxIQRt/7sxrjM/4G4=; b=C 0rGGYaz/wVylknO+nVJvF1oguMGaQ5I7/5A8Ljhe9ZuCCsbJ27ChSzMZl6c5ztFx 030n35VIumqHL8yMUOAh1dumlg5/Gp/0FJRYAq6Qn40tiqGpL4nmZyL4uB831U1i ZKZGurhV3qWs/iVOD1xUg+7/pkgstOHf8AXA+dAmSaK5d1sI9bmLiA8AFTvHoiHh HDpBJ28+r+HAmp9ouabhTJ4ePp5MccOerB238s3ZHoPLHVYxlvplamleyuBz3RQg u6D6GHWwh9StF9wNrtJiejHZt+rle19jSgA9C6uXwTYZTaJAAmPldEREuFKzns/G gb50v0+GMPRUacxlM75TQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1793967210; x=1794053610; bh=w 0ggjq6I/XXbHR0zS8tnrBfiWpgxIQRt/7sxrjM/4G4=; b=H2q7wvJYFw8Za4Apv KjOrMGtl2fd2nkSJDf7zlK5LUconWoIE15GVDg8Bhp8vkBmVPiMyi68h0P7eHWFE /4iHYan9tnixIhGVxyK9Gbgfr1nnapVdaxclpPlDmF8QM3FLgnlxUqyMSJNGu3IM l/xWc/o2Y/0zLd52Fm7yZEZE9mhdojBsQzZhy2BxZUjN7KgC4kblvjI7mLazxkra HjSQmISsUbYaTQIYU9fRrszpDyK5irX9UtJEH57oS7gQBlKdS3Hsfo11P1BPI4XX +DwlSnjqASZIGsoOq0BFiNFmLrfPKuasb/631dtwl8LfktTOip8NYBLN5p28hQWA o8gjg== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=fastmail.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1793967210; d=fastmail.org; mf=PGljYkBmYXN0bWFpbC5vcmc+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:SkTl6YvU+7pmJ8BwwJxVvt7dtYcCrSmgFsfToLESYjj1tN7 PlraanX2n/FsED+KT0ZT83EM5qURsCIvVJATo8zR3gXQJysmGqBHrIAOaHLHJGxM pCHAN0dl6+vGqBKIZseTlugnU1Qd+40ykZzSh9aOEBd8H1wDpKq++iWkCvvrKSFL vseNHB63h7LD4odADVRcQc9uCbRLfGRd+wPtPMw+9jPxt6QzaV5pmTyPwKdNWRiF +0gE83rla9XNGpbq/VoLiwtShjMcRFsR6TYbmydfZvGum1TBDLeZDltrJunqOgX3 shs25HTt7cQRs6AP+wYPciNWhXKUy9xrLskQCSw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-transfer-encoding,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:lmL6gQqKZQSmUe7cC6wzm6Ps82i2lmjovLO7dhUrS/s=:w0ggjq6I/XXbHR0zS8tnrBfiWpgxIQRt/7sxrjM/4G4=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEBZQxQOvt8UiBAEprFZdlC8N3sasoObC5yyrRcViWdd1no+hwMz5vd/VH62K+5h/ mWiWnUnhg10vQA3hDEtmCyFK4JRUSU/JuRYWgxyEiW0vZihpbJHKbuBP7w72JVsJXvRwGx zQqhJUXOxvbBNJaPYhToUx+TVHIeZ6RAgbmwzBJuIae0pP1T/9bLzqKSYmoYul574iw1f3 0Oa2iai3P3D97WfO+6wMu/0AWvLyMjmwOVnbwYTy1rQkuiNMK5zIoODZ46+RuNvHrZdQwp FbdLn311Hfm3yB0t3swBNlbVznGxqzQIytmX5cu6hNnJRMbDsS5zUpOhxyoqNXbqV03LH6 h2Bm6APrQ7At/9wOC1GTvPu8GGrUiIZaJB0yLfMNzm7l+e08PTN72sRWFRPuBkLlxFABAN 6Muy/v3Jbt2tWPvOpNunnTdJguA/W8hPcwefuPdNPqlrGD6tRX1we3BqMBM1Wh4uNPxmW5 pRAl07e9iPBhsznmE4izXOesA/0KxvZBRS2olVL8sa/CTk+9qIWqqWR9ei3z5e68xanVye UlReblfGerysOPxuQHCFzirTz0gKrzG6JQsr61/sB1jtmsXIjrgXW+Vob2aXFY6hn4ZylK b1410rGdkoQX0RBQPxWEsvLjAtGQWdNxChG0/pvdoiyZSkzn9SB7aP04KNWQ X-ME-Proxy: Feedback-ID: ib53e4b78:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Nov 2026 07:13:28 -0500 (EST) From: Ian Bridges To: linkinjeon@kernel.org Cc: senozhatsky@chromium.org, tom@talpey.com, chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Bridges Subject: Re: [PATCH v2 0/2] ksmbd: exclude metadata-only opens from sharing checks Date: Fri, 6 Nov 2026 06:13:16 -0600 Message-ID: <20261106121316.979438-1-icb@fastmail.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: <20261106035345.728454-1-icb@fastmail.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Namjae, Both issues are older than this series. A test that runs smb2_open() on the base and on v2 gives the same results for each. The first is about the earlier open. When an open overwrites or supersedes the file, or creates a named stream, without asking for FILE_WRITE_DATA, a later open that does not share write is still checked only against the earlier open's requested access. So it is not refused, also in the window before the earlier open truncates. v2 counts the implied write for the new open, which is the case you reported on v1. For the earlier open, v2 uses the implied write only to decide whether the pair is checked. The second is about attribute-only stream opens. Such an open that creates or overwrites a named stream is still skipped against opens that are not attribute-only, as before. The series keeps that rule unchanged. In the stream delete check, the base already refused every stream open without FILE_SHARE_DELETE, so patch 2 gives this open the same result as before. So both look like real bugs, but they are separate from what this series changes. I'd argue that they should be dealt with in separate patches. But if you prefer, I can look into addressing them as part of this patch series. I suspect the fixes won't be small, though. Thanks, Ian