mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Andre Gilerson <andre.gilerson@gmail.com>,
	Dan Scally <dan.scally@ideasonboard.com>
Cc: Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	German Pablo Lindo <germanpapulindez@gmail.com>,
	George Neacsu <geocausa@gmail.com>,
	sashiko-bot@kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v10 0/3] Add support for the Sony IMX681 camera sensor
Date: Fri, 06 Nov 2026 12:45:21 +0000	[thread overview]
Message-ID: <20261106124505.71429-1-lsa.uz@pm.me> (raw)

The Sony IMX681 is the user-facing camera on the Microsoft Surface Pro 11
for Business (Intel Lunar Lake, IPU7), ACPI device SONY0681. Without a
driver the camera does not appear at all.

  1/3  dt-bindings: media: Add Sony IMX681        (mine)
  2/3  media: i2c: Add Sony IMX681 sensor driver  (Andre's, co-developed)
  3/3  media: ipu-bridge: Add Sony IMX681         (mine)

The driver is Andre's, reverse-engineered from I2C traces taken under
Windows.

Changes in v10
==============

- 2/3: hold a runtime PM reference across probe. Setting the autosuspend
  delay with the usage count at 0 suspended the sensor in the middle of
  probe, and a later failure then powered it off a second time. Found by
  Sashiko on v9 2/3 and 3/3.
- All three: the Assisted-by tags are dropped; see the end of this letter.

1/3 and 3/3 are otherwise unchanged. The review and test tags are kept,
German's Tested-by on 2/3 too: the change is limited to probe's runtime
PM and its error path, both tested below.

While this sensor streams, IPU7's CSI-2 receiver logs "Received packet is
too long" once per frame, and the frames are complete. Andre sees the same
with his downstream driver, so it does not come from this series.

Tested with v10 on the Surface Pro 11 for Business, on v7.4-rc1 with [1],
[2] and [3] applied, KASAN and lockdep on:
- after probe the sensor stays active and suspends about 1 s later;
  v9 was already suspended when probe returned;
- probe forced to fail after the runtime PM setup and at registration,
  with a test-only parameter: no clock or regulator warning, where v9
  gives three per failure (clock already disabled and unprepared,
  unbalanced regulator disable);
- v4l2-compliance 46 of 46, no warnings;
- 3844x2640 at 30.01 fps;
- the four flip states give the four Bayer orders, and EBUSY while
  streaming;
- runtime suspend after streaming, and capture after unbind and bind and
  after five module reloads;
- no KASAN or lockdep report;
- W=1 and sparse clean on x86_64, on i386 and without CONFIG_PM;
  dt_binding_check clean.

Tool use, per Documentation/process/generated-content.rst (Assisted-by
tags in commits were dropped in 7.4-rc1):

* My contributions to this series were prepared with Claude Code
  (claude-opus-5-5); work by others in it is their own.
* This replaces any Assisted-by tags in earlier versions.

[1] https://lore.kernel.org/all/20261103103235.94397-1-lsa.uz@pm.me/
[2] https://lore.kernel.org/all/20251208035122.2147678-1-hao.yao@intel.com/
[3] https://lore.kernel.org/all/20261026082549.662885-2-dmanresa@gmail.com/
v9: https://lore.kernel.org/all/20261106041116.78937-1-lsa.uz@pm.me/

Andre Gilerson (1):
  media: i2c: Add Sony IMX681 sensor driver

Sergey Lebedev (2):
  dt-bindings: media: Add Sony IMX681
  media: ipu-bridge: Add Sony IMX681

 .../bindings/media/i2c/sony,imx681.yaml       |  108 ++
 MAINTAINERS                                   |    8 +
 drivers/media/i2c/Kconfig                     |   10 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/imx681.c                    | 1034 +++++++++++++++++
 drivers/media/pci/intel/ipu-bridge.c          |    2 +
 6 files changed, 1163 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx681.yaml
 create mode 100644 drivers/media/i2c/imx681.c


base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
-- 
2.54.0



             reply	other threads:[~2026-11-06 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 12:45 Sergey Lebedev [this message]
2026-11-06 12:45 ` [PATCH v10 1/3] dt-bindings: media: Add Sony IMX681 Sergey Lebedev
2026-11-06 12:45 ` [PATCH v10 2/3] media: i2c: Add Sony IMX681 sensor driver Sergey Lebedev
2026-11-06 12:45 ` [PATCH v10 3/3] media: ipu-bridge: Add Sony IMX681 Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106124505.71429-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=andre.gilerson@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geocausa@gmail.com \
    --cc=germanpapulindez@gmail.com \
    --cc=hansg@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sashiko-bot@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®