From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.251 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793975049; b=PPsllljcJRErBKt5wmAfzxEXX4g9tCVn0dU0CeGG559Y8r7jdkBA2C1HKsELUX8z6mSN MR7Ov5IgxWQByZTN5OmZC2W2aOerOLSZxh7CUDS7IPDj7I9MW5sBP9naG1+L6AZLNEd2D lewTkqgTCWCUoYUDNhPwDP5Sh6wxm1k47fuSvIjIlHLxwqKQkn7t/UzqCJSEBzJVxk3MS QMvlTqbEBFXmHCNi+rkbPhGGhtrArGwoZKAwqgfSI+rbM9Q6vfscSuNEuJiM6/kDOLHM/ lwBwweeeib73Ms244tp0b3jHKSuYCFmCni58BtdDutZZ/OaiRWtW8uX69LMIueBEpOQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793975049; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=FDwokMf0fA4W0W7A8ZvQB92/NrvFGDKE4aBnwQYX4XY=; b=it3jVwBZQVS8kERWDRBs9hcC7lKmSH57Ebnn34Kp+cgtLz27irHU/YqIOyzbnwhCXoFV UxlTfd6EYMz+JQj/3g1ExNKOk9qFORbUg/hxIp2AAlN6/9LGw37qe5G85bQymHs4fDJYS B2+qXLCGPHiWFQzhRPTzBZrwwxwR0abKDHTpr9PsKjMpp+HPGKziohHa3Cgtg4Hkb7ch5 bitj1alBopF2QWeXNo4KiwK/6p0ODZz6xHLTnLyGalmyxJdhiF1h45cx+QSLh0OOhVlyR EByRVRLv/Oq0JfJ4hpHUv0+wfB0QinHc92ei7uRR/+o8ywIqKEQZWHIq4A+NOt3uLGQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=bmdnVO2I; arc=none smtp.remote-ip=95.215.58.251 Received: from mta1.migadu.com (out-251.mta1.migadu.com [95.215.58.251]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AE5E606A336 for ; Fri, 6 Nov 2026 14:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8AE5E606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=bmdnVO2I X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=8MPXuYxogjoz6C0i6TmKjfYrt89befSO0ZHv1GETSrQ=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793975046; v=1; x=1794579846; b=bmdnVO2IUYeUrZs5DZ4AgcMTd218/3fUP/ltO6lLk1WGdtOSVNTDed7zdN0AjRK3eqTc2Dmr kE3Mh3vOgPgJltkpJNVcIgpOr/LQ3blOtFxiKCD078bQJBjy+jNkaY62v+7CEsgJnGp5DAMXHKP PZ9tWQ0/fIvS+W6cZf0J0pf0= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id ad92e567a64aa571; Fri, 06 Nov 2026 14:24:06 +0000 X-Mizu-Trace-ID: ad92e567a64aa571 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: linux-input@vger.kernel.org, kernel@lists.opengamingcollective.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schyboll" , "Denis Benato" , Denis Benato Subject: [PATCH v14 04/18] HID: asus: add vibration strength configuration Date: Fri, 6 Nov 2026 14:23:20 +0000 Message-ID: <20261106142334.1881-5-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106142334.1881-1-denis.benato@linux.dev> References: <20261106142334.1881-1-denis.benato@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ASUS ROG Ally handhelds support the vibration strength to be configured: add sysfs attributes to allow userspace configure motors vibration intensity. Signed-off-by: Denis Benato Co-developed-by: Luke Jones Signed-off-by: Luke Jones --- drivers/hid/hid-asus.c | 171 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 171 insertions(+) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 3971fb7d1589..09b1ec4bae25 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -98,6 +98,9 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define ASUS_HID_INPUT_KBD_REPORT_ID 0x01 +#define ASUS_ALLY_VIBRATION_INTENSITY_MIN 0 +#define ASUS_ALLY_VIBRATION_INTENSITY_MAX 100 + /* Spurious HID codes sent by QUIRK_ROG_NKEY_KEYBOARD devices */ #define ASUS_SPURIOUS_CODE_0XEA 0xea #define ASUS_SPURIOUS_CODE_0XEC 0xec @@ -823,6 +826,9 @@ static struct ally_prefs { bool xbox_controller_enabled; u8 gamepad_mode; + + u8 vibration_intensity_left; + u8 vibration_intensity_right; } ally_prefs = { .lock = __MUTEX_INITIALIZER(ally_prefs.lock), }; @@ -992,6 +998,149 @@ static ssize_t xbox_controller_store(struct device *dev, static DEVICE_ATTR_RW(xbox_controller); +/** + * ally_set_vibration_intensity() - Set the gamepad vibration intensity + * @hdev: HID device the command packet is sent on + * @left: left motor intensity + * @right: right motor intensity + * + * Context: Caller holds ally_prefs.lock. + * Return: 0 on success, negative errno on failure. + */ +static int ally_set_vibration_intensity(struct hid_device *hdev, u8 left, u8 right) +{ + const u8 data[] = { left, right }; + size_t buf_len; + int ret; + + u8 *buf __free(kfree) = ally_alloc_cmd(hdev, CMD_SET_VIBRATION_INTENSITY, + data, sizeof(data), &buf_len); + + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(hdev, buf, buf_len); + if (ret < 0) { + hid_err(hdev, "Failed to set vibration intensity: %d\n", ret); + return ret; + } + + return 0; +} + +static void ally_vibration_defaults(void) +{ + guard(mutex)(&ally_prefs.lock); + + if (ally_prefs.initialized) + return; + + ally_prefs.vibration_intensity_left = 100; + ally_prefs.vibration_intensity_right = 100; +} + +/* Indices into ally_vibration[], in the order ally_set_vibration_intensity() takes them. */ +enum ally_vibration { + ALLY_VIBRATION_LEFT, + ALLY_VIBRATION_RIGHT, +}; + +static u8 *const ally_vibration[] = { + [ALLY_VIBRATION_LEFT] = &ally_prefs.vibration_intensity_left, + [ALLY_VIBRATION_RIGHT] = &ally_prefs.vibration_intensity_right, +}; + +static ssize_t ally_vibration_intensity_show(char *buf, enum ally_vibration which) +{ + guard(mutex)(&ally_prefs.lock); + + return sysfs_emit(buf, "%u\n", *ally_vibration[which]); +} + +static ssize_t ally_vibration_intensity_store(struct device *dev, const char *buf, + size_t count, enum ally_vibration which, + const char *group) +{ + u8 value, v[ARRAY_SIZE(ally_vibration)]; + struct hid_device *hdev = to_hid_device(dev); + size_t i; + int ret; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > ASUS_ALLY_VIBRATION_INTENSITY_MAX) + return -EINVAL; + + scoped_guard(mutex, &ally_prefs.lock) { + for (i = 0; i < ARRAY_SIZE(v); i++) + v[i] = *ally_vibration[i]; + v[which] = value; + + ret = ally_set_vibration_intensity(hdev, + v[ALLY_VIBRATION_LEFT], + v[ALLY_VIBRATION_RIGHT]); + if (ret < 0) + return ret; + + *ally_vibration[which] = value; + } + + sysfs_notify(&dev->kobj, group, "intensity"); + + return count; +} + +/* Generates _vibration_intensity_{show,store,range_show}. */ +#define ALLY_VIBRATION_FUNCS(side, SIDE) \ +static ssize_t side##_vibration_intensity_show(struct device *dev, \ + struct device_attribute *attr, \ + char *buf) \ +{ \ + return ally_vibration_intensity_show(buf, ALLY_VIBRATION_##SIDE); \ +} \ + \ +static ssize_t side##_vibration_intensity_store(struct device *dev, \ + struct device_attribute *attr, \ + const char *buf, size_t count) \ +{ \ + return ally_vibration_intensity_store(dev, buf, count, ALLY_VIBRATION_##SIDE, \ + #side "_vibration"); \ +} \ + \ +static ssize_t side##_vibration_intensity_range_show(struct device *dev, \ + struct device_attribute *attr, \ + char *buf) \ +{ \ + return sysfs_emit(buf, "%u %u\n", ASUS_ALLY_VIBRATION_INTENSITY_MIN, \ + ASUS_ALLY_VIBRATION_INTENSITY_MAX); \ +} + +ALLY_VIBRATION_FUNCS(left, LEFT) +ALLY_VIBRATION_FUNCS(right, RIGHT) + +static struct device_attribute dev_attr_left_vibration_intensity = + __ATTR(intensity, 0644, left_vibration_intensity_show, left_vibration_intensity_store); + +static struct device_attribute dev_attr_left_vibration_intensity_range = + __ATTR(intensity_range, 0444, left_vibration_intensity_range_show, NULL); + +static struct device_attribute dev_attr_right_vibration_intensity = + __ATTR(intensity, 0644, right_vibration_intensity_show, right_vibration_intensity_store); + +static struct device_attribute dev_attr_right_vibration_intensity_range = + __ATTR(intensity_range, 0444, right_vibration_intensity_range_show, NULL); + +static struct attribute *ally_left_vibration_attrs[] = { + &dev_attr_left_vibration_intensity.attr, + &dev_attr_left_vibration_intensity_range.attr, + NULL +}; + +static struct attribute *ally_right_vibration_attrs[] = { + &dev_attr_right_vibration_intensity.attr, + &dev_attr_right_vibration_intensity_range.attr, + NULL +}; + static struct attribute *ally_config_attrs[] = { &dev_attr_xbox_controller.attr, NULL @@ -1001,6 +1150,14 @@ static const struct attribute_group ally_attr_groups[] = { { .attrs = ally_config_attrs, }, + { + .name = "left_vibration", + .attrs = ally_left_vibration_attrs, + }, + { + .name = "right_vibration", + .attrs = ally_right_vibration_attrs, + }, }; static int ally_prefs_setup(struct hid_device *hdev, struct ally_intf *intf) @@ -1013,6 +1170,8 @@ static int ally_prefs_setup(struct hid_device *hdev, struct ally_intf *intf) return ret; } + ally_vibration_defaults(); + scoped_guard(mutex, &ally_prefs.lock) { if (!ally_prefs.initialized) { ally_prefs.gamepad_mode = 0x01; @@ -1264,6 +1423,18 @@ static int hid_asus_ally_init(struct hid_device *hdev) hid_warn(hdev, "Failed to apply Xbox controller mode: %d\n", ret); } + /* + * The MCU does not keep the vibration intensity across a reset: + * send the recorded values again. + */ + if (ally_prefs.initialized) { + ret = ally_set_vibration_intensity(hdev, + ally_prefs.vibration_intensity_left, + ally_prefs.vibration_intensity_right); + if (ret < 0) + hid_warn(hdev, "Failed to restore vibration intensity: %d\n", ret); + } + return 0; } -- 2.47.3