From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793978600; b=D4hInTLgheNxEpM2TrJrLm+djcJyOgeRVutzrj1MwPzm2zAU2c6hp342P1TN8PTDHg8y G+KESiV938t87/1G77q/wUA09pxkcEuY9ZQ4ervuTJVnxArrMVu/O4ptKiC6hlX0xNbIg sdDHQp9cvwguLdglNESVuE4Z+Qpnk9eMgot2/bHxeKk/L+ctCYJHqoNbsyqPqP0VeSGaG I2JuO1gBxRV8YTMAlgD+l4t9KQkbnKiC5RZiGObiRjTGqbqs8LPFx5vIepYwSOACCq4Vh qqXEP4zDot3yVbKQGvG3PUnTPRBbBD0LYBoqh4qRflXKlLGE2iEUEVQg1Lc0ecxjpSg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793978600; h=DMARC-Filter:Received:DKIM-Signature:Received:Received:Received: Received:Received:Received:Received:From:To:Cc:Subject:Date: Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-TM-AS-GCONF:X-Authority-Analysis: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=pIUB20LfLYCQ6CluXH50BwJOGenh0+Gv/aR6ZRYkcC0=; b=zAH+uvOwuIvnDkRyjFmOQcvX3krZ1DGVcdJPb19O7qDCjwl+arDsplFO5hvu55630Eg3 d+waf9Ndhp6VsZZ0ippibtYwRap/F/Yj+XJMP94OS62P9vBWVZPlrBL7HF9Y4scg5QYWk IXTPmMISqb5fqEj9++jcmNiyfF5s3NULO2o5tuTllAAs3igDdB7jj5kOcMzYOZSB/qF2A 0Wcpewdv+GOldFvB9cvAQc2LUhF8e2BUgXPIJkk9Vs9vCyenvNa04/kMHAFgXmDl6iZE/ M99bydvDlWO/vZQUTCsC6ueURXVF9fMq3WCHiS+mTSLcXoiNDIeZk2GROv/Yr52ykMA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dn2uEGMe; arc=none smtp.remote-ip=148.163.156.1 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E528606EE99; Fri, 6 Nov 2026 15:23:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7E528606EE99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dn2uEGMe Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A6FE6qd1094508; Fri, 6 Nov 2026 15:23:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=pIUB20LfLYCQ6CluX H50BwJOGenh0+Gv/aR6ZRYkcC0=; b=dn2uEGMe+tHazsf998fXD62kzzw+bjrK1 HEc61uKIu9padewoVO9pkgwfK4WyfPfgBbDdxU5RWRykeQFpcNqXgIMrGN5BTLKX IE2tZli1uP/ZWvfx8pW/lEUDdDUvgVMoZKWRQ5DkMr2ZVB2qhUtaFprS4jEdxJYj O2HnP6ecuKIrKemRkNCNfXG4atMuduSolrjMXU+jX9YgekbcJwM/s9lqqmK9CN12 v3CA5CtdEloENJmESTmX2vwU3xhNMBy7ZjxJ4cFNwsGO/18IBL4T52RB/HJJ+aah 2rNF2dQHC+hlJm0/iaJaPd6T9HuNyIaIwhjKdHpNewZwdlIsB8A3g== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4hs3raw77t-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 06 Nov 2026 15:23:13 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 6A6F4teR2390103; Fri, 6 Nov 2026 15:23:12 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4hs7h13m0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Nov 2026 15:23:12 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6A6FNBjJ11666058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Nov 2026 15:23:12 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 94AEB5804E; Fri, 6 Nov 2026 15:23:11 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E23BD58067; Fri, 6 Nov 2026 15:23:09 +0000 (GMT) Received: from li-4c4c4544-004d-4810-8043-b7c04f423534.ibm.com.com (unknown [9.61.114.69]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 6 Nov 2026 15:23:09 +0000 (GMT) From: Anthony Krowiak To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jjherne@linux.ibm.com, borntraeger@de.ibm.com, mjrosato@linux.ibm.com, pasic@linux.ibm.com, alex@shazbot.org, kwankhede@nvidia.com, fiuczy@linux.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, agordeev@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com Subject: [PATCH v12 05/14] s390/vfio-ap: Callback to get/set vfio device mig state during guest migration Date: Fri, 6 Nov 2026 10:22:50 -0500 Message-ID: <20261106152259.1360651-6-akrowiak@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261106152259.1360651-1-akrowiak@linux.ibm.com> References: <20261106152259.1360651-1-akrowiak@linux.ibm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=QYDzLcbv c=1 sm=1 tr=0 ts=6aedf0e1 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=zJRp6_cAMcgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=34fSTTD2jMTnGACibWkA:9 X-Proofpoint-GUID: v6lxorvCcd5W2hY14oourBlMoqoF0-9U X-Proofpoint-ORIG-GUID: v6lxorvCcd5W2hY14oourBlMoqoF0-9U X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA2MDA2MCBTYWx0ZWRfX5/uuOYekOzxj Oz7sSnA3KF0RA/FM3MmVIipVhfjEfBjIe+CKiqQAksewwdR50Kp1YlxOPjgkYavRfnqbQTJzgOO 9f1+7ruysMi4aU73Fp+P4u8B9TdZtL0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA2MDA2MCBTYWx0ZWRfXyO7oVbJirTjF /kXecVLaqkLn0yzsYV86JXH+SzM/6//7EnsYeNdL61Hr7rJozOuCOGwZ7ivq7QGRvcdJR9/Z4pc yPY1zsz3lFOSX4AOCj4iaHQX19+N1HmmZPXyMTxwsnAb6Ow7Kl84ozz1ObIj9WY4btEPNXRDWou eQFUdXIdGz5nEftzknQaoBk4kT3leCS/NKx5iPFG3ZOTRXe14svdsUlYuif+6V/4i7EnhBydTIH K7aIrKKmFeoF8BIr5sjZhPkp8A62TwtwlEyjps27MaIm0+J/Ol5Ipjek3rnUR5LH2Grql4ewWCM G6JtQ/2qyaVNOJudmliYRr6Uo/OeK2ZuEhFDyiGPox5d7cw4cBAYQROaD5BhJLaVzy3fXw/6hjI 0mJEUQIBJivdF38rNDJk4gWvQCrXUz5NBdMr8w3ukS3CzqXgd2zBhyWbTkKjleBkMsHLJZWDEAb BXMdMbN9ysbdYE6fCGg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-06_05,2026-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611060060 Implements two callbacks related to the current state of a vfio-ap device: * The callback that sets a new migration state of a vfio-ap device during live migration of guests with pass-through access to AP devices. This callback is mandatory for VFIO_DEVICE_FEATURE_MIGRATION support. The function pointer for this callback is specified via the 'migration_set_state' field of the 'vfio_migration_ops' structure which is stored with the VFIO device when the 'vfio_device' structure representing the mediated device is initialized. * The callback that returns the current vfio device migration state during live migration of guests with pass-through access to AP devices. The function pointer for this callback is specified via the 'migration_get_state' field of the 'vfio_migration_ops' structure which is stored with the VFIO device when the 'vfio_device' structure representing the mediated device is initialized. Signed-off-by: Anthony Krowiak --- drivers/s390/crypto/vfio_ap_migration.c | 144 ++++++++++++++++++++++++ 1 file changed, 144 insertions(+) diff --git a/drivers/s390/crypto/vfio_ap_migration.c b/drivers/s390/crypto/vfio_ap_migration.c index 94772cab1e85..df012f80ed0d 100644 --- a/drivers/s390/crypto/vfio_ap_migration.c +++ b/drivers/s390/crypto/vfio_ap_migration.c @@ -143,6 +143,150 @@ static void vfio_ap_release_resuming_file(struct vfio_ap_migration_data *mig_dat mig_data->resuming_mig_data_complete = false; } +static struct file * +vfio_ap_transition_to_state(struct ap_matrix_mdev *matrix_mdev, + enum vfio_device_mig_state new_state) +{ + struct vfio_ap_migration_data *mig_data; + enum vfio_device_mig_state cur_state; + + lockdep_assert_held(&matrix_dev->mdevs_lock); + mig_data = matrix_mdev->mig_data; + cur_state = mig_data->mig_state; + dev_dbg(matrix_mdev->vdev.dev, "%s: %d -> %d\n", __func__, cur_state, + new_state); + + if (cur_state == VFIO_DEVICE_STATE_STOP && + new_state == VFIO_DEVICE_STATE_STOP_COPY) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if (cur_state == VFIO_DEVICE_STATE_STOP && + new_state == VFIO_DEVICE_STATE_RESUMING) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if ((cur_state == VFIO_DEVICE_STATE_RESUMING && + new_state == VFIO_DEVICE_STATE_STOP) || + (cur_state == VFIO_DEVICE_STATE_STOP_COPY && + new_state == VFIO_DEVICE_STATE_STOP)) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if ((cur_state == VFIO_DEVICE_STATE_STOP && + new_state == VFIO_DEVICE_STATE_RUNNING) || + (cur_state == VFIO_DEVICE_STATE_RUNNING && + new_state == VFIO_DEVICE_STATE_STOP)) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + /* vfio_mig_get_next_state() does not use arcs other than the above */ + WARN_ON(true); + + return ERR_PTR(-EINVAL); +} + +static struct file *vfio_ap_set_state(struct vfio_device *vdev, + enum vfio_device_mig_state new_state) +{ + int ret; + struct file *filp = NULL; + struct ap_matrix_mdev *matrix_mdev; + enum vfio_device_mig_state next_state; + struct vfio_ap_migration_data *mig_data; + + mutex_lock(&matrix_dev->mdevs_lock); + + matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev); + mig_data = matrix_mdev->mig_data; + + /* + * The mig_data pointer is set in the vfio_ap_init_migration_data + * function which is called when the vfio-ap device fd is opened. + * Since the implicit pre-open state is RUNNING, a request to set + * RUNNING is a no-op. Any other state transition is invalid before + * open_device. + */ + if (!mig_data) { + mutex_unlock(&matrix_dev->mdevs_lock); + if (new_state == VFIO_DEVICE_STATE_RUNNING) + return NULL; + return ERR_PTR(-ENODEV); + } + + dev_dbg(vdev->dev, "%s -> %d\n", __func__, new_state); + + while (mig_data->mig_state != new_state) { + ret = vfio_mig_get_next_state(vdev, mig_data->mig_state, + new_state, &next_state); + if (ret) { + filp = ERR_PTR(ret); + break; + } + + filp = vfio_ap_transition_to_state(matrix_mdev, next_state); + if (IS_ERR(filp)) + break; + + mig_data->mig_state = next_state; + + if (WARN_ON(filp && new_state != next_state)) { + fput(filp); + filp = ERR_PTR(-EINVAL); + break; + } + } + + if (mig_data->mig_state == VFIO_DEVICE_STATE_ERROR) + filp = ERR_PTR(-EIO); + + mutex_unlock(&matrix_dev->mdevs_lock); + + return filp; +} + +static int vfio_ap_get_state(struct vfio_device *vdev, + enum vfio_device_mig_state *current_state) +{ + struct ap_matrix_mdev *matrix_mdev; + struct vfio_ap_migration_data *mig_data; + + mutex_lock(&matrix_dev->mdevs_lock); + + matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev); + mig_data = matrix_mdev->mig_data; + + /* + * The mig_data pointer is set in the vfio_ap_init_migration_data + * function which is called when the vfio-ap device fd is opened. + * If mig_data is NULL, report RUNNING as the implicit pre-open state + * so userspace doesn't need to perform any state transition before the + * device becomes active. + */ + *current_state = (mig_data) ? mig_data->mig_state : + VFIO_DEVICE_STATE_RUNNING; + + mutex_unlock(&matrix_dev->mdevs_lock); + + return 0; +} + +static int vfio_ap_get_data_size(struct vfio_device *vdev, + unsigned long *stop_copy_length) +{ + return -EOPNOTSUPP; +} + +static const struct vfio_migration_ops vfio_ap_migration_ops = { + .migration_set_state = vfio_ap_set_state, + .migration_get_state = vfio_ap_get_state, + .migration_get_data_size = vfio_ap_get_data_size, +}; + /** * vfio_ap_init_migration_data - initialize migration data and functions * -- 2.53.0