From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793978960; b=O3vGaNYPyb0bgTbshvc8Uldd3FbfTzEgciH8h5wgDvEI9iALXgr45oIUKyDnPK2GYOvZ lPTYyUdR8XlpKJNhFH+h6dKX4msNM/DfwKrytw1mNNndNbExkD2X/mls77Sk/52eBq0N6 tzBMqqUO+8Qj2igwxK0JAWQsq6ptHbnsTiAcjiNtz2bGUXILHp58crwh3+Cre81kUVAQW HfsOqxeb3cuk35vth0vhcarIpsZ7jtVMU17YuGpsULLG7MksgRajOVUsTgPksyuWOrOY3 r2/wUrM2bsuLIRoKl/MXiLMNaZggauR0Qj/E8VKGeB4KuIMxjnko6kG/T+GX9251GPg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793978960; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=48rljzKvoUg9v4zCJJmQB8ccTlJM08PmCKtx6YIOPJA=; b=Efu9rfpPWHOJgRG3Mg5VBZQ9/41LpP+EyiLcf3syaXc3us873BAdGgTf1SlbKBigjrQk zAR1y8G21qLr7c93cNlpkEzRejW/kJxlSWm3ShnPObpkbxaW6v/lojgWCnKJXUdcGamsi vnBlyEAg+nIWUGgw+WSgdT32Bpm8tnUw/OueRmGioN97S8QIjIZEBXNJo2MWWmtCdTSMK lF7+2pZWz4dViHFvWcX7vVAoHccJwJQSg6q90gDdyFoI2Nbge6RqcYYh/Rh5aZT/CgjCA uZAF0zGUDrJZ3jMr+LBiHrE68p4q2kV0EoTbIFXpSZpR/7zqRH3YJpAAwuDt2U6rBQQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=A8ZjbSwH; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685E0606A326; Fri, 6 Nov 2026 15:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=A8ZjbSwH Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF2081F0089F; Fri, 6 Nov 2026 15:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793978960; bh=48rljzKvoUg9v4zCJJmQB8ccTlJM08PmCKtx6YIOPJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=A8ZjbSwHU20MhVdWCWsRQ+KFXa54YccwjaujcZwWf33hDNUgV4Arp04bJGZXtVcoz etXQZtX2+GCWQmeJ8OGC/LEBOLsWftUfVIXKPUKIw9vZhMWl1i+DUCNVni8kio35pl NlX+mGPl+MloBvZj4CoMuGUPahCxH7sCrcE7YdiZ9Vs6nxOnX+mXtuVSyufdxHjx3V PIB5RlZU7/uXUot8EW8HI6ICST0+oPGA/ZupU54YiE6A94Nat8GHhbXxJxH7g1CISb zqUo4ETB4NsLXuDG+zSPSxPWr/jNc3l12jX+zb54sH+JdI2qq3FUa2vbf0nBsiQTuf Kh4dq4meZu8sw== Date: Fri, 6 Nov 2026 09:29:15 -0600 From: Rob Herring To: Damon Ding Cc: Krzysztof Kozlowski , Sandy Huang , Heiko Stuebner , Andy Yan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Andrzej Hajda , Robert Foss , Neil Armstrong , Manivannan Sadhasivam , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dave Jones , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v4 2/6] dt-bindings: phy: Add rockchip,rk3568-edp-phy Message-ID: <20261106152915.GA3406543-robh@kernel.org> References: <20261030064905.2248999-1-damon.ding@rock-chips.com> <20261030064905.2248999-3-damon.ding@rock-chips.com> <20261103-lemon-guillemot-of-economy-eefbbd@quoll> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 04, 2026 at 04:59:58PM +0800, Damon Ding wrote: > Hi Krzysztof, > > On 11/3/2026 7:20 PM, Krzysztof Kozlowski wrote: > > On Fri, Oct 30, 2026 at 02:49:01PM +0800, Damon Ding wrote: > > > Document the eDP transmitter PHY with NaNeng IP block found on the > > > RK3568 SoC. The PHY has its own register window inside the eDP PHY > > > GRF, so its node is modeled as a child of the eDP PHY GRF syscon with > > > a reg property describing that window. Also add the > > > "rockchip,rk3568-edp-phy-grf" compatible and the phy node reference to > > > the Rockchip GRF schema. > > > > > > Signed-off-by: Damon Ding > > > > > > --- > > > > > > Changes in v4: > > > - Add the reg entry for the PHY node and the ranges/#address-cells/ > > > #size-cells for the parent syscon node. > > > --- > > > .../bindings/phy/rockchip,rk3568-edp-phy.yaml | 68 +++++++++++++++++++ > > > .../devicetree/bindings/soc/rockchip/grf.yaml | 20 ++++++ > > > 2 files changed, 88 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml > > > new file mode 100644 > > > index 000000000000..b78da00ffefd > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml > > > @@ -0,0 +1,68 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/phy/rockchip,rk3568-edp-phy.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Rockchip eDP Transmitter PHY with NaNeng IP block > > > + > > > +maintainers: > > > + - Damon Ding > > > + - Heiko Stuebner > > > + > > > +description: > > > + On the RK3568 SoC the eDP PHY is controlled through the eDP PHY GRF > > > + registers, therefore the PHY node is expected to be a child of the > > > + eDP PHY GRF syscon node. > > > + > > > +properties: > > > + compatible: > > > + const: rockchip,rk3568-edp-phy > > > + > > > + reg: > > > + maxItems: 1 > > > + description: PHY registers within the eDP PHY GRF. > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + const: refclk > > > > Just "ref" > > Will fix in v5. > > > > > > + > > > + "#phy-cells": > > > + const: 0 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - "#phy-cells" > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + #include > > > + > > > + soc { > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + > > > + edp_phy_grf: syscon@fdcb0000 { > > > + compatible = "rockchip,rk3568-edp-phy-grf", "syscon", "simple-mfd"; > > > > This is beyond the scope of this binding. Drop entire node. > > Will Drop in v5. The example should only show the PHY node itself. Actually, drop the whole thing and put in GRF binding if you want an example. MFD examples should be complete, not piecemeal with each sub-device. Rob