mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Donnefort <vdonnefort@google.com>
To: rostedt@goodmis.org, mhiramat@kernel.org,
	 linux-trace-kernel@vger.kernel.org
Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com,
	 linux-kernel@vger.kernel.org,
	Vincent Donnefort <vdonnefort@google.com>
Subject: [PATCH v8 18/21] tracing/remotes: Add poll_ms tracefs file
Date: Fri,  6 Nov 2026 18:06:54 +0000	[thread overview]
Message-ID: <20261106180657.2460376-19-vdonnefort@google.com> (raw)
In-Reply-To: <20261106180657.2460376-1-vdonnefort@google.com>

Add a tracefs file to configure the trace remote polling period. Keep
the default value to 100ms.

Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
---
 kernel/trace/trace_remote.c | 44 +++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/kernel/trace/trace_remote.c b/kernel/trace/trace_remote.c
index 2946f263c79c..ebfc2dd67b79 100644
--- a/kernel/trace/trace_remote.c
+++ b/kernel/trace/trace_remote.c
@@ -1137,6 +1137,46 @@ static int dump_on_panic_show(struct seq_file *s, void *unused)
 }
 DEFINE_TRACE_REMOTE_ATTRIBUTE(dump_on_panic);
 
+static ssize_t poll_ms_write(struct file *filp, const char __user *ubuf, size_t cnt, loff_t *ppos)
+{
+	struct seq_file *seq = filp->private_data;
+	struct trace_remote *remote = seq->private;
+	unsigned int val;
+	int ret;
+
+	ret = kstrtouint_from_user(ubuf, cnt, 10, &val);
+	if (ret)
+		return ret;
+
+	if (!val)
+		return -EINVAL;
+
+	guard(mutex)(&remote->lock);
+
+	if (val == remote->poll_ms)
+		return cnt;
+
+	if (remote->poll_cnt)
+		cancel_delayed_work_sync(&remote->poll_work);
+
+	WRITE_ONCE(remote->poll_ms, val);
+
+	if (remote->poll_cnt)
+		schedule_delayed_work(&remote->poll_work, msecs_to_jiffies(val));
+
+	return cnt;
+}
+
+static int poll_ms_show(struct seq_file *s, void *unused)
+{
+	struct trace_remote *remote = s->private;
+
+	seq_printf(s, "%u\n", READ_ONCE(remote->poll_ms));
+
+	return 0;
+}
+DEFINE_TRACE_REMOTE_ATTRIBUTE(poll_ms);
+
 static int trace_remote_init_tracefs(const char *name, struct trace_remote *remote)
 {
 	struct dentry *remote_d, *percpu_d, *d;
@@ -1169,6 +1209,10 @@ static int trace_remote_init_tracefs(const char *name, struct trace_remote *remo
 	if (!d)
 		goto err;
 
+	d = trace_create_file("poll_ms", TRACEFS_MODE_WRITE, remote_d, remote, &poll_ms_fops);
+	if (!d)
+		goto err;
+
 	d = trace_create_file("buffer_size_kb", TRACEFS_MODE_WRITE, remote_d, remote,
 			      &buffer_size_kb_fops);
 	if (!d)
-- 
2.56.0.455.g6c5a503b38-goog


  parent reply	other threads:[~2026-11-06 18:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 18:06 [PATCH v8 00/21] tracing/remotes: Add printk, dump_on_panic and boot parameters Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 01/21] tracing/remotes: Gate tracefs files opening on trace remote registration Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 02/21] tracing/remotes: Release tracefs,eventfs on registration failure Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 03/21] tracing/remotes: Use kstrtobool for boolean tracefs files Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 04/21] tracing/remotes: Initialise pos in trace_start() Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 05/21] tracing/remotes: Annotate remote shared fields with READ_ONCE/WRITE_ONCE Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 06/21] tracing/remotes: Use a single per-remote polling work Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 07/21] tracing/simple_ring_buffer: Add support for compressed length Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 08/21] tracing/remotes: Add dmesg tracefs file Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 09/21] tracing/remotes: selftests: Add a test for the " Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 10/21] tracing/remotes: selftests: Prefix hypervisor folder Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 11/21] ring-buffer: Use irqsave for the reader lock in ring_buffer_poll_remote Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 12/21] ring-buffer: Avoid reader_lock deadlock during panic Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 13/21] ring-buffer: Use panic-friendly locking in ring_buffer_iter interface Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 14/21] ring-buffer: Add kerneldoc for ring_buffer_poll_remote Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 15/21] tracing/remotes: Use ring_buffer_capacity() in trace_remote_has_cpu() Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 16/21] tracing/remotes: Add dump_on_panic tracefs file Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 17/21] tracing/remotes: selftests: Add a test for the " Vincent Donnefort
2026-11-06 18:06 ` Vincent Donnefort [this message]
2026-11-06 18:06 ` [PATCH v8 19/21] tracing/remotes: Add trace_remote cmdline options Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 20/21] Documentation: tracing/remotes: Add detailed tracefs layout Vincent Donnefort
2026-11-06 18:06 ` [PATCH v8 21/21] Documentation/kernel-parameters: Add trace_remote Vincent Donnefort

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106180657.2460376-19-vdonnefort@google.com \
    --to=vdonnefort@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®