mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dennis Chen <dechen@redhat.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powercap: intel_rapl: Expose package CPUs in associated_cpus
Date: Fri,  6 Nov 2026 15:16:42 -0500	[thread overview]
Message-ID: <20261106201642.231167-1-dechen@redhat.com> (raw)
In-Reply-To: <d10e4235-dd25-40e6-b682-bf7530ab931d@linux.intel.com>

Hi Kuppuswamy,

On 11/6/2026 11:41 AM, Kuppuswamy Sathyanarayanan wrote:
> Is there a user of associated_cpus? Neither perf nor turbostat reads it
> today. The "any CPU in the package" support that turbostat needed comes
> from commit 7537bae8b6eb ("powercap: intel_rapl: Remove incorrect CPU
> check in PMU context") and from is_rp_pmu_cpu(). Your patch keeps both.
> 
> If there is no consumer, I would prefer a plain revert of 525e0064f3d8.
> It fixes the issue with a smaller diff and does not add new sysfs ABI.

There is no userspace consumer. My idea was to keep the flexibility for 
userspace tools mentioned in the original commit by exposing the full
set in associated_cpus.

In that case, I will send out a v2 as a revert of 525e0064f3d8.

> This has been in since v7.0, so please add Cc: stable@vger.kernel.org.

Will do.

Thanks for the review.

Best,
Dennis Chen


      reply	other threads:[~2026-11-06 20:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 18:30 Dennis Chen
2026-11-06 19:41 ` Kuppuswamy Sathyanarayanan
2026-11-06 20:16   ` Dennis Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106201642.231167-1-dechen@redhat.com \
    --to=dechen@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®