From: Tianyi Gao <tianyi@cloudflare.com>
To: David Keogh <dkeogh@amazon.com>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Dragos Tatulea <dtatulea@nvidia.com>,
David Woodhouse <dwmw2@infradead.org>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@kernel.org>,
Alasdair McWilliam <alasdair@mcwilliam.dev>,
bpf@vger.kernel.org, Nimrod Oren <noren@nvidia.com>,
nh-open-source@amazon.com, linux-kernel@vger.kernel.org,
kernel-team@cloudflare.com
Subject: Re: [RFC net-next 0/6] net: configurable extra TX headroom for local egress
Date: Fri, 6 Nov 2026 20:59:39 +0000 [thread overview]
Message-ID: <20261106205939.95366-1-tianyi@cloudflare.com> (raw)
In-Reply-To: <au4j2nQdOwr90ffh@dev-dsk-dkeogh-ai2-36d3b9a7.us-west-2.amazon.com>
Hi David,
Thanks for the review, and for testing it on x86_64 and arm64.
On Fri, Nov 06, 2026 at 07:00:42PM +0000, David Keogh wrote:
> Tianyi, you have a second use case for this: an XDP program on a veth
> peer. Please describe it here, as it bears directly on the points
> raised above.
At Cloudflare we run some services each in its own network namespace.
A veth pair connects the namespace to the host: veth0 is in the host
and veth1 is in the namespace, with an XDP program on veth1. XDP needs
XDP_PACKET_HEADROOM (256 bytes) in front of each packet. The packets
that the host sends into veth0 have much less: 2 bytes from a UDP
socket and 64 bytes from AF_XDP. So veth1 copies each of them into a
new buffer before the program runs.
Raising needed_headroom on veth0 is not an option. The v1 cover letter
has the details.
> I suggest you post v1, with patches 1-4 from me and 5-8 from you, and
> the cover letter under your own name, since the veth XDP case and the
> new measurements are yours.
I am happy to post v1 as you suggest. I will fold in the points
you listed and post it on the latest net-next. Thanks for the TCP test
as well.
Thanks,
Tianyi
prev parent reply other threads:[~2026-11-06 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 23:53 David Keogh
2026-10-15 23:53 ` [RFC net-next 1/6] net: add tx_extra_headroom and LL_ALLOC_SPACE() David Keogh
2026-10-15 23:53 ` [RFC net-next 2/6] net: reserve extra TX headroom for local egress David Keogh
2026-10-15 23:53 ` [RFC net-next 3/6] rtnetlink: add IFLA_TX_EXTRA_HEADROOM David Keogh
2026-10-15 23:53 ` [RFC net-next 4/6] selftests: net: add tx_extra_headroom test David Keogh
2026-10-15 23:53 ` [RFC net-next 5/6] selftests/bpf: add tx_extra_headroom data-plane programs David Keogh
2026-10-15 23:53 ` [RFC net-next 6/6] selftests/net: add tx_extra_headroom data-plane test David Keogh
2026-10-16 8:02 ` [RFC net-next 0/6] net: configurable extra TX headroom for local egress David Woodhouse
2026-10-16 18:48 ` Dragos Tatulea
2026-10-16 19:01 ` Daniel Borkmann
2026-10-19 6:12 ` David Keogh
2026-11-06 19:00 ` David Keogh
2026-11-06 20:59 ` Tianyi Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106205939.95366-1-tianyi@cloudflare.com \
--to=tianyi@cloudflare.com \
--cc=alasdair@mcwilliam.dev \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dkeogh@amazon.com \
--cc=dtatulea@nvidia.com \
--cc=dwmw2@infradead.org \
--cc=edumazet@kernel.org \
--cc=hawk@kernel.org \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nh-open-source@amazon.com \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®